Refactor

spec/epp/session_spec.rb

@@ -16,61 +16,46 @@ describe 'EPP Session', epp: true do
     after(:each) { server.close_connection }
 
     it 'does not log in with invalid user' do
-      response = Nokogiri::XML(server.send_request(read_body('login.xml')))
+      response = epp_request('login.xml')
-      result = response.css('epp response result').first
+      expect(response[:result_code]).to eq('2501')
-      expect(result[:code]).to eq('2501')
+      expect(response[:msg]).to eq('Authentication error; server closing connection')
-
-      msg = response.css('epp response result msg').text
-      expect(msg).to eq('Authentication error; server closing connection')
 
       Fabricate(:epp_user, active: false)
 
-      response = Nokogiri::XML(server.send_request(read_body('login.xml')))
+      response = epp_request('login.xml')
-      result = response.css('epp response result').first
+      expect(response[:result_code]).to eq('2501')
-      expect(result[:code]).to eq('2501')
     end
 
     it 'prohibits further actions unless logged in' do
-      response = Nokogiri::XML(server.send_request(read_body('create_domain.xml')))
+      response = epp_request('create_domain.xml')
-      expect(parse_result_code(response)).to eq('2002')
+      expect(response[:result_code]).to eq('2002')
-
+      expect(response[:msg]).to eq('You need to login first.')
-      msg = response.css('epp response result msg').text
-      expect(msg).to eq('You need to login first.')
     end
 
-    it 'logs in epp user' do
+    context 'with valid user' do
-      Fabricate(:epp_user)
+      before(:each) { Fabricate(:epp_user) }
 
-      response = Nokogiri::XML(server.send_request(read_body('login.xml')))
+      it 'logs in epp user' do
+        response = epp_request('login.xml')
+        expect(response[:result_code]).to eq('1000')
+        expect(response[:msg]).to eq('Command completed successfully')
+      end
 
-      result = response.css('epp response result').first
+      it 'logs out epp user' do
-      expect(result[:code]).to eq('1000')
+        epp_request('login.xml')
 
-      msg = response.css('epp response result msg').text
+        response = epp_request('logout.xml')
-      expect(msg).to eq('Command completed successfully')
+        expect(response[:result_code]).to eq('1500')
-    end
+        expect(response[:msg]).to eq('Command completed successfully; ending session')
+      end
 
-    it 'logs out epp user' do
+      it 'does not log in twice' do
-      Fabricate(:epp_user)
+        epp_request('login.xml')
-      server.send_request(read_body('login.xml'))
-      response = Nokogiri::XML(server.send_request(read_body('logout.xml')))
-      result = response.css('epp response result').first
-      expect(result[:code]).to eq('1500')
 
-      msg = response.css('epp response result msg').text
+        response = epp_request('login.xml')
-      expect(msg).to eq('Command completed successfully; ending session')
+        expect(response[:result_code]).to eq('2002')
-    end
+        expect(response[:msg]).to match(/Already logged in. Use/)
-
+      end
-    it 'does not log in twice' do
-      Fabricate(:epp_user)
-      server.send_request(read_body('login.xml'))
-      response = Nokogiri::XML(server.send_request(read_body('login.xml')))
-
-      result = response.css('epp response result').first
-      expect(result[:code]).to eq('2002')
-
-      msg = response.css('epp response result msg').text
-      expect(msg).to match(/Already logged in. Use/)
     end
   end
 end

spec/support/epp.rb

@@ -3,9 +3,15 @@ module Epp
     File.read("spec/epp/requests/#{filename}")
   end
 
-  def parse_result_code response
+  def epp_request filename
-    response.css('epp response result').first[:code]
+    response = Nokogiri::XML(server.send_request(read_body(filename)))
+
+    {
+      result_code: response.css('epp response result').first[:code],
+      msg: response.css('epp response result msg').text
+    }
   end
+
 end
 
 RSpec.configure do |c|