From d7eca597d1fec8af76db2c1841b801f538c40c56 Mon Sep 17 00:00:00 2001 From: Maciej Szlosarczyk Date: Sun, 22 Apr 2018 19:49:39 +0300 Subject: [PATCH] Add explicit return to fix failing test --- app/controllers/registrar/payments_controller.rb | 6 ++---- app/models/payments/bank_link.rb | 3 ++- app/models/payments/every_pay.rb | 5 +++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/app/controllers/registrar/payments_controller.rb b/app/controllers/registrar/payments_controller.rb index 793f0226b..1c546014c 100644 --- a/app/controllers/registrar/payments_controller.rb +++ b/app/controllers/registrar/payments_controller.rb @@ -45,11 +45,9 @@ class Registrar if @payment.valid_response_from_intermediary? && @payment.settled_payment? @payment.complete_transaction - - if invoice.binded? - render status: 200, json: { ok: :ok } - end end + + render status: 200, json: { status: 'ok' } end private diff --git a/app/models/payments/bank_link.rb b/app/models/payments/bank_link.rb index 35004e487..8932ae019 100644 --- a/app/models/payments/bank_link.rb +++ b/app/models/payments/bank_link.rb @@ -65,7 +65,8 @@ module Payments transaction.paid_at = Time.parse(response["VK_T_DATETIME"]) transaction.save! - transaction.autobind_invoice + account_activity = transaction.autobind_invoice + account_activity end def settled_payment? diff --git a/app/models/payments/every_pay.rb b/app/models/payments/every_pay.rb index 0556f3c5a..1365cd30d 100644 --- a/app/models/payments/every_pay.rb +++ b/app/models/payments/every_pay.rb @@ -40,9 +40,10 @@ module Payments transaction.sum = response[:amount] transaction.paid_at = DateTime.strptime(response[:timestamp], '%s') transaction.buyer_name = response[:cc_holder_name] - transaction.save! - transaction.autobind_invoice + transaction.save! + account_activity = transaction.autobind_invoice + account_activity end private