zydronium/internetee-registry
1
0
Fork 0
mirror of https://github.com/internetee/registry.git synced 2025-06-11 07:04:47 +02:00
Code Issues Projects Releases Packages Wiki Activity

fixed dnskey invalid alg response

Browse source
This commit is contained in:
Oleg Hasjanov 2021-06-21 13:50:45 +03:00
parent 2bdb235610
commit d79d1fbeb1
2 changed files with 32 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/models/dnskey.rb
View file

@ -60,7 +60,7 @@ class Dnskey < ApplicationRecord
def validate_algorithm def validate_algorithm
return if alg.blank? return if alg.blank?
return if ALGORITHMS.include?(alg.to_s) return if ALGORITHMS.include?(alg.to_s)
errors.add(:alg, :invalid, values: "Valid algorithms are: #{ALGORITHMS.join(', ')}") errors.add(:alg, :invalid, values: "#{ALGORITHMS.join(', ')}")
end end
def validate_protocol def validate_protocol

31
test/integration/epp/domain/update/base_test.rb
View file

@ -17,6 +17,37 @@ class EppDomainUpdateBaseTest < EppTestCase
@original_registrant_change_verification @original_registrant_change_verification
end end
def test_update_dnskey_with_invalid_alg
request_xml = <<~XML
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<epp xmlns="#{Xsd::Schema.filename(for_prefix: 'epp-ee')}">
<command>
<update>
<domain:update xmlns:domain="#{Xsd::Schema.filename(for_prefix: 'domain-ee')}">
<domain:name>shop.test</domain:name>
</domain:update>
</update>
<extension>
<secDNS:update xmlns:secDNS="urn:ietf:params:xml:ns:secDNS-1.1">
<secDNS:add><secDNS:keyData>
<secDNS:flags>257</secDNS:flags>
<secDNS:protocol>3</secDNS:protocol>
<secDNS:alg>666</secDNS:alg>
<secDNS:pubKey>P25MwGXr2sTbxdOIKRNbSC8bUO2CObo4/T8kMFoKcgs=</secDNS:pubKey>
</secDNS:keyData></secDNS:add>
</secDNS:update>
</extension>
</command>
</epp>
XML
post epp_update_path, params: { frame: request_xml },
headers: { 'HTTP_COOKIE' => 'session=api_bestnames' }
response_xml = Nokogiri::XML(response.body)
assert_correct_against_schema response_xml
assert_epp_response :parameter_value_syntax_error
end
def test_update_domain def test_update_domain
request_xml = <<-XML request_xml = <<-XML
<?xml version="1.0" encoding="UTF-8" standalone="no"?> <?xml version="1.0" encoding="UTF-8" standalone="no"?>