zydronium/internetee-registry
1
0
Fork 0
mirror of https://github.com/internetee/registry.git synced 2025-06-06 20:55:44 +02:00
Code Issues Projects Releases Packages Wiki Activity

Revert "Mark orphan notification as read"

Browse source
This commit is contained in:
Alex Sherman 2021-07-14 16:43:16 +05:00 • committed by GitHub
parent 25d743c1ca
commit cfb74cc7da
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 0 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

1
app/controllers/epp/polls_controller.rb
View file

@ -27,7 +27,6 @@ module Epp
Rails.logger.error 'orphan message, error ignored: ' + problem.to_s Rails.logger.error 'orphan message, error ignored: ' + problem.to_s
# now we should dequeue or delete the messages avoid duplicate log alarms # now we should dequeue or delete the messages avoid duplicate log alarms
@notification.mark_as_read
end end
end end

25
test/integration/epp/poll_test.rb
View file

@ -26,31 +26,6 @@ class EppPollTest < EppTestCase
assert_equal 'Your domain has been updated', xml_doc.at_css('msgQ msg').text assert_equal 'Your domain has been updated', xml_doc.at_css('msgQ msg').text
end end
def test_clears_orphan_messages_if_any
# To check if we are clearing orphan messages we need to create a message not linked to any
# existing Epp::Domain
orphan_notification = @notification.dup
orphan_notification.attached_obj_type = Epp::Domain
orphan_notification.attached_obj_id = rand(Epp::Domain.first.id-1)
orphan_notification.save!
assert orphan_notification.unread?
request_xml = <<-XML
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<epp xmlns="#{Xsd::Schema.filename(for_prefix: 'epp-ee', for_version: '1.0')}">
<command>
<poll op="req"/>
</command>
</epp>
XML
post epp_poll_path, params: { frame: request_xml },
headers: { 'HTTP_COOKIE' => 'session=api_bestnames' }
orphan_notification.reload
refute orphan_notification.unread?
end
def test_does_not_drop_error_if_old_version def test_does_not_drop_error_if_old_version
version = Version::DomainVersion.last version = Version::DomainVersion.last
@notification.update(attached_obj_type: 'DomainVersion', attached_obj_id: version.id) @notification.update(attached_obj_type: 'DomainVersion', attached_obj_id: version.id)