zydronium/internetee-registry
1
0
Fork 0
mirror of https://github.com/internetee/registry.git synced 2025-06-06 20:55:44 +02:00
Code Issues Projects Releases Packages Wiki Activity

Improve mass action tests

Browse source
This commit is contained in:
Karl Erik Õunapuu 2020-11-05 15:37:28 +02:00
parent b61fe5f7b4
commit cfa44f7692
No known key found for this signature in database
GPG key ID: C9DD647298A34764
6 changed files with 18 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/controllers/admin/mass_actions_controller.rb
View file

@ -12,7 +12,7 @@ module Admin
res = MassAction.process(params[:mass_action], params[:entry_list].path) res = MassAction.process(params[:mass_action], params[:entry_list].path)
notice = if res notice = if res
"#{params[:mass_action]} completed for #{res[:ok]}.\n" \ "#{params[:mass_action]} completed for #{res[:ok]}.\n" \
"Failed: objects: #{res[:fail]}" "Failed: #{res[:fail]}"
else else
"Dataset integrity validation failed for #{params[:mass_action]}" "Dataset integrity validation failed for #{params[:mass_action]}"
end end

8
app/models/mass_action.rb
View file

@ -1,9 +1,9 @@
class MassAction class MassAction
def self.process(action_type, entries) def self.process(action_type, entries)
entries = CSV.read(entries, headers: true) return false unless %w[force_delete].include?(action_type)
return process_force_delete(entries) if action_type == 'force_delete'
false entries = CSV.read(entries, headers: true)
process_force_delete(entries) if action_type == force_delete
rescue StandardError rescue StandardError
false false
end end
@ -29,7 +29,7 @@ class MassAction
def self.force_delete_entries_valid?(entries) def self.force_delete_entries_valid?(entries)
entries.each do |e| entries.each do |e|
reasons = %w[IDENT_BURIED EMAIL PHONE] reasons = %w[ENTITY_BURIED EMAIL PHONE]
return false unless e['domain_name'].present? && reasons.include?(e['delete_reason']) return false unless e['domain_name'].present? && reasons.include?(e['delete_reason'])
end end

0
test/fixtures/files/invalid_mass_force_delete_list.csv → test/fixtures/files/mass_actions/invalid_mass_force_delete_list.csv vendored
View file

5
test/fixtures/files/mass_actions/valid_mass_force_delete_list.csv vendored Normal file
View file

@ -0,0 +1,5 @@
domain_name,delete_reason
shop.test,ENTITY_BURIED
airport.test,PHONE
library.test,EMAIL
nonexistant.test,ENTITY_BURIED
1 domain_name delete_reason
2 shop.test ENTITY_BURIED
3 airport.test PHONE
4 library.test EMAIL
5 nonexistant.test ENTITY_BURIED

2
test/fixtures/files/valid_mass_force_delete_list.csv vendored
View file

@ -1,2 +0,0 @@
domain_name,delete_reason
shop.test,ENTITY_BURIED
1 domain_name delete_reason
2 shop.test ENTITY_BURIED

11
test/system/admin_area/mass_actions/mass_force_delete_test.rb
View file

@ -9,15 +9,20 @@ class AdminAreaMassActionsForceDeleteTest < ApplicationSystemTestCase
def test_processes_uploaded_valid_csv def test_processes_uploaded_valid_csv
visit admin_mass_actions_path visit admin_mass_actions_path
attach_file('entry_list', Rails.root.join('test', 'fixtures', 'files', 'valid_mass_force_delete_list.csv').to_s) attach_file('entry_list', Rails.root.join('test', 'fixtures', 'files', 'mass_actions', 'valid_mass_force_delete_list.csv').to_s)
click_link_or_button 'Start force delete process' click_link_or_button 'Start force delete process'
assert_text 'force_delete completed for ["shop.test"]. Failed: objects: []' assert_text 'force_delete completed for ["shop.test", "airport.test", "library.test"]. Failed: ["nonexistant.test"]'
end end
def test_processes_uploaded_invalid_csv def test_processes_uploaded_invalid_csv
visit admin_mass_actions_path visit admin_mass_actions_path
attach_file(:entry_list, Rails.root.join('test', 'fixtures', 'files', 'invalid_mass_force_delete_list.csv').to_s)
attach_file(:entry_list, Rails.root.join('test', 'fixtures', 'files', 'mass_actions', 'invalid_mass_force_delete_list.csv').to_s)
click_link_or_button 'Start force delete process' click_link_or_button 'Start force delete process'
assert_text 'Dataset integrity validation failed for force_delete' assert_text 'Dataset integrity validation failed for force_delete'
end end
def test_logs_failed_domains_to_response
end
end end