diff --git a/CHANGELOG.md b/CHANGELOG.md index 217da6ecb..1241486d3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,8 @@ +22.02.2018 +* BUG: Registrar: contact list export is not limited to 75 records any more [#721](https://github.com/internetee/registry/issues/721) +* BUG: EPP: domain and associated objects are not validated on domain delete [#707](https://github.com/internetee/registry/issues/707) +* EPP: improved session management (db constraints, model and db structure refactor, auto-tests) [#700](https://github.com/internetee/registry/issues/700) + 11.02.2018 * BUG: Disable all object validations on domain transfer [#701](https://github.com/internetee/registry/issues/701) diff --git a/app/models/epp/domain.rb b/app/models/epp/domain.rb index 969d9a9bc..a59094d1e 100644 --- a/app/models/epp/domain.rb +++ b/app/models/epp/domain.rb @@ -556,8 +556,6 @@ class Epp::Domain < Domain end def epp_destroy(frame, user_id) - return false unless valid? - check_discarded if doc = attach_legal_document(Epp::Domain.parse_legal_document_from_frame(frame)) diff --git a/test/fixtures/contacts.yml b/test/fixtures/contacts.yml index 2a9898543..8c0fb4e10 100644 --- a/test/fixtures/contacts.yml +++ b/test/fixtures/contacts.yml @@ -34,5 +34,6 @@ acme_ltd: invalid: name: any code: any + email: invalid@invalid.test auth_info: any registrar: bestnames diff --git a/test/fixtures/domain_contacts.yml b/test/fixtures/domain_contacts.yml index 8a429f628..fd60e8c99 100644 --- a/test/fixtures/domain_contacts.yml +++ b/test/fixtures/domain_contacts.yml @@ -12,3 +12,13 @@ library_john: domain: library contact: john type: AdminDomainContact + +invalid_invalid_admin: + domain: invalid + contact: invalid + type: AdminDomainContact + +invalid_invalid_tech: + domain: invalid + contact: invalid + type: TechDomainContact diff --git a/test/fixtures/domains.yml b/test/fixtures/domains.yml index 7c7b429cf..7c0844d97 100644 --- a/test/fixtures/domains.yml +++ b/test/fixtures/domains.yml @@ -27,3 +27,10 @@ library: valid_to: 2010-07-05 period: 1 period_unit: m + +invalid: + name: invalid.test + transfer_code: any + valid_to: 2010-07-05 + registrar: bestnames + registrant: invalid diff --git a/test/integration/epp/domain/domain_delete_test.rb b/test/integration/epp/domain/domain_delete_test.rb new file mode 100644 index 000000000..bdd326a3e --- /dev/null +++ b/test/integration/epp/domain/domain_delete_test.rb @@ -0,0 +1,28 @@ +require 'test_helper' + +class EppDomainDeleteTest < ActionDispatch::IntegrationTest + def test_bypasses_domain_and_registrant_and_contacts_validation + request_xml = <<-XML + + + + + + invalid.test + + + + + dGVzdCBmYWlsCg== + + + + + XML + + post '/epp/command/delete', { frame: request_xml }, { 'HTTP_COOKIE' => 'session=api_bestnames' } + assert_includes Domain.find_by(name: 'invalid.test').statuses, DomainStatus::PENDING_DELETE_CONFIRMATION + assert_equal '1001', Nokogiri::XML(response.body).at_css('result')[:code] + assert_equal 1, Nokogiri::XML(response.body).css('result').size + end +end diff --git a/test/integration/registrar/domains_test.rb b/test/integration/registrar/domains_test.rb index 51b76fc7c..f3936c578 100644 --- a/test/integration/registrar/domains_test.rb +++ b/test/integration/registrar/domains_test.rb @@ -9,6 +9,7 @@ class RegistrarDomainsTest < ActionDispatch::IntegrationTest Domain,Transfer code,Registrant name,Registrant code,Date of expiry library.test,45118f5,Acme Ltd,acme-ltd-001,2010-07-05 shop.test,65078d5,John,john-001,2010-07-05 + invalid.test,any,any,any,2010-07-05 airport.test,55438j5,John,john-001,2010-07-05 CSV diff --git a/test/models/contact/contact_test.rb b/test/models/contact/contact_test.rb index c4f26f4a3..ef958e2a4 100644 --- a/test/models/contact/contact_test.rb +++ b/test/models/contact/contact_test.rb @@ -5,7 +5,7 @@ class ContactTest < ActiveSupport::TestCase @contact = contacts(:john) end - def test_validates + def test_valid_fixture_is_valid assert @contact.valid? end diff --git a/test/models/domain/domain_test.rb b/test/models/domain/domain_test.rb index a2c3fae55..c67c8ee87 100644 --- a/test/models/domain/domain_test.rb +++ b/test/models/domain/domain_test.rb @@ -5,7 +5,11 @@ class DomainTest < ActiveSupport::TestCase @domain = domains(:shop) end - def test_validates + def test_valid_fixture_is_valid assert @domain.valid? end + + def test_invalid_fixture_is_invalid + assert domains(:invalid).invalid? + end end