From c815da3afd356c3766663a01b57df1a31c2f5cae Mon Sep 17 00:00:00 2001
From: Artur Beljajev <artur.beljajev@internet.ee>
Date: Tue, 10 Dec 2019 16:11:51 +0200
Subject: [PATCH] Extract partials

---
 app/views/admin/api_users/show.html.erb       | 82 +------------------
 .../api_users/show/_certificates.html.erb     | 55 +++++++++++++
 .../admin/api_users/show/_details.html.erb    | 26 ++++++
 config/locales/admin/api_users.en.yml         |  8 +-
 4 files changed, 89 insertions(+), 82 deletions(-)
 create mode 100644 app/views/admin/api_users/show/_certificates.html.erb
 create mode 100644 app/views/admin/api_users/show/_details.html.erb

diff --git a/app/views/admin/api_users/show.html.erb b/app/views/admin/api_users/show.html.erb
index bba7a698f..05c5651ce 100644
--- a/app/views/admin/api_users/show.html.erb
+++ b/app/views/admin/api_users/show.html.erb
@@ -26,90 +26,12 @@
 
 <div class="row">
     <div class="col-md-12">
-        <div class="panel panel-default">
-            <div class="panel-heading">
-                <h3 class="panel-title">
-                    <%= t '.header' %>
-                </h3>
-            </div>
-
-            <div class="panel-body">
-                <dl class="dl-horizontal">
-                    <dt><%= ApiUser.human_attribute_name :username %></dt>
-                    <dd><%= @api_user.username %></dd>
-
-                    <dt><%= ApiUser.human_attribute_name :plain_text_password %></dt>
-                    <dd><%= @api_user.plain_text_password %></dd>
-
-                    <dt><%= Registrar.model_name.human %></dt>
-                    <dd><%= link_to(@api_user.registrar, admin_registrar_path(@api_user.registrar)) %></dd>
-
-                    <dt><%= ApiUser.human_attribute_name :roles %></dt>
-                    <dd><%= @api_user.roles.join(', ') %></dd>
-
-                    <dt><%= ApiUser.human_attribute_name :active %></dt>
-                    <dd><%= @api_user.active %></dd>
-                </dl>
-            </div>
-        </div>
+        <%= render 'admin/api_users/show/details' %>
     </div>
 </div>
 
 <div class="row">
     <div class="col-md-12">
-        <div class="panel panel-default">
-            <div class="panel-heading clearfix">
-                <div class="pull-left">
-                    <%= t(:certificates) %>
-                </div>
-                <div class="pull-right">
-                    <%= link_to(t(:upload_crt), new_admin_api_user_certificate_path(@api_user, crt: true), class: 'btn btn-primary btn-xs') %>
-                    <%= link_to(t(:upload_csr), new_admin_api_user_certificate_path(@api_user), class: 'btn btn-primary btn-xs') %>
-                </div>
-            </div>
-
-            <div class="table-responsive">
-                <table class="table table-hover table-bordered table-condensed">
-                    <thead>
-                        <tr>
-                            <th class="col-xs-10">
-                                <%= t('.subject') %>
-                            </th>
-                            <th class="col-xs-2">
-                                <%= t(:status) %>
-                            </th>
-                        </tr>
-                    </thead>
-
-                    <tbody>
-                        <% @api_user.certificates.each do |x| %>
-                            <% if x.csr %>
-                                <tr>
-                                    <td>
-                                        <%= link_to(x.parsed_csr.try(:subject),
-                                                    admin_api_user_certificate_path(@api_user,
-                                                                                    x)) %>
-                                    </td>
-                                    <td>
-                                        <%= x.status %>
-                                    </td>
-                                </tr>
-                            <% elsif x.crt %>
-                                <tr>
-                                    <td>
-                                        <%= link_to(x.parsed_crt.try(:subject),
-                                                    admin_api_user_certificate_path(@api_user,
-                                                                                    x)) %>
-                                    </td>
-                                    <td>
-                                        <%= x.status %>
-                                    </td>
-                                </tr>
-                            <% end %>
-                        <% end %>
-                    </tbody>
-                </table>
-            </div>
-        </div>
+        <%= render 'admin/api_users/show/certificates' %>
     </div>
 </div>
diff --git a/app/views/admin/api_users/show/_certificates.html.erb b/app/views/admin/api_users/show/_certificates.html.erb
new file mode 100644
index 000000000..75a3cc2df
--- /dev/null
+++ b/app/views/admin/api_users/show/_certificates.html.erb
@@ -0,0 +1,55 @@
+<div class="panel panel-default">
+    <div class="panel-heading clearfix">
+        <div class="pull-left">
+            <%= t(:certificates) %>
+        </div>
+
+        <div class="pull-right">
+            <%= link_to(t(:upload_crt), new_admin_api_user_certificate_path(@api_user, crt: true), class: 'btn btn-primary btn-xs') %>
+            <%= link_to(t(:upload_csr), new_admin_api_user_certificate_path(@api_user), class: 'btn btn-primary btn-xs') %>
+        </div>
+    </div>
+
+    <div class="table-responsive">
+        <table class="table table-hover table-bordered table-condensed">
+            <thead>
+                <tr>
+                    <th class="col-xs-10">
+                        <%= t('.subject') %>
+                    </th>
+                    <th class="col-xs-2">
+                        <%= t(:status) %>
+                    </th>
+                </tr>
+            </thead>
+
+            <tbody>
+                <% @api_user.certificates.each do |x| %>
+                    <% if x.csr %>
+                        <tr>
+                            <td>
+                                <%= link_to(x.parsed_csr.try(:subject),
+                                            admin_api_user_certificate_path(@api_user,
+                                                                            x)) %>
+                            </td>
+                            <td>
+                                <%= x.status %>
+                            </td>
+                        </tr>
+                    <% elsif x.crt %>
+                        <tr>
+                            <td>
+                                <%= link_to(x.parsed_crt.try(:subject),
+                                            admin_api_user_certificate_path(@api_user,
+                                                                            x)) %>
+                            </td>
+                            <td>
+                                <%= x.status %>
+                            </td>
+                        </tr>
+                    <% end %>
+                <% end %>
+            </tbody>
+        </table>
+    </div>
+</div>
diff --git a/app/views/admin/api_users/show/_details.html.erb b/app/views/admin/api_users/show/_details.html.erb
new file mode 100644
index 000000000..c98f23866
--- /dev/null
+++ b/app/views/admin/api_users/show/_details.html.erb
@@ -0,0 +1,26 @@
+<div class="panel panel-default">
+    <div class="panel-heading">
+        <h3 class="panel-title">
+            <%= t '.header' %>
+        </h3>
+    </div>
+
+    <div class="panel-body">
+        <dl class="dl-horizontal">
+            <dt><%= ApiUser.human_attribute_name :username %></dt>
+            <dd><%= @api_user.username %></dd>
+
+            <dt><%= ApiUser.human_attribute_name :plain_text_password %></dt>
+            <dd><%= @api_user.plain_text_password %></dd>
+
+            <dt><%= Registrar.model_name.human %></dt>
+            <dd><%= link_to(@api_user.registrar, admin_registrar_path(@api_user.registrar)) %></dd>
+
+            <dt><%= ApiUser.human_attribute_name :roles %></dt>
+            <dd><%= @api_user.roles.join(', ') %></dd>
+
+            <dt><%= ApiUser.human_attribute_name :active %></dt>
+            <dd><%= @api_user.active %></dd>
+        </dl>
+    </div>
+</div>
diff --git a/config/locales/admin/api_users.en.yml b/config/locales/admin/api_users.en.yml
index bd3772556..9fde2db14 100644
--- a/config/locales/admin/api_users.en.yml
+++ b/config/locales/admin/api_users.en.yml
@@ -11,12 +11,16 @@ en:
         created: API user has been successfully created
 
       show:
-        header: Details
-        subject: Subject
         edit_btn: Edit
         delete_btn: Delete
         delete_btn_confirm: Are you sure you want to delete this API user?
 
+        details:
+          header: Details
+
+        certificates:
+          subject: Subject
+
       edit:
         header: Edit API user