Create new records on registrar nameserver replace

#661

test/fixtures/contacts.yml

@@ -42,6 +42,17 @@ acme_ltd:
   code: acme-ltd-001
   auth_info: 720b3c
 
+jack:
+  name: Jack
+  email: jack@inbox.test
+  phone: '+555.555'
+  ident: 1234
+  ident_type: org
+  registrar: goodnames
+  ident_country_code: US
+  code: jack-001
+  auth_info: e2c440
+
 invalid:
   name: any
   code: any

test/fixtures/domains.yml

@@ -28,6 +28,16 @@ library:
   period: 1
   period_unit: m
 
+metro:
+  name: metro.test
+  name_dirty: metro.test
+  registrar: goodnames
+  registrant: jack
+  transfer_code: 1071ad
+  valid_to: 2010-07-05
+  period: 1
+  period_unit: m
+
 invalid:
   name: invalid.test
   transfer_code: any

test/fixtures/nameservers.yml

@@ -13,3 +13,11 @@ ns2:
   ipv6:
     - 2001:db8::2
   domain: shop
+
+airport_ns1:
+  hostname: ns1.bestnames.test
+  domain: airport
+
+metro_ns1:
+  hostname: ns1.bestnames.test
+  domain: metro

test/integration/api/nameservers/put_test.rb

@@ -1,17 +1,55 @@
 require 'test_helper'
 
 class APINameserversPutTest < ActionDispatch::IntegrationTest
-  def test_replaces_current_registrar_nameservers
+  def setup
+    @registrar = registrars(:bestnames)
+  end
+
+  def test_deletes_old_nameservers
+    previous_nameserver_ids = @registrar.nameservers.where(hostname: 'ns1.bestnames.test').ids
+    request_params = { format: :json, data: { type: 'nameserver', id: 'ns1.bestnames.test',
+                                              attributes: { hostname: 'ns55.bestnames.test' } } }
+
+    put '/repp/v1/registrar/nameservers', request_params, { 'HTTP_AUTHORIZATION' => http_auth_key }
+    refute @registrar.nameservers(true).where(id: previous_nameserver_ids).exists?
+  end
+
+  def test_creates_new_nameservers
+    request_params = { format: :json, data: { type: 'nameserver', id: 'ns1.bestnames.test',
+                                              attributes: { hostname: 'ns55.bestnames.test' } } }
+    put '/repp/v1/registrar/nameservers', request_params, { 'HTTP_AUTHORIZATION' => http_auth_key }
+    assert_equal 2, @registrar.nameservers.where(hostname: 'ns55.bestnames.test').size
+  end
+
+  def test_saves_all_attributes
     request_params = { format: :json, data: { type: 'nameserver', id: 'ns1.bestnames.test',
                                               attributes: { hostname: 'ns55.bestnames.test',
                                                             ipv4: ['192.0.2.55'],
                                                             ipv6: ['2001:db8::55'] } } }
     put '/repp/v1/registrar/nameservers', request_params, { 'HTTP_AUTHORIZATION' => http_auth_key }
 
-    new_nameserver = registrars(:bestnames).nameservers.find_by(hostname: 'ns55.bestnames.test')
-    assert_nil registrars(:bestnames).nameservers.find_by(hostname: 'ns1.bestnames.test')
+    new_nameserver = domains(:shop).nameservers.find_by(hostname: 'ns55.bestnames.test')
     assert_equal ['192.0.2.55'], new_nameserver.ipv4
     assert_equal ['2001:DB8::55'], new_nameserver.ipv6
+  end
+
+  def test_keeps_other_registrar_nameservers_intact
+    request_params = { format: :json, data: { type: 'nameserver', id: 'ns1.bestnames.test',
+                                              attributes: { hostname: 'ns55.bestnames.test' } } }
+
+    other_registrar_nameserver_ids = registrars(:goodnames).nameservers.ids
+    assert other_registrar_nameserver_ids.any?
+    put '/repp/v1/registrar/nameservers', request_params, { 'HTTP_AUTHORIZATION' => http_auth_key }
+    assert_equal other_registrar_nameserver_ids, registrars(:goodnames).nameservers(true).ids
+  end
+
+  def test_returns_new_nameserver_record
+    request_params = { format: :json, data: { type: 'nameserver', id: 'ns1.bestnames.test',
+                                              attributes: { hostname: 'ns55.bestnames.test',
+                                                            ipv4: ['192.0.2.55'],
+                                                            ipv6: ['2001:db8::55'] } } }
+    put '/repp/v1/registrar/nameservers', request_params, { 'HTTP_AUTHORIZATION' => http_auth_key }
+
     assert_response 200
     assert_equal ({ data: { type: 'nameserver',
                             id: 'ns55.bestnames.test',
@@ -21,7 +59,7 @@ class APINameserversPutTest < ActionDispatch::IntegrationTest
                  JSON.parse(response.body, symbolize_names: true)
   end
 
-  def test_honors_optional_params
+  def test_optional_params
     request_params = { format: :json, data: { type: 'nameserver', id: 'ns1.bestnames.test',
                                               attributes: { hostname: 'ns55.bestnames.test' } } }
     put '/repp/v1/registrar/nameservers', request_params, { 'HTTP_AUTHORIZATION' => http_auth_key }
@@ -44,7 +82,7 @@ class APINameserversPutTest < ActionDispatch::IntegrationTest
     put '/repp/v1/registrar/nameservers', request_params, { 'HTTP_AUTHORIZATION' => http_auth_key }
 
     assert_response 400
-    assert_equal ({ errors: [{ title: 'Invalid params' }] }),
+    assert_equal ({ errors: [{ title: 'Hostname is missing' }] }),
                  JSON.parse(response.body, symbolize_names: true)
   end