From a299aa5756e611499d22df64a4b7a7ec705c865c Mon Sep 17 00:00:00 2001 From: Priit Tark Date: Tue, 10 Mar 2015 15:19:39 +0200 Subject: [PATCH 1/2] Updated contact epp doc --- doc/epp/contact.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/doc/epp/contact.md b/doc/epp/contact.md index a9f8406ac..381844997 100644 --- a/doc/epp/contact.md +++ b/doc/epp/contact.md @@ -34,6 +34,7 @@ Contact Mapping protocol short version: "birthday" # Birthday date in format in DD-MM-YYYY 0-1 Base64 encoded document Attribute: type="pdf/bdoc/ddoc/zip/rar/gz/tar/7z" + 0-1 Client transaction id [EXAMPLE REQUEST AND RESPONSE](/doc/epp-examples.md#epp-contact-with-valid-user-create-command-successfully-creates-a-contact) @@ -67,6 +68,7 @@ Contact Mapping protocol short version: "birthday" # Birthday date in format in DD-MM-YYYY 0-1 Base64 encoded document. Attribute: type="pdf/bdoc/ddoc/zip/rar/gz/tar/7z" + 0-1 Client transaction id [EXAMPLE REQUEST AND RESPONSE](/doc/epp-examples.md#epp-contact-with-valid-user-update-command-is-succesful) @@ -108,6 +110,8 @@ Contact Mapping protocol short version: 1 1 Attribute: xmlns:contact="urn:ietf:params:xml:ns:contact-1.0" 1-n Contact id + 0-1 Required if registrar is not the owner of the contact. + 1 Contact password. Attribute: roid="String" 0-1 Client transaction id [EXAMPLE REQUEST AND RESPONSE](/doc/epp-examples.md#epp-contact-with-valid-user-info-command-discloses-items-to-owner) From 1d8e43b89971b527f7a2668124c2e26705eb3a80 Mon Sep 17 00:00:00 2001 From: Priit Tark Date: Tue, 10 Mar 2015 15:37:21 +0200 Subject: [PATCH 2/2] Domain transfere now not require LegalDoc --- app/controllers/epp/domains_controller.rb | 2 -- doc/epp/domain.md | 6 +++--- spec/epp/domain_spec.rb | 19 +++++++++++++++---- 3 files changed, 18 insertions(+), 9 deletions(-) diff --git a/app/controllers/epp/domains_controller.rb b/app/controllers/epp/domains_controller.rb index e14501521..41a5e6aa5 100644 --- a/app/controllers/epp/domains_controller.rb +++ b/app/controllers/epp/domains_controller.rb @@ -147,8 +147,6 @@ class Epp::DomainsController < EppController @prefix = nil requires_attribute 'transfer', 'op', values: %(approve, query, reject) - - requires 'extension > extdata > legalDocument' end ## DELETE diff --git a/doc/epp/domain.md b/doc/epp/domain.md index e7ba283a4..c99f5e58b 100644 --- a/doc/epp/domain.md +++ b/doc/epp/domain.md @@ -144,9 +144,9 @@ Domain name mapping protocol short version: Attribute: hosts="all / TODO" 1 1 Domain password. Attribute: roid="String" - 1 - 1 Attribute: xmlns:eis="urn:ee:eis:xml:epp:eis-1.0" - 1 Base64 encoded document. + 0-1 + 0-1 Attribute: xmlns:eis="urn:ee:eis:xml:epp:eis-1.0" + 0-1 Base64 encoded document. Attribute: type="pdf/bdoc/ddoc/zip/rar/gz/tar/7z" 0-1 Client transaction id diff --git a/spec/epp/domain_spec.rb b/spec/epp/domain_spec.rb index c23e79b4c..14fbd7b98 100644 --- a/spec/epp/domain_spec.rb +++ b/spec/epp/domain_spec.rb @@ -856,7 +856,7 @@ describe 'EPP Domain', epp: true do create_settings end - it 'does not create a domain transfer without legal document' do + it 'creates transfer successfully without legal document' do pw = domain.auth_info xml = domain_transfer_xml({ name: { value: domain.name }, @@ -865,9 +865,20 @@ describe 'EPP Domain', epp: true do login_as :registrar2 do response = epp_plain_request(xml, :xml) - response[:result_code].should == '2003' - response[:msg].should == - 'Required parameter missing: extension > extdata > legalDocument [legal_document]' + response[:msg].should == 'Command completed successfully' + response[:result_code].should == '1000' + end + end + + it 'should not creates transfer without password' do + xml = domain_transfer_xml({ + name: { value: domain.name } + }) + + login_as :registrar2 do + response = epp_plain_request(xml, :xml) + response[:msg].should == 'Authorization error' + response[:result_code].should == '2201' end end