From b8ade7628d62f9400999b0b62d91107573c511e1 Mon Sep 17 00:00:00 2001 From: Alex Sherman Date: Thu, 4 Jun 2020 15:35:09 +0500 Subject: [PATCH] Add tests to see if Truemail validates ok --- test/models/contact_test.rb | 23 ++++++++++++++---- test/models/registrar_test.rb | 46 +++++++++++++++++++++++++++-------- 2 files changed, 54 insertions(+), 15 deletions(-) diff --git a/test/models/contact_test.rb b/test/models/contact_test.rb index 4e500e98d..77e959a95 100644 --- a/test/models/contact_test.rb +++ b/test/models/contact_test.rb @@ -61,14 +61,27 @@ class ContactTest < ActiveSupport::TestCase assert contact.invalid? end - def test_validates_email_format - contact = valid_contact + def tests_email_mx_and_smtp + Truemail.configure do |config| + config.default_validation_type = :smtp + end - contact.email = 'invalid' + contact = valid_contact + contact.email = 'info@internet.ee' + assert contact.valid? + + contact.email = 'somecrude1337joke@internet.ee' assert contact.invalid? - contact.email = 'valid@registrar.test' - assert contact.valid? + contact.email = 'some@strangesentence@internet.ee' + assert contact.invalid? + + contact.email = 'somecrude31337joke@somestrange31337domain.ee' + assert contact.invalid? + + Truemail.configure do |config| + config.default_validation_type = :regex + end end def test_invalid_without_phone diff --git a/test/models/registrar_test.rb b/test/models/registrar_test.rb index c5d832922..6db466e1c 100644 --- a/test/models/registrar_test.rb +++ b/test/models/registrar_test.rb @@ -38,14 +38,27 @@ class RegistrarTest < ActiveSupport::TestCase assert registrar.invalid? end - def test_email_format_validation - registrar = valid_registrar + def tests_email_mx_and_smtp + Truemail.configure do |config| + config.default_validation_type = :smtp + end - registrar.email = 'invalid' + registrar = valid_registrar + registrar.email = 'info@internet.ee' + assert registrar.valid? + + registrar.email = 'somecrude1337joke@internet.ee' assert registrar.invalid? - registrar.email = 'valid@email.test' - assert registrar.valid? + registrar.email = 'some@strangesentence@internet.ee' + assert registrar.invalid? + + registrar.email = 'somecrude31337joke@somestrange31337domain.ee' + assert registrar.invalid? + + Truemail.configure do |config| + config.default_validation_type = :regex + end end def test_invalid_without_accounting_customer_code @@ -60,14 +73,27 @@ class RegistrarTest < ActiveSupport::TestCase assert registrar.valid? end - def test_billing_email_format_validation - registrar = valid_registrar + def tests_email_mx_and_smtp + Truemail.configure do |config| + config.default_validation_type = :smtp + end - registrar.billing_email = 'invalid' + registrar = valid_registrar + registrar.billing_email = 'info@internet.ee' + assert registrar.valid? + + registrar.billing_email = 'somecrude1337joke@internet.ee' assert registrar.invalid? - registrar.billing_email = 'valid@email.test' - assert registrar.valid? + registrar.billing_email = 'непонятное@словосочетание@internet.ee' + assert registrar.invalid? + + registrar.billing_email = 'somecrude31337joke@somestrange31337domain.ee' + assert registrar.invalid? + + Truemail.configure do |config| + config.default_validation_type = :regex + end end def test_returns_billing_email_when_provided