zydronium/internetee-registry
1
0
Fork 0
mirror of https://github.com/internetee/registry.git synced 2025-08-11 03:59:33 +02:00
Code Issues Projects Releases Packages Wiki Activity

Fix codeclimate errors

Browse source
This commit is contained in:
dinsmol 2021-12-15 10:39:34 +03:00 • committed by olegphenomenon
parent 6b028814c3
commit b8a59745de
1 changed files with 6 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

14
app/controllers/registrar/domains_controller.rb
View file

@ -91,14 +91,12 @@ class Registrar
def create def create
authorize! :create, Depp::Domain authorize! :create, Depp::Domain
@domain_params = domain_params.to_h @domain_params = domain_params.to_h
if contacts_check = check_contacts @data = @domain.create(@domain_params) if emails_valid?
@data = @domain.create(@domain_params)
end
if @data && response_ok? if @data && response_ok?
redirect_to info_registrar_domains_url(domain_name: @domain_params[:name]) redirect_to info_registrar_domains_url(domain_name: @domain_params[:name])
else else
flash[:alert] = t('.email_error_message') unless contacts_check flash[:alert] = t('.email_error_message') unless @emails_check_result
render 'new' render 'new'
end end
end end
@ -113,7 +111,7 @@ class Registrar
def update def update
authorize! :update, Depp::Domain authorize! :update, Depp::Domain
@domain_params = params[:domain] @domain_params = params[:domain]
if contacts_check = check_contacts if emails_valid?
@data = @domain.update(@domain_params) @data = @domain.update(@domain_params)
@dispute = Dispute.active.find_by(domain_name: @domain_params[:name]) @dispute = Dispute.active.find_by(domain_name: @domain_params[:name])
end end
@ -121,7 +119,7 @@ class Registrar
if @data && response_ok? if @data && response_ok?
redirect_to info_registrar_domains_url(domain_name: @domain_params[:name]) redirect_to info_registrar_domains_url(domain_name: @domain_params[:name])
else else
flash[:alert] = t('.email_error_message') unless contacts_check flash[:alert] = t('.email_error_message') unless @emails_check_result
params[:domain_name] = @domain_params[:name] params[:domain_name] = @domain_params[:name]
render 'new' render 'new'
end end
@ -179,9 +177,9 @@ class Registrar
private private
def check_contacts def emails_valid?
params_as_hash = @domain_params[:contacts_attributes].to_h params_as_hash = @domain_params[:contacts_attributes].to_h
params_as_hash.all? { |_k, val| Contact.find_by(code: val[:code]).verify_email } @emails_check_result = params_as_hash.all? { |_k, val| Contact.find_by(code: val[:code]).verify_email }
end end
def init_domain def init_domain