Extract domain transfers controller

#660

app/controllers/registrar/domain_transfers_controller.rb

@@ -0,0 +1,15 @@
+class Registrar
+  class DomainTransfersController < DeppController
+    before_action do
+      authorize! :transfer, Depp::Domain
+    end
+
+    def new
+    end
+
+    def create
+      domain = Depp::Domain.new(current_user: depp_current_user)
+      @data = domain.transfer(params)
+    end
+  end
+end

app/controllers/registrar/domains_controller.rb

@@ -146,16 +146,6 @@ class Registrar
       end
     end
 
-    def transfer
-      authorize! :transfer, Depp::Domain
-      if request.post? && params[:domain_name]
-        @data = @domain.transfer(params)
-        render 'transfer_index' and return unless response_ok?
-      else
-        render 'transfer_index'
-      end
-    end
-
     def search_contacts
       authorize! :create, Depp::Domain
 

app/views/registrar/domain_transfers/new.html.erb

@@ -6,7 +6,7 @@
 
 <div class="row">
     <div class="col-md-8">
-        <%= form_tag transfer_registrar_domains_path, class: 'form-horizontal', multipart: true, autocomplete: 'off' do %>
+        <%= form_tag registrar_domain_transfers_path, class: 'form-horizontal', multipart: true, autocomplete: 'off' do %>
             <div class="form-group">
                 <div class="col-md-3 control-label">
                     <%= label_tag :domain_name, t(:name), class: 'required' %>

app/views/registrar/domains/index.html.erb

@@ -6,7 +6,7 @@
 
         <div class="col-sm-3 text-right">
             <%= link_to t('.new_btn'), new_registrar_domain_path, class: 'btn btn-primary' %>
-            <%= link_to t('.transfer_btn'), transfer_registrar_domains_path, class: 'btn btn-default' %>
+            <%= link_to t('.transfer_btn'), new_registrar_domain_transfer_path, class: 'btn btn-default' %>
         </div>
     </div>
 </div>

app/views/registrar/domains/info.html.erb

@@ -7,7 +7,7 @@
         <%= link_to(t(:delete), delete_registrar_domains_path(domain_name: params[:domain_name]),
                     class: 'btn btn-default') %>
     <% else %>
-        <%= link_to(t(:transfer), transfer_registrar_domains_path(domain_name: params[:domain_name]),
+        <%= link_to(t(:transfer), new_registrar_domain_transfer_path(domain_name: params[:domain_name]),
                     class: 'btn btn-default') %>
     <% end %>
 <% end %>

config/locales/registrar/domain_transfers.en.yml

@@ -0,0 +1,8 @@
+en:
+  registrar:
+    domain_transfers:
+      new:
+        header: Domain transfer
+
+      create:
+        header: Domain transfer

config/locales/registrar/domains.en.yml

@@ -12,12 +12,6 @@ en:
           registrant_code: Registrant code
           expire_time: Date of expiry
 
-      transfer_index:
-        header: Domain transfer
-
-      transfer:
-        header: Domain transfer
-
       search_form:
         download_btn: Download as CSV
         reset_btn: Reset

config/routes.rb

@@ -54,7 +54,6 @@ Rails.application.routes.draw do
         post 'update', as: 'update'
         post 'destroy', as: 'destroy'
         get 'renew'
-        match 'transfer', via: [:post, :get]
         get 'edit'
         get 'info'
         get 'check'
@@ -62,6 +61,7 @@ Rails.application.routes.draw do
         get 'search_contacts'
       end
     end
+    resources :domain_transfers, only: %i[new create]
 
     resources :contacts, constraints: {:id => /[^\/]+(?=#{ ActionController::Renderers::RENDERERS.map{|e| "\\.#{e}\\z"}.join("|") })|[^\/]+/} do
       member do

test/integration/registrar/domains_test.rb

@@ -29,4 +29,10 @@ class RegistrarDomainsTest < ActionDispatch::IntegrationTest
 
     assert_text 'Transfer requested at: 2010-07-05 10:30:00'
   end
+
+  def test_prefills_domain_transfer_form
+    visit info_registrar_domains_url(domain_name: 'airport.test')
+    click_link 'Transfer'
+    assert_field 'domain_name', with: 'airport.test'
+  end
 end