Merge pull request #2257 from internetee/2246-improve-email-validation-on-contact-create-and-update

added ability to validate invalid mx email by a and aaaa records
This commit is contained in:
Timo Võhmar 2021-12-29 20:42:04 +02:00 committed by GitHub
commit acc2818941
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 95 additions and 27 deletions

View file

@ -1,6 +1,6 @@
require 'test_helper'
class DoRequestTest < ActiveSupport::TestCase
class EmailCheckTest < ActiveSupport::TestCase
setup do
WebMock.disable_net_connect!
@ -16,7 +16,7 @@ class DoRequestTest < ActiveSupport::TestCase
)
Spy.on_instance_method(Actions::EmailCheck, :check_email).and_return(trumail_results)
Spy.on_instance_method(Actions::EmailCheck, :check_for_records_value).and_return([true])
Spy.on_instance_method(Actions::AAndAaaaEmailValidation, :call).and_return([true])
action = Actions::EmailCheck.new(email: @contact.email,
validation_eventable: @contact,
@ -35,7 +35,7 @@ class DoRequestTest < ActiveSupport::TestCase
)
Spy.on_instance_method(Actions::EmailCheck, :check_email).and_return(trumail_results)
Spy.on_instance_method(Actions::EmailCheck, :check_for_records_value).and_return([])
Spy.on_instance_method(Actions::AAndAaaaEmailValidation, :call).and_return([])
action = Actions::EmailCheck.new(email: @contact.email,
validation_eventable: @contact,
@ -54,7 +54,7 @@ class DoRequestTest < ActiveSupport::TestCase
)
Spy.on_instance_method(Actions::EmailCheck, :check_email).and_return(trumail_results)
Spy.on_instance_method(Actions::EmailCheck, :check_for_records_value).and_return([])
Spy.on_instance_method(Actions::AAndAaaaEmailValidation, :call).and_return([])
action = Actions::EmailCheck.new(email: @contact.email,
validation_eventable: @contact,
@ -82,7 +82,7 @@ class DoRequestTest < ActiveSupport::TestCase
)
Spy.on_instance_method(Actions::EmailCheck, :check_email).and_return(trumail_results)
Spy.on_instance_method(Actions::EmailCheck, :check_for_records_value).and_return([true])
Spy.on_instance_method(Actions::AAndAaaaEmailValidation, :call).and_return([true])
action = Actions::EmailCheck.new(email: @contact.email,
validation_eventable: @contact,