Merge pull request #2369 from internetee/refactor-check-force-delete

Add validation event check force delete to a job
This commit is contained in:
Timo Võhmar 2022-05-17 13:48:25 +03:00 committed by GitHub
commit ac46637b33
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 221 additions and 141 deletions

View file

@ -1,6 +1,8 @@
require 'test_helper'
class ForceDeleteTest < ActionMailer::TestCase
include ActiveJob::TestHelper
setup do
@domain = domains(:shop)
Setting.redemption_grace_period = 30
@ -380,115 +382,121 @@ class ForceDeleteTest < ActionMailer::TestCase
assert notification.text.include? asserted_text
end
# def test_schedules_force_delete_invalid_contact
# @domain.update(valid_to: Time.zone.parse('2012-08-05'))
# assert_not @domain.force_delete_scheduled?
# travel_to Time.zone.parse('2010-07-05')
# email = '`@internet.ee'
# asserted_text = "Invalid email: #{email}"
def test_schedules_force_delete_invalid_contact
@domain.update(valid_to: Time.zone.parse('2012-08-05'))
assert_not @domain.force_delete_scheduled?
travel_to Time.zone.parse('2010-07-05')
email = '`@internet.ee'
asserted_text = "Invalid email: #{email}"
# Truemail.configure.default_validation_type = :regex
Truemail.configure.default_validation_type = :regex
# contact = @domain.admin_contacts.first
# contact.update_attribute(:email, email)
contact = @domain.admin_contacts.first
contact.update_attribute(:email, email)
# ValidationEvent::VALID_EVENTS_COUNT_THRESHOLD.times do
# contact.verify_email
# end
ValidationEvent::VALID_EVENTS_COUNT_THRESHOLD.times do
contact.verify_email
end
# @domain.reload
perform_check_force_delete_job(contact.id)
@domain.reload
# assert @domain.force_delete_scheduled?
# assert_equal Date.parse('2010-09-19'), @domain.force_delete_date.to_date
# assert_equal Date.parse('2010-08-05'), @domain.force_delete_start.to_date
# assert_equal @domain.status_notes[DomainStatus::FORCE_DELETE], email
# notification = @domain.registrar.notifications.last
# assert notification.text.include? asserted_text
# end
assert @domain.force_delete_scheduled?
assert_equal Date.parse('2010-09-19'), @domain.force_delete_date.to_date
assert_equal Date.parse('2010-08-05'), @domain.force_delete_start.to_date
assert_equal @domain.status_notes[DomainStatus::FORCE_DELETE], email
notification = @domain.registrar.notifications.last
assert notification.text.include? asserted_text
end
# def test_add_invalid_email_to_domain_status_notes
# domain = domains(:airport)
# domain.update(valid_to: Time.zone.parse('2012-08-05'),
# statuses: %w[serverForceDelete serverRenewProhibited serverTransferProhibited],
# force_delete_data: { 'template_name': 'invalid_email', 'force_delete_type': 'soft' },
# status_notes: { "serverForceDelete": '`@internet2.ee' })
def test_add_invalid_email_to_domain_status_notes
domain = domains(:airport)
domain.update(valid_to: Time.zone.parse('2012-08-05'),
statuses: %w[serverForceDelete serverRenewProhibited serverTransferProhibited],
force_delete_data: { 'template_name': 'invalid_email', 'force_delete_type': 'soft' },
status_notes: { "serverForceDelete": '`@internet2.ee' })
# travel_to Time.zone.parse('2010-07-05')
# email = '`@internet.ee'
# invalid_emails = '`@internet2.ee `@internet.ee'
# asserted_text = "Invalid email: #{invalid_emails}"
travel_to Time.zone.parse('2010-07-05')
email = '`@internet.ee'
invalid_emails = '`@internet2.ee `@internet.ee'
asserted_text = "Invalid email: #{invalid_emails}"
# Truemail.configure.default_validation_type = :regex
Truemail.configure.default_validation_type = :regex
# contact_first = domain.admin_contacts.first
# contact_first.update_attribute(:email_history, 'john@inbox.test')
# contact_first.update_attribute(:email, email)
contact_first = domain.admin_contacts.first
contact_first.update_attribute(:email_history, 'john@inbox.test')
contact_first.update_attribute(:email, email)
# ValidationEvent::VALID_EVENTS_COUNT_THRESHOLD.times do
# contact_first.verify_email
# end
ValidationEvent::VALID_EVENTS_COUNT_THRESHOLD.times do
contact_first.verify_email
end
# domain.reload
perform_check_force_delete_job(contact_first.id)
domain.reload
# assert_equal domain.status_notes[DomainStatus::FORCE_DELETE], invalid_emails
# notification = domain.registrar.notifications.last
# assert_not notification.text.include? asserted_text
# end
assert_equal domain.status_notes[DomainStatus::FORCE_DELETE], invalid_emails
notification = domain.registrar.notifications.last
assert_not notification.text.include? asserted_text
end
# def test_remove_invalid_email_from_domain_status_notes
# domain = domains(:airport)
# domain.update(valid_to: Time.zone.parse('2012-08-05'),
# statuses: %w[serverForceDelete serverRenewProhibited serverTransferProhibited],
# force_delete_data: { 'template_name': 'invalid_email', 'force_delete_type': 'soft' },
# status_notes: { "serverForceDelete": '`@internet2.ee `@internet.ee' })
def test_remove_invalid_email_from_domain_status_notes
domain = domains(:airport)
domain.update(valid_to: Time.zone.parse('2012-08-05'),
statuses: %w[serverForceDelete serverRenewProhibited serverTransferProhibited],
force_delete_data: { 'template_name': 'invalid_email', 'force_delete_type': 'soft' },
status_notes: { "serverForceDelete": '`@internet2.ee `@internet.ee' })
# travel_to Time.zone.parse('2010-07-05')
# email = '`@internet2.ee'
# invalid_email = '`@internet.ee'
# asserted_text = "Invalid email: #{invalid_email}"
travel_to Time.zone.parse('2010-07-05')
email = '`@internet2.ee'
invalid_email = '`@internet.ee'
asserted_text = "Invalid email: #{invalid_email}"
# Truemail.configure.default_validation_type = :regex
Truemail.configure.default_validation_type = :regex
# contact_first = domain.admin_contacts.first
# contact_first.update_attribute(:email_history, email)
# contact_first.update_attribute(:email, 'john@inbox.test')
contact_first = domain.admin_contacts.first
contact_first.update_attribute(:email_history, email)
contact_first.update_attribute(:email, 'john@inbox.test')
# travel_to Time.zone.parse('2010-07-05 0:00:03')
# contact_first.verify_email
# domain.reload
travel_to Time.zone.parse('2010-07-05 0:00:03')
contact_first.verify_email
# assert_equal domain.status_notes[DomainStatus::FORCE_DELETE], invalid_email
# notification = domain.registrar.notifications.last
# assert notification.text.include? asserted_text
# end
perform_check_force_delete_job(contact_first.id)
domain.reload
# def test_domain_should_have_several_bounced_emails
# @domain.update(valid_to: Time.zone.parse('2012-08-05'))
# assert_not @domain.force_delete_scheduled?
# travel_to Time.zone.parse('2010-07-05')
# email_one = '`@internet.ee'
# email_two = '@@internet.ee'
assert_equal domain.status_notes[DomainStatus::FORCE_DELETE], invalid_email
notification = domain.registrar.notifications.last
assert notification.text.include? asserted_text
end
# contact_one = @domain.admin_contacts.first
# contact_one.update_attribute(:email, email_one)
# contact_one.verify_email
def test_domain_should_have_several_bounced_emails
@domain.update(valid_to: Time.zone.parse('2012-08-05'))
assert_not @domain.force_delete_scheduled?
travel_to Time.zone.parse('2010-07-05')
email_one = '`@internet.ee'
email_two = '@@internet.ee'
# assert contact_one.need_to_start_force_delete?
contact_one = @domain.admin_contacts.first
contact_one.update_attribute(:email, email_one)
contact_one.verify_email
perform_check_force_delete_job(contact_one.id)
# contact_two = @domain.admin_contacts.first
# contact_two.update_attribute(:email, email_two)
# contact_two.verify_email
assert contact_one.need_to_start_force_delete?
# assert contact_two.need_to_start_force_delete?
contact_two = @domain.admin_contacts.first
contact_two.update_attribute(:email, email_two)
contact_two.verify_email
perform_check_force_delete_job(contact_two.id)
# @domain.reload
assert contact_two.need_to_start_force_delete?
# assert @domain.force_delete_scheduled?
# assert_equal Date.parse('2010-09-19'), @domain.force_delete_date.to_date
# assert_equal Date.parse('2010-08-05'), @domain.force_delete_start.to_date
# assert @domain.status_notes[DomainStatus::FORCE_DELETE].include? email_one
# assert @domain.status_notes[DomainStatus::FORCE_DELETE].include? email_two
# end
@domain.reload
assert @domain.force_delete_scheduled?
assert_equal Date.parse('2010-09-19'), @domain.force_delete_date.to_date
assert_equal Date.parse('2010-08-05'), @domain.force_delete_start.to_date
assert @domain.status_notes[DomainStatus::FORCE_DELETE].include? email_one
assert @domain.status_notes[DomainStatus::FORCE_DELETE].include? email_two
end
def test_lifts_force_delete_after_bounce_changes
@domain.update(valid_to: Time.zone.parse('2012-08-05'))
@ -527,4 +535,12 @@ class ForceDeleteTest < ActionMailer::TestCase
@bounced_mail.diagnostic = 'smtp; 550 5.1.1 user unknown'
@bounced_mail.save!
end
private
def perform_check_force_delete_job(contact_id)
perform_enqueued_jobs do
CheckForceDeleteJob.perform_now([contact_id])
end
end
end