From f0473825e4472b11692e06375968d0d8b4d2d048 Mon Sep 17 00:00:00 2001 From: Maciej Szlosarczyk Date: Mon, 3 Sep 2018 19:08:14 +0300 Subject: [PATCH] Make whois JSON test order independent The test relied on nameservers being inserted in specific order. For whatever reason, that order can change, but it does not make the record invalid. [ns1.google.com, ns2.google.com] is semantically equal to [ns2.google.com, ns1.google.com] --- test/models/whois_record_test.rb | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/test/models/whois_record_test.rb b/test/models/whois_record_test.rb index 438ee9cc4..e86deafd9 100644 --- a/test/models/whois_record_test.rb +++ b/test/models/whois_record_test.rb @@ -22,7 +22,6 @@ class WhoisRecordTest < ActiveSupport::TestCase registrant_kind: 'priv', email: 'john@inbox.test', expire: '2010-07-05', - nameservers: ['ns1.bestnames.test', 'ns2.bestnames.test'], registrar_address: 'Main Street, New York, New York, 12345', dnssec_keys: [], } @@ -30,6 +29,10 @@ class WhoisRecordTest < ActiveSupport::TestCase expected_partial_hash.each do |key, value| assert_equal(value, @record.generated_json[key]) end + + ['ns1.bestnames.test', 'ns2.bestnames.test'].each do |item| + assert(@record.generated_json[:nameservers].include?(item)) + end end def test_generated_body_has_justified_disclaimer