From a8f1f885de7a21dd8c916df641a892bec15ee351 Mon Sep 17 00:00:00 2001
From: olegphenomenon <oleg.hasjanov@eestiinternet.ee>
Date: Mon, 24 Jan 2022 15:50:20 +0200
Subject: [PATCH] refactored base codeclimate warnings

---
 app/controllers/eis_billing/payment_status_controller.rb | 2 +-
 app/controllers/registrar/invoices_controller.rb         | 3 +--
 app/services/eis_billing/add_deposits.rb                 | 3 +--
 app/services/eis_billing/base.rb                         | 3 ---
 4 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/app/controllers/eis_billing/payment_status_controller.rb b/app/controllers/eis_billing/payment_status_controller.rb
index 5e9003199..c4df90c5c 100644
--- a/app/controllers/eis_billing/payment_status_controller.rb
+++ b/app/controllers/eis_billing/payment_status_controller.rb
@@ -21,7 +21,7 @@ module EisBilling
       registrar = invoice.buyer
       bank.create_activity(registrar, invoice)
 
-      render status: 200, json: { status: 'ok' }
+      render status: 200, json: { status: :ok }
     end
 
     private
diff --git a/app/controllers/registrar/invoices_controller.rb b/app/controllers/registrar/invoices_controller.rb
index 933e98a2f..34f6c17ae 100644
--- a/app/controllers/registrar/invoices_controller.rb
+++ b/app/controllers/registrar/invoices_controller.rb
@@ -13,8 +13,7 @@ class Registrar
       end
     end
 
-    def show
-    end
+    def show; end
 
     def cancel
       @invoice.cancel
diff --git a/app/services/eis_billing/add_deposits.rb b/app/services/eis_billing/add_deposits.rb
index 91100c266..062a69519 100644
--- a/app/services/eis_billing/add_deposits.rb
+++ b/app/services/eis_billing/add_deposits.rb
@@ -34,8 +34,7 @@ module EisBilling
         'Accept' => TOKEN
       }
 
-      res = http.post(invoice_generator_url, json_obj.to_json, headers)
-      res
+      http.post(invoice_generator_url, json_obj.to_json, headers)
     end
 
     def invoice_generator_url
diff --git a/app/services/eis_billing/base.rb b/app/services/eis_billing/base.rb
index 72b738aa5..e4e13dca2 100644
--- a/app/services/eis_billing/base.rb
+++ b/app/services/eis_billing/base.rb
@@ -8,8 +8,5 @@ module EisBilling
     # => "PLEASE CREATE INVOICE"
     TOKEN = 'Bearer WA9UvDmzR9UcE5rLqpWravPQtdS8eDMAIynzGdSOTw==--9ZShwwij3qmLeuMJ--NE96w2PnfpfyIuuNzDJTGw=='.freeze
     BASE_URL = ENV['eis_billing_system_base_url']
-
-    protected
-
   end
 end