Fixes after review

This commit is contained in:
Sergei Tsoganov 2023-05-18 11:15:20 +03:00
parent 39fe0e3ffe
commit a49e9dd076
2 changed files with 8 additions and 9 deletions

View file

@ -21,22 +21,22 @@ module Actions
case value case value
when 'A' when 'A'
resolve_a_records(dns: dns, domain: email_domain) resolve_a_records(dns: dns, hostname: email_domain)
when 'AAAA' when 'AAAA'
resolve_aaaa_records(dns: dns, domain: email_domain) resolve_aaaa_records(dns: dns, hostname: email_domain)
else else
[] []
end end
end end
end end
def resolve_a_records(dns:, domain:) def resolve_a_records(dns:, hostname:)
resources = dns.getresources(domain, Resolv::DNS::Resource::IN::A) resources = dns.getresources(hostname, Resolv::DNS::Resource::IN::A)
resources.map(&:address) resources.map(&:address)
end end
def resolve_aaaa_records(dns:, domain:) def resolve_aaaa_records(dns:, hostname:)
resources = dns.getresources(domain, Resolv::DNS::Resource::IN::AAAA) resources = dns.getresources(hostname, Resolv::DNS::Resource::IN::AAAA)
resources.map(&:address) resources.map(&:address)
end end
end end

View file

@ -24,10 +24,9 @@ module Actions
end end
def calculate_check_level def calculate_check_level
check_level_sym = check_level.to_sym return :mx if Rails.env.test? && check_level == 'smtp'
return :mx if Rails.env.test? && check_level_sym == :smtp
check_level_sym check_level.to_sym
end end
def filter_old_failed_records(result, contact) def filter_old_failed_records(result, contact)