zydronium/internetee-registry
1
0
Fork 0
mirror of https://github.com/internetee/registry.git synced 2025-06-06 12:47:29 +02:00
Code Issues Projects Releases Packages Wiki Activity

Fix error if domain name was nil.

Browse source 
Used for some old history entries
Closes #1663
This commit is contained in:
Alex Sherman 2020-08-27 13:04:43 +05:00
parent 76e4e32dc9
commit a0029d0a80
2 changed files with 9 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
app/models/domain.rb
View file

@ -260,8 +260,8 @@ class Domain < ApplicationRecord
end end
def name=(value) def name=(value)
value.strip! value&.strip!
value.downcase! value&.downcase!
self[:name] = SimpleIDN.to_unicode(value) self[:name] = SimpleIDN.to_unicode(value)
self[:name_puny] = SimpleIDN.to_ascii(value) self[:name_puny] = SimpleIDN.to_ascii(value)
self[:name_dirty] = value self[:name_dirty] = value

7
test/models/domain_test.rb
View file

@ -270,6 +270,13 @@ class DomainTest < ActiveSupport::TestCase
assert_equal 'shop.test', domain.domain_name.to_s assert_equal 'shop.test', domain.domain_name.to_s
end end
def test_nil_name_doesnt_throw_error
domain = Domain.new(name: 'shop.test')
assert_nothing_raised do
domain.name = nil
end
end
def test_returns_registrant_user_domains_by_registrant def test_returns_registrant_user_domains_by_registrant
registrant = contacts(:john).becomes(Registrant) registrant = contacts(:john).becomes(Registrant)
assert_equal registrant, @domain.registrant assert_equal registrant, @domain.registrant