zydronium/internetee-registry
1
0
Fork 0
mirror of https://github.com/internetee/registry.git synced 2025-07-31 23:16:23 +02:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #2763 from internetee/missing-reason-in-notification

Browse source 
Fix ProcessClientHold notification and added tests
This commit is contained in:
Timo Võhmar 2025-03-07 16:05:37 +02:00 • committed by GitHub
commit 9db844a12c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 188 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/interactions/domains/client_hold/process_client_hold.rb
View file

@ -33,7 +33,7 @@ module Domains
end
def notify_client_hold
domain.registrar.notifications.create!(text: I18n.t('force_delete_set_on_domain',
domain.registrar.notifications.create!(text: I18n.t('hold_client_on_domain',
domain_name: domain.name,
outzone_date: domain.outzone_date,
purge_date: domain.purge_date))

1
config/locales/en.yml
View file

@ -653,6 +653,7 @@ en:
created_at_until: 'Created at until'
is_registrant: 'Is registrant'
force_delete_set_on_domain: 'Force delete set on domain %{domain_name}. Outzone date: %{outzone_date}. Purge date: %{purge_date}'
hold_client_on_domain: 'clientHold status set on domain %{domain_name}. Outzone date: %{outzone_date}. Purge date: %{purge_date}'
force_delete_auto_email: 'Force delete set on domain %{domain_name}. Outzone date: %{outzone_date}. Purge date: %{purge_date}. Invalid email: %{email}'
grace_period_started_domain: 'For domain %{domain_name} started 45-days redemption grace period, ForceDelete will be in effect from %{date}'
force_delete_cancelled: 'Force delete is cancelled on domain %{domain_name}'

186
test/interactions/domains/client_hold/process_client_hold_test.rb Normal file
View file

@ -0,0 +1,186 @@
require 'test_helper'
module Domains
module ClientHold
class ProcessClientHoldTest < ActiveSupport::TestCase
setup do
@domain = domains(:shop)
@registrar = registrars(:bestnames)
@domain.update!(registrar: @registrar)
@domain.force_delete_data = { 'force_delete_type' => 'soft' }
@domain.statuses = []
@domain.force_delete_start = Time.zone.now - 1.day
@domain.contact_notification_sent_date = nil
@domain.valid_to = Time.zone.now + 30.days
@domain.save(validate: false)
end
def test_notify_on_grace_period_when_should_notify
@domain.update!(
force_delete_start: Time.zone.now - 1.day,
contact_notification_sent_date: nil,
force_delete_data: { 'force_delete_type' => 'soft' }
)
Domain.stub_any_instance(:force_delete_scheduled?, true) do
assert_difference '@domain.registrar.notifications.count', 1 do
ProcessClientHold.run(domain: @domain)
end
@domain.reload
assert_not_nil @domain.contact_notification_sent_date
end
end
def test_execute_adds_client_hold_status_when_domain_is_holdable
@domain.update!(
force_delete_start: Time.zone.now - (Setting.expire_warning_period.days + 2.days),
force_delete_data: { 'force_delete_type' => 'soft' }
)
Domain.stub_any_instance(:force_delete_scheduled?, true) do
assert_not @domain.statuses.include?(DomainStatus::CLIENT_HOLD)
ProcessClientHold.run(domain: @domain)
@domain.reload
assert @domain.statuses.include?(DomainStatus::CLIENT_HOLD)
assert_equal ProcessClientHold::CLIENT_HOLD_SET_NOTE, @domain.force_delete_data['client_hold_mandatory']
end
end
def test_execute_does_not_add_client_hold_when_already_set
@domain.update!(
force_delete_start: Time.zone.now - (Setting.expire_warning_period.days + 2.days),
force_delete_data: {
'force_delete_type' => 'soft',
'client_hold_mandatory' => ProcessClientHold::CLIENT_HOLD_SET_NOTE
}
)
@domain.statuses << DomainStatus::CLIENT_HOLD
@domain.save(validate: false)
Domain.stub_any_instance(:force_delete_scheduled?, true) do
assert_no_difference '@domain.registrar.notifications.count' do
ProcessClientHold.run(domain: @domain)
end
end
end
def test_notify_client_hold_creates_notification
process = ProcessClientHold.new(domain: @domain)
assert_difference '@domain.registrar.notifications.count', 1 do
process.notify_client_hold
end
notification = @domain.registrar.notifications.last
assert_includes notification.text, @domain.name
assert_includes notification.text, @domain.outzone_date.to_s if @domain.outzone_date
assert_includes notification.text, @domain.purge_date.to_s if @domain.purge_date
end
def test_send_mail_delivers_email
@domain.force_delete_data = {'force_delete_type' => 'soft'}
@domain.template_name = 'legal_person'
@domain.save!
mail_mock = OpenStruct.new(deliver_now: true)
DomainDeleteMailer.stub(:forced, mail_mock) do
Domain.stub_any_instance(:force_delete_scheduled?, true) do
assert_nothing_raised do
ProcessClientHold.new(domain: @domain).send_mail
end
end
end
end
def test_should_notify_on_soft_force_delete
@domain.update!(
force_delete_start: Time.zone.now - 1.day,
contact_notification_sent_date: nil,
force_delete_data: { 'force_delete_type' => 'soft' }
)
Domain.stub_any_instance(:force_delete_scheduled?, true) do
process = ProcessClientHold.new(domain: @domain)
assert process.should_notify_on_soft_force_delete?
@domain.update!(contact_notification_sent_date: Time.zone.today)
process = ProcessClientHold.new(domain: @domain)
assert_not process.should_notify_on_soft_force_delete?
end
Domain.stub_any_instance(:force_delete_scheduled?, false) do
@domain.update!(force_delete_start: nil, contact_notification_sent_date: nil)
process = ProcessClientHold.new(domain: @domain)
assert_not process.should_notify_on_soft_force_delete?
end
Domain.stub_any_instance(:force_delete_scheduled?, true) do
@domain.update!(
force_delete_start: Time.zone.now - 1.day,
force_delete_data: { 'force_delete_type' => 'hard' }
)
process = ProcessClientHold.new(domain: @domain)
assert_not process.should_notify_on_soft_force_delete?
end
end
def test_client_holdable
@domain.update!(
force_delete_start: Time.zone.now - (Setting.expire_warning_period.days + 2.days),
force_delete_data: { 'force_delete_type' => 'soft' }
)
Domain.stub_any_instance(:force_delete_scheduled?, true) do
process = ProcessClientHold.new(domain: @domain)
assert process.client_holdable?
@domain.statuses << DomainStatus::CLIENT_HOLD
@domain.save(validate: false)
process = ProcessClientHold.new(domain: @domain)
assert_not process.client_holdable?
end
Domain.stub_any_instance(:force_delete_scheduled?, false) do
@domain.statuses = []
@domain.save(validate: false)
process = ProcessClientHold.new(domain: @domain)
assert_not process.client_holdable?
end
end
def test_force_delete_lte_today
@domain.update!(force_delete_start: Time.zone.now - (Setting.expire_warning_period.days + 2.days))
process = ProcessClientHold.new(domain: @domain)
assert process.force_delete_lte_today
@domain.update!(force_delete_start: Time.zone.now)
process = ProcessClientHold.new(domain: @domain)
assert_not process.force_delete_lte_today
end
def test_force_delete_lte_valid_date
@domain.update!(
force_delete_start: Time.zone.now - (Setting.expire_warning_period.days + 2.days),
valid_to: Time.zone.now + 60.days
)
process = ProcessClientHold.new(domain: @domain)
assert process.force_delete_lte_valid_date
@domain.update!(
force_delete_start: Time.zone.now,
valid_to: Time.zone.now + 5.days
)
process = ProcessClientHold.new(domain: @domain)
assert_not process.force_delete_lte_valid_date
end
end
end
end