From 9cf5137c75c27fe216a16a6855d85b943d3d4601 Mon Sep 17 00:00:00 2001 From: Artur Beljajev Date: Wed, 2 Jan 2019 14:54:07 +0200 Subject: [PATCH 1/2] Add tests --- test/fixtures/billing/prices.yml | 9 +- test/fixtures/blocked_domains.yml | 2 + test/fixtures/dns/zones.yml | 4 +- .../integration/epp/domain/check/base_test.rb | 135 ++++++++++++++++++ .../epp/domain/create/base_test.rb | 36 +++++ test/integration/epp/domain/info/base_test.rb | 38 +++++ 6 files changed, 218 insertions(+), 6 deletions(-) create mode 100644 test/fixtures/blocked_domains.yml create mode 100644 test/integration/epp/domain/check/base_test.rb create mode 100644 test/integration/epp/domain/create/base_test.rb create mode 100644 test/integration/epp/domain/info/base_test.rb diff --git a/test/fixtures/billing/prices.yml b/test/fixtures/billing/prices.yml index 17e34d3f2..2237a72b4 100644 --- a/test/fixtures/billing/prices.yml +++ b/test/fixtures/billing/prices.yml @@ -4,7 +4,7 @@ create_one_month: operation_category: create valid_from: 2010-07-05 valid_to: 2010-07-05 - zone: test + zone: one renew_one_month: duration: 1 month @@ -12,15 +12,14 @@ renew_one_month: operation_category: renew valid_from: 2010-07-05 valid_to: 2010-07-05 - zone: test + zone: one create_one_year: duration: 1 year price_cents: 1000 operation_category: create valid_from: 2010-07-05 - valid_to: 2010-07-05 - zone: test + zone: one renew_one_year: duration: 1 year @@ -28,4 +27,4 @@ renew_one_year: operation_category: renew valid_from: 2010-07-05 valid_to: 2010-07-05 - zone: test + zone: one diff --git a/test/fixtures/blocked_domains.yml b/test/fixtures/blocked_domains.yml new file mode 100644 index 000000000..4bf0d0299 --- /dev/null +++ b/test/fixtures/blocked_domains.yml @@ -0,0 +1,2 @@ +one: + name: blocked.test diff --git a/test/fixtures/dns/zones.yml b/test/fixtures/dns/zones.yml index 40a8a289e..b826c9ef4 100644 --- a/test/fixtures/dns/zones.yml +++ b/test/fixtures/dns/zones.yml @@ -1,2 +1,4 @@ -test: +# https://github.com/rails/rails/issues/9516 requires this file to be under "dns" folder + +one: origin: test diff --git a/test/integration/epp/domain/check/base_test.rb b/test/integration/epp/domain/check/base_test.rb new file mode 100644 index 000000000..5d98b60ff --- /dev/null +++ b/test/integration/epp/domain/check/base_test.rb @@ -0,0 +1,135 @@ +require 'test_helper' + +class EppDomainCheckBaseTest < ApplicationIntegrationTest + def test_returns_valid_response + request_xml = <<-XML + + + + + + some.test + + + + + XML + + post '/epp/command/check', { frame: request_xml }, 'HTTP_COOKIE' => 'session=api_bestnames' + + response_xml = Nokogiri::XML(response.body) + assert_equal '1000', response_xml.at_css('result')[:code] + assert_equal 1, response_xml.css('result').size + assert_equal 'some.test', response_xml.at_xpath('//domain:name', 'domain' => 'https://epp.tld.ee/schema/domain-eis-1.0.xsd').text + end + + def test_domain_is_available_when_not_registered_blocked_nor_reserved + request_xml = <<-XML + + + + + + available.test + + + + + XML + + post '/epp/command/check', { frame: request_xml }, 'HTTP_COOKIE' => 'session=api_bestnames' + + response_xml = Nokogiri::XML(response.body) + assert_equal '1', response_xml.at_xpath('//domain:name', 'domain' => 'https://epp.tld.ee/schema/domain-eis-1.0.xsd')['avail'] + assert_nil response_xml.at_xpath('//domain:reason', 'domain' => 'https://epp.tld.ee/schema/domain-eis-1.0.xsd') + end + + def test_domain_is_unavailable_when_format_is_invalid + request_xml = <<-XML + + + + + + invalid + + + + + XML + + post '/epp/command/check', { frame: request_xml }, 'HTTP_COOKIE' => 'session=api_bestnames' + + response_xml = Nokogiri::XML(response.body) + assert_equal '0', response_xml.at_xpath('//domain:name', 'domain' => 'https://epp.tld.ee/schema/domain-eis-1.0.xsd')['avail'] + assert_equal 'invalid format', response_xml.at_xpath('//domain:reason', 'domain' => 'https://epp.tld.ee/schema/domain-eis-1.0.xsd').text + end + + def test_domain_is_unavailable_when_registered + assert_equal 'shop.test', domains(:shop).name + + request_xml = <<-XML + + + + + + shop.test + + + + + XML + + post '/epp/command/check', { frame: request_xml }, 'HTTP_COOKIE' => 'session=api_bestnames' + + response_xml = Nokogiri::XML(response.body) + assert_equal '0', response_xml.at_xpath('//domain:name', 'domain' => 'https://epp.tld.ee/schema/domain-eis-1.0.xsd')['avail'] + assert_equal 'in use', response_xml.at_xpath('//domain:reason', 'domain' => 'https://epp.tld.ee/schema/domain-eis-1.0.xsd').text + end + + def test_domain_is_unavailable_when_reserved + assert_equal 'reserved.test', reserved_domains(:one).name + + request_xml = <<-XML + + + + + + reserved.test + + + + + XML + + post '/epp/command/check', { frame: request_xml }, 'HTTP_COOKIE' => 'session=api_bestnames' + + response_xml = Nokogiri::XML(response.body) + assert_equal '0', response_xml.at_xpath('//domain:name', 'domain' => 'https://epp.tld.ee/schema/domain-eis-1.0.xsd')['avail'] + assert_equal 'Domain name is reserved', response_xml.at_xpath('//domain:reason', 'domain' => 'https://epp.tld.ee/schema/domain-eis-1.0.xsd').text + end + + def test_multiple_domains + request_xml = <<-XML + + + + + + one.test + two.test + three.test + + + + + XML + + post '/epp/command/check', { frame: request_xml }, 'HTTP_COOKIE' => 'session=api_bestnames' + + response_xml = Nokogiri::XML(response.body) + assert_equal 3, response_xml.xpath('//domain:cd', 'domain' => 'https://epp.tld.ee/schema/domain-eis-1.0.xsd').size + end +end diff --git a/test/integration/epp/domain/create/base_test.rb b/test/integration/epp/domain/create/base_test.rb new file mode 100644 index 000000000..ff3a856df --- /dev/null +++ b/test/integration/epp/domain/create/base_test.rb @@ -0,0 +1,36 @@ +require 'test_helper' + +class EppDomainCreateBaseTest < ApplicationIntegrationTest + def test_domain_can_be_registered_with_required_attributes_only + request_xml = <<-XML + + + + + + new.test + john-001 + + + + + #{'test' * 2000} + + + + + XML + + assert_difference 'Domain.count' do + post '/epp/command/create', { frame: request_xml }, 'HTTP_COOKIE' => 'session=api_bestnames' + end + + domain = Domain.last + assert_equal 'new.test', domain.name + assert_equal contacts(:john).becomes(Registrant), domain.registrant + + response_xml = Nokogiri::XML(response.body) + assert_equal '1000', response_xml.at_css('result')[:code] + assert_equal 1, Nokogiri::XML(response.body).css('result').size + end +end diff --git a/test/integration/epp/domain/info/base_test.rb b/test/integration/epp/domain/info/base_test.rb new file mode 100644 index 000000000..d94fe8dfd --- /dev/null +++ b/test/integration/epp/domain/info/base_test.rb @@ -0,0 +1,38 @@ +require 'test_helper' + +class EppDomainInfoBaseTest < ApplicationIntegrationTest + def test_returns_valid_response + assert_equal 'john-001', contacts(:john).code + domains(:shop).update_columns(statuses: [DomainStatus::OK], + created_at: Time.zone.parse('2010-07-05'), + updated_at: Time.zone.parse('2010-07-06'), + valid_to: Time.zone.parse('2010-07-07'), + transfer_code: 'transfer-001') + + request_xml = <<-XML + + + + + + shop.test + + + + + XML + + post '/epp/command/info', { frame: request_xml }, 'HTTP_COOKIE' => 'session=api_bestnames' + + response_xml = Nokogiri::XML(response.body) + assert_equal '1000', response_xml.at_css('result')[:code] + assert_equal 1, response_xml.css('result').size + assert_equal 'shop.test', response_xml.at_xpath('//domain:name', 'domain' => 'https://epp.tld.ee/schema/domain-eis-1.0.xsd').text + assert_equal 'ok', response_xml.at_xpath('//domain:status', 'domain' => 'https://epp.tld.ee/schema/domain-eis-1.0.xsd')['s'] + assert_equal 'john-001', response_xml.at_xpath('//domain:registrant', 'domain' => 'https://epp.tld.ee/schema/domain-eis-1.0.xsd').text + assert_equal '2010-07-05T00:00:00+03:00', response_xml.at_xpath('//domain:crDate', 'domain' => 'https://epp.tld.ee/schema/domain-eis-1.0.xsd').text + assert_equal '2010-07-06T00:00:00+03:00', response_xml.at_xpath('//domain:upDate', 'domain' => 'https://epp.tld.ee/schema/domain-eis-1.0.xsd').text + assert_equal '2010-07-07T00:00:00+03:00', response_xml.at_xpath('//domain:exDate', 'domain' => 'https://epp.tld.ee/schema/domain-eis-1.0.xsd').text + assert_equal 'transfer-001', response_xml.at_xpath('//domain:authInfo/domain:pw', 'domain' => 'https://epp.tld.ee/schema/domain-eis-1.0.xsd').text + end +end From 73bd83ebaeb7e59111bc272861f820f1095676fb Mon Sep 17 00:00:00 2001 From: Artur Beljajev Date: Mon, 14 Jan 2019 15:06:11 +0200 Subject: [PATCH 2/2] Add tests --- test/integration/epp/domain/info/base_test.rb | 77 ++++++++++++++++++- 1 file changed, 74 insertions(+), 3 deletions(-) diff --git a/test/integration/epp/domain/info/base_test.rb b/test/integration/epp/domain/info/base_test.rb index d94fe8dfd..a112ed840 100644 --- a/test/integration/epp/domain/info/base_test.rb +++ b/test/integration/epp/domain/info/base_test.rb @@ -6,8 +6,7 @@ class EppDomainInfoBaseTest < ApplicationIntegrationTest domains(:shop).update_columns(statuses: [DomainStatus::OK], created_at: Time.zone.parse('2010-07-05'), updated_at: Time.zone.parse('2010-07-06'), - valid_to: Time.zone.parse('2010-07-07'), - transfer_code: 'transfer-001') + valid_to: Time.zone.parse('2010-07-07')) request_xml = <<-XML @@ -33,6 +32,78 @@ class EppDomainInfoBaseTest < ApplicationIntegrationTest assert_equal '2010-07-05T00:00:00+03:00', response_xml.at_xpath('//domain:crDate', 'domain' => 'https://epp.tld.ee/schema/domain-eis-1.0.xsd').text assert_equal '2010-07-06T00:00:00+03:00', response_xml.at_xpath('//domain:upDate', 'domain' => 'https://epp.tld.ee/schema/domain-eis-1.0.xsd').text assert_equal '2010-07-07T00:00:00+03:00', response_xml.at_xpath('//domain:exDate', 'domain' => 'https://epp.tld.ee/schema/domain-eis-1.0.xsd').text - assert_equal 'transfer-001', response_xml.at_xpath('//domain:authInfo/domain:pw', 'domain' => 'https://epp.tld.ee/schema/domain-eis-1.0.xsd').text + end + + def test_reveals_transfer_code_when_domain_is_owned_by_current_user + assert_equal '65078d5', domains(:shop).transfer_code + + request_xml = <<-XML + + + + + + shop.test + + + + + XML + + post '/epp/command/info', { frame: request_xml }, 'HTTP_COOKIE' => 'session=api_bestnames' + + response_xml = Nokogiri::XML(response.body) + assert_equal '65078d5', response_xml.at_xpath('//domain:authInfo/domain:pw', 'domain' => 'https://epp.tld.ee/schema/domain-eis-1.0.xsd').text + end + + # Transfer code is the only info we conceal from other registrars, hence a bit oddly-looking + # test name + def test_reveals_transfer_code_when_domain_is_not_owned_by_current_user_and_transfer_code_is_provided + assert_equal '65078d5', domains(:shop).transfer_code + + request_xml = <<-XML + + + + + + shop.test + + 65078d5 + + + + + + XML + + post '/epp/command/info', { frame: request_xml }, 'HTTP_COOKIE' => 'session=api_goodnames' + + response_xml = Nokogiri::XML(response.body) + assert_equal '65078d5', response_xml.at_xpath('//domain:authInfo/domain:pw', 'domain' => 'https://epp.tld.ee/schema/domain-eis-1.0.xsd').text + end + + def test_conceals_transfer_code_when_domain_is_not_owned_by_current_user + request_xml = <<-XML + + + + + + shop.test + + + + + + + + XML + + post '/epp/command/info', { frame: request_xml }, 'HTTP_COOKIE' => 'session=api_goodnames' + + response_xml = Nokogiri::XML(response.body) + assert_nil response_xml.at_xpath('//domain:authInfo/domain:pw', + 'domain' => 'https://epp.tld.ee/schema/domain-eis-1.0.xsd') end end