Fic some CC issues

This commit is contained in:
Karl Erik Õunapuu 2020-10-14 15:53:54 +03:00
parent ee199f9318
commit 9b8d74fe30
No known key found for this signature in database
GPG key ID: C9DD647298A34764

View file

@ -27,26 +27,34 @@ module Repp
def transfer def transfer
@errors ||= [] @errors ||= []
successful = [] @successful = []
params[:data][:domain_transfers].each do |transfer| params[:data][:domain_transfers].each do |transfer|
domain = transferable_domain(transfer[:domain_name], transfer[:transfer_code]) initiate_transfer(transfer)
next unless domain
DomainTransfer.request(domain, current_user.registrar)
successful << { type: 'domain_transfer', attributes: { domain_name: domain.name } }
end end
render_success(data: { errors: @errors }) and return if @errors.any? if @errors.any
render_success(data: { errors: @errors })
else
render_success(data: successful)
end
end
render_success(data: successful) def initiate_transfer(transfer)
domain = transferable_domain(transfer[:domain_name], transfer[:transfer_code])
next unless domain
DomainTransfer.request(domain, current_user.registrar)
@successful << { type: 'domain_transfer', attributes: { domain_name: domain.name } }
end end
def transferable_domain(domain_name, transfer_code) def transferable_domain(domain_name, transfer_code)
domain = Domain.find_by(name: domain_name) domain = Domain.find_by(name: domain_name)
valid_transfer_code = domain.transfer_code == transfer_code valid_transfer_code = domain.transfer_code == transfer_code
# rubocop:disable Style/AndOr
add_error("#{domain_name} does not exist") and return unless domain add_error("#{domain_name} does not exist") and return unless domain
add_error("#{domain_name} transfer code is wrong") and return unless valid_transfer_code add_error("#{domain_name} transfer code is wrong") and return unless valid_transfer_code
# rubocop:enable Style/AndOr
domain domain
end end