Refactored contact with ability

app/models/contact.rb

@@ -1,6 +1,5 @@
 class Contact < ActiveRecord::Base
   include Versions # version/contact_version.rb
-  include EppErrors
 
   has_one :address, dependent: :destroy
   has_one :disclosure, class_name: 'ContactDisclosure', dependent: :destroy
@@ -19,25 +18,20 @@ class Contact < ActiveRecord::Base
   validates :phone, format: /\+[0-9]{1,3}\.[0-9]{1,14}?/
   validates :email, format: /@/
   validates :ident, format: /\d{4}-\d{2}-\d{2}/, if: proc { |c| c.ident_type == 'birthday' }
-
   validate :ident_must_be_valid
-
   validates :code, uniqueness: { message: :epp_id_taken }
 
-  delegate :city, to: :address # , prefix: true
-  delegate :street, to: :address # , prefix: true
-  delegate :zip, to: :address # , prefix: true
+  delegate :street,       to: :address
+  delegate :city,         to: :address
+  delegate :zip,          to: :address
+  delegate :state,        to: :address
+  delegate :country_code, to: :address
+  delegate :country,      to: :address
 
-  # callbacks
-  # TODO: remove old
-  # after_commit :domains_snapshot
-  # after_update :domains_snapshot
-  # after_destroy :domains_snapshot
   before_create :generate_code
   before_create :generate_auth_info
   after_create :ensure_disclosure
 
-  # scopes
   scope :current_registrars, ->(id) { where(registrar_id: id) }
 
   IDENT_TYPE_ICO = 'ico'
@@ -54,6 +48,32 @@ class Contact < ActiveRecord::Base
   CONTACT_TYPE_ADMIN = 'admin'
   CONTACT_TYPES = [CONTACT_TYPE_TECH, CONTACT_TYPE_ADMIN]
 
+  class << self
+    def search_by_query(query)
+      res = search(code_cont: query).result
+      res.reduce([]) { |o, v| o << { id: v[:id], display_key: "#{v.name} (#{v.code})" } }
+    end
+
+    def check_availability(codes)
+      codes = [codes] if codes.is_a?(String)
+
+      res = []
+      codes.each do |x|
+        if Contact.find_by(code: x)
+          res << { code: x, avail: 0, reason: 'in use' }
+        else
+          res << { code: x, avail: 1 }
+        end
+      end
+
+      res
+    end
+  end
+
+  def to_s
+    name
+  end
+
   def ident_must_be_valid
     # TODO: Ident can also be passport number or company registry code.
     # so have to make changes to validations (and doc/schema) accordingly
@@ -66,15 +86,6 @@ class Contact < ActiveRecord::Base
     create_disclosure! unless disclosure
   end
 
-  # TODO: remove old
-  # def domains_snapshot
-    # (domains + domains_owned).uniq.each do |domain|
-      # next unless domain.is_a?(Domain)
-      # # next if domain.versions.last == domain.create_snapshot
-      # domain.create_version # Method from paper_trail
-    # end
-  # end
-
   def juridical?
     ident_type == IDENT_TYPE_ICO
   end
@@ -83,18 +94,6 @@ class Contact < ActiveRecord::Base
     ident_type != IDENT_TYPE_ICO
   end
 
-  def cr_id
-    # created_by ? created_by.username : nil
-  end
-
-  def up_id
-    # updated_by ? updated_by.username : nil
-  end
-
-  def auth_info_matches(pw)
-    auth_info == pw
-  end
-
   # generate random id for contact
   def generate_code
     self.code = SecureRandom.hex(4)
@@ -114,6 +113,8 @@ class Contact < ActiveRecord::Base
     false
   end
 
+  # TODO: refactor, it should not allow to destroy with normal destroy, 
+  # no need separate method
   # should use only in transaction
   def destroy_and_clean
     if relations_with_domain?
@@ -122,76 +123,4 @@ class Contact < ActiveRecord::Base
     end
     destroy
   end
-
-  def epp_code_map # rubocop:disable Metrics/MethodLength
-    {
-      '2302' => [ # Object exists
-        [:code, :epp_id_taken]
-      ],
-      '2305' => [ # Association exists
-        [:domains, :exist]
-      ],
-      '2005' => [ # Value syntax error
-        [:phone, :invalid],
-        [:email, :invalid],
-        [:ident, :invalid]
-      ]
-    }
-  end
-
-  def to_s
-    name
-  end
-
-  # TODO: remove old
-  # for archiving
-  # def snapshot
-    # {
-      # name: name,
-      # phone: phone,
-      # code: code,
-      # ident: ident,
-      # email: email
-    # }
-  # end
-
-  class << self
-    # non-EPP
-
-    # EPP
-    def extract_attributes(ph, _type = :create)
-      ph[:postalInfo] = ph[:postalInfo].first if ph[:postalInfo].is_a?(Array)
-      contact_hash = {
-        phone: ph[:voice],
-        ident: ph[:ident],
-        ident_type: ph[:ident_type],
-        email: ph[:email],
-        fax: ph[:fax],
-        name: ph[:postalInfo].try(:[], :name),
-        org_name: ph[:postalInfo].try(:[], :org)
-      }
-      # contact_hash[:auth_info] = ph[:authInfo][:pw] if type == :create
-      contact_hash.delete_if { |_k, v| v.nil? }
-    end
-
-    def check_availability(codes)
-      codes = [codes] if codes.is_a?(String)
-
-      res = []
-      codes.each do |x|
-        if Contact.find_by(code: x)
-          res << { code: x, avail: 0, reason: 'in use' }
-        else
-          res << { code: x, avail: 1 }
-        end
-      end
-
-      res
-    end
-
-    def search_by_query(query)
-      res = search(code_cont: query).result
-      res.reduce([]) { |o, v| o << { id: v[:id], display_key: "#{v.name} (#{v.code})" } }
-    end
-  end
 end