From 960e4084e3225287a52bc5f1a504e1439b7925e3 Mon Sep 17 00:00:00 2001 From: Maciej Szlosarczyk Date: Thu, 14 May 2020 15:26:33 +0300 Subject: [PATCH] Properly match against class MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Turns out I was wrong 😅 --- app/models/retained_domains.rb | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/app/models/retained_domains.rb b/app/models/retained_domains.rb index 98fa9f5ff..e821adbc9 100644 --- a/app/models/retained_domains.rb +++ b/app/models/retained_domains.rb @@ -24,16 +24,9 @@ class RetainedDomains end def domain_to_json(domain) - # Smelly, but ActiveRecord objects are weird and do not respond - # to usual syntax: - # case a - # when Array then "foo" - # when Hash then "bar" - # else "baz" - # end - status = case domain.class.to_s - when 'ReservedDomain' then RESERVED - when 'BlockedDomain' then BLOCKED + status = case domain + when ReservedDomain then RESERVED + when BlockedDomain then BLOCKED end punycode = SimpleIDN.to_ascii(domain.name)