From b4b715f405843b2ee8de06b1fd245b29bb0ff442 Mon Sep 17 00:00:00 2001
From: Artur Beljajev
Date: Mon, 20 Feb 2017 13:00:45 +0200
Subject: [PATCH 1/8] Extract registrar controller translations in admin area
#279
---
.../admin/registrars_controller.rb | 8 ++++----
app/views/admin/registrars/_form.haml | 4 ++--
app/views/admin/registrars/index.haml | 2 +-
config/locales/admin/registrars.en.yml | 16 +++++++++++++++
config/locales/en.yml | 4 ----
spec/features/admin/registrars/create_spec.rb | 20 +++++++++++++++++++
spec/features/admin/registrars/edit_spec.rb | 18 +++++++++++++++++
7 files changed, 61 insertions(+), 11 deletions(-)
create mode 100644 spec/features/admin/registrars/create_spec.rb
create mode 100644 spec/features/admin/registrars/edit_spec.rb
diff --git a/app/controllers/admin/registrars_controller.rb b/app/controllers/admin/registrars_controller.rb
index 611687f9b..d29ce40d3 100644
--- a/app/controllers/admin/registrars_controller.rb
+++ b/app/controllers/admin/registrars_controller.rb
@@ -23,10 +23,10 @@ class Admin::RegistrarsController < AdminController
@registrar.accounts.create!(account_type: Account::CASH, currency: 'EUR')
end
- flash[:notice] = I18n.t('registrar_added')
+ flash[:notice] = t('.created')
redirect_to [:admin, @registrar]
rescue ActiveRecord::RecordInvalid
- flash.now[:alert] = I18n.t('failed_to_add_registrar')
+ flash.now[:alert] = t('.not_created')
render 'new'
end
end
@@ -35,10 +35,10 @@ class Admin::RegistrarsController < AdminController
def update
if @registrar.update(registrar_params)
- flash[:notice] = I18n.t('registrar_updated')
+ flash[:notice] = t('.updated')
redirect_to [:admin, @registrar]
else
- flash.now[:alert] = I18n.t('failed_to_update_registrar')
+ flash.now[:alert] = t('.not_updated')
render 'edit'
end
end
diff --git a/app/views/admin/registrars/_form.haml b/app/views/admin/registrars/_form.haml
index 48cfc8066..6f80abba6 100644
--- a/app/views/admin/registrars/_form.haml
+++ b/app/views/admin/registrars/_form.haml
@@ -75,7 +75,7 @@
.col-md-8
.panel.panel-default
.panel-heading.clearfix
- .pull-left= t(:misc)
+ .pull-left= t('.misc')
.panel-body
.form-group
.col-md-4.control-label
@@ -91,4 +91,4 @@
%hr
.row
.col-md-8.text-right
- = button_tag(t(:save), class: 'btn btn-primary')
+ = button_tag(t(".#{f.object.new_record? ? 'create' : 'update'}_btn"), class: 'btn btn-success')
diff --git a/app/views/admin/registrars/index.haml b/app/views/admin/registrars/index.haml
index 4e1c78294..ea9f7b312 100644
--- a/app/views/admin/registrars/index.haml
+++ b/app/views/admin/registrars/index.haml
@@ -1,5 +1,5 @@
- content_for :actions do
- = link_to(t(:new), new_admin_registrar_path, class: 'btn btn-primary')
+ = link_to(t('.new_btn'), new_admin_registrar_path, class: 'btn btn-primary')
= render 'shared/title', name: t(:registrars)
.row
diff --git a/config/locales/admin/registrars.en.yml b/config/locales/admin/registrars.en.yml
index 20da1a5ff..b30ad456e 100644
--- a/config/locales/admin/registrars.en.yml
+++ b/config/locales/admin/registrars.en.yml
@@ -1,7 +1,23 @@
en:
admin:
registrars:
+ index:
+ new_btn: New registrar
+
show:
new_api_use_btn: New API user
active: Active
api_users: API users
+
+ create:
+ created: Registrar has been successfully created
+ not_created: Unable to create registrar
+
+ update:
+ updated: Registrar has been successfully updated
+ not_updated: Unable to update registrar
+
+ form:
+ misc: Miscellaneous
+ create_btn: Create registrar
+ update_btn: Update registrar
diff --git a/config/locales/en.yml b/config/locales/en.yml
index d266cdfdf..aae8ae846 100644
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@@ -394,14 +394,10 @@ en:
history: 'History'
new_registrar: 'New registrar'
- registrar_added: 'Registrar added!'
- failed_to_add_registrar: 'Failed to add registrar'
registrar_details: 'Registrar details'
vat_no: 'VAT no'
edit_registrar: 'Edit registrar'
back_to_registrar: 'Back to registrar'
- registrar_updated: 'Registrar updated'
- failed_to_update_registrar: 'Failed to update registrar'
registrar_deleted: 'Registrar deleted'
failed_to_delete_registrar: 'Failed to delete registrar'
diff --git a/spec/features/admin/registrars/create_spec.rb b/spec/features/admin/registrars/create_spec.rb
new file mode 100644
index 000000000..24cc8bc2a
--- /dev/null
+++ b/spec/features/admin/registrars/create_spec.rb
@@ -0,0 +1,20 @@
+require 'rails_helper'
+
+RSpec.feature 'New registrar' do
+ background do
+ sign_in_to_admin_area
+ end
+
+ it 'creates registrar' do
+ visit admin_registrars_url
+ click_link_or_button 'New registrar'
+
+ fill_in 'registrar[name]', with: 'test'
+ fill_in 'registrar[reg_no]', with: '1234567'
+ fill_in 'registrar[email]', with: 'test@test.com'
+ fill_in 'registrar[code]', with: 'test'
+ click_link_or_button 'Create registrar'
+
+ expect(page).to have_text('Registrar has been successfully created')
+ end
+end
diff --git a/spec/features/admin/registrars/edit_spec.rb b/spec/features/admin/registrars/edit_spec.rb
new file mode 100644
index 000000000..dd619efa6
--- /dev/null
+++ b/spec/features/admin/registrars/edit_spec.rb
@@ -0,0 +1,18 @@
+require 'rails_helper'
+
+RSpec.feature 'Edit registrar' do
+ given!(:registrar) { create(:registrar_with_unlimited_balance) }
+
+ background do
+ sign_in_to_admin_area
+ end
+
+ it 'updates registrar' do
+ visit admin_registrar_url(registrar)
+ click_link_or_button 'Edit'
+
+ click_link_or_button 'Update registrar'
+
+ expect(page).to have_text('Registrar has been successfully updated')
+ end
+end
From c14d15d7b7cb01147a30a942d21a1a62f19bbd28 Mon Sep 17 00:00:00 2001
From: Artur Beljajev
Date: Tue, 21 Feb 2017 16:15:26 +0200
Subject: [PATCH 2/8] Rename registrar's url attribute to website
#279
---
app/models/whois_record.rb | 2 +-
app/presenters/registrar_presenter.rb | 4 ++--
app/views/for_models/whois.erb | 2 +-
app/views/mailers/shared/registrar/_registrar.en.html.erb | 2 +-
app/views/mailers/shared/registrar/_registrar.en.text.erb | 2 +-
app/views/mailers/shared/registrar/_registrar.et.html.erb | 2 +-
app/views/mailers/shared/registrar/_registrar.et.text.erb | 2 +-
app/views/mailers/shared/registrar/_registrar.ru.html.erb | 2 +-
app/views/mailers/shared/registrar/_registrar.ru.text.erb | 2 +-
.../20170221115548_rename_registrar_url_to_website.rb | 5 +++++
db/schema-read-only.rb | 4 ++--
db/structure.sql | 4 +++-
spec/fabricators/registrar_fabricator.rb | 2 +-
spec/presenters/registrar_presenter_spec.rb | 8 ++++----
spec/views/mailers/shared/registrar/registrar_shared.rb | 2 +-
15 files changed, 26 insertions(+), 19 deletions(-)
create mode 100644 db/migrate/20170221115548_rename_registrar_url_to_website.rb
diff --git a/app/models/whois_record.rb b/app/models/whois_record.rb
index e5de62ac0..bd16e0c99 100644
--- a/app/models/whois_record.rb
+++ b/app/models/whois_record.rb
@@ -85,7 +85,7 @@ class WhoisRecord < ActiveRecord::Base
# update registar triggers when adding new attributes
h[:registrar] = domain.registrar.name
- h[:registrar_url] = domain.registrar.url
+ h[:registrar_website] = domain.registrar.website
h[:registrar_phone] = domain.registrar.phone
h[:registrar_address] = domain.registrar.address
h[:registrar_changed] = domain.registrar.updated_at.try(:to_s, :iso8601)
diff --git a/app/presenters/registrar_presenter.rb b/app/presenters/registrar_presenter.rb
index 1fe415feb..57c130faa 100644
--- a/app/presenters/registrar_presenter.rb
+++ b/app/presenters/registrar_presenter.rb
@@ -16,8 +16,8 @@ class RegistrarPresenter
registrar.phone
end
- def url
- registrar.url
+ def website
+ registrar.website
end
private
diff --git a/app/views/for_models/whois.erb b/app/views/for_models/whois.erb
index 303d95d72..390511031 100644
--- a/app/views/for_models/whois.erb
+++ b/app/views/for_models/whois.erb
@@ -40,7 +40,7 @@ changed: <%= contact['changed'].to_s.tr('T',' ').sub('+', ' +') %>
<%- end -%>
Registrar:
name: <%= json['registrar'] %>
-url: <%= json['registrar_url'] %>
+url: <%= json['registrar_website'] %>
phone: <%= json['registrar_phone'] %>
changed: <%= json['registrar_changed'].to_s.tr('T',' ').sub('+', ' +') %>
diff --git a/app/views/mailers/shared/registrar/_registrar.en.html.erb b/app/views/mailers/shared/registrar/_registrar.en.html.erb
index 699fcd19d..914221e19 100644
--- a/app/views/mailers/shared/registrar/_registrar.en.html.erb
+++ b/app/views/mailers/shared/registrar/_registrar.en.html.erb
@@ -2,5 +2,5 @@
<%= registrar.name %>
Email: <%= registrar.email %>
Phone: <%= registrar.phone %>
- Website: <%= registrar.url %>
+ Website: <%= registrar.website %>
diff --git a/app/views/mailers/shared/registrar/_registrar.en.text.erb b/app/views/mailers/shared/registrar/_registrar.en.text.erb
index 96882b11d..1a5fbd650 100644
--- a/app/views/mailers/shared/registrar/_registrar.en.text.erb
+++ b/app/views/mailers/shared/registrar/_registrar.en.text.erb
@@ -1,4 +1,4 @@
<%= registrar.name %>
Email: <%= registrar.email %>
Phone: <%= registrar.phone %>
-Website: <%= registrar.url %>
+Website: <%= registrar.website %>
diff --git a/app/views/mailers/shared/registrar/_registrar.et.html.erb b/app/views/mailers/shared/registrar/_registrar.et.html.erb
index 199115210..647b753d5 100644
--- a/app/views/mailers/shared/registrar/_registrar.et.html.erb
+++ b/app/views/mailers/shared/registrar/_registrar.et.html.erb
@@ -2,5 +2,5 @@
<%= registrar.name %>
Email: <%= registrar.email %>
Telefon: <%= registrar.phone %>
- Veebileht: <%= registrar.url %>
+ Veebileht: <%= registrar.website %>
diff --git a/app/views/mailers/shared/registrar/_registrar.et.text.erb b/app/views/mailers/shared/registrar/_registrar.et.text.erb
index 0e8b16e30..2e435fbc9 100644
--- a/app/views/mailers/shared/registrar/_registrar.et.text.erb
+++ b/app/views/mailers/shared/registrar/_registrar.et.text.erb
@@ -1,4 +1,4 @@
<%= registrar.name %>
Email: <%= registrar.email %>
Telefon: <%= registrar.phone %>
-Veebileht: <%= registrar.url %>
+Veebileht: <%= registrar.website %>
diff --git a/app/views/mailers/shared/registrar/_registrar.ru.html.erb b/app/views/mailers/shared/registrar/_registrar.ru.html.erb
index 1c258f10d..63726c2dd 100644
--- a/app/views/mailers/shared/registrar/_registrar.ru.html.erb
+++ b/app/views/mailers/shared/registrar/_registrar.ru.html.erb
@@ -2,5 +2,5 @@
<%= registrar.name %>
Электронная почта: <%= registrar.email %>
Телефон: <%= registrar.phone %>
- Веб-сайт: <%= registrar.url %>
+ Веб-сайт: <%= registrar.website %>
diff --git a/app/views/mailers/shared/registrar/_registrar.ru.text.erb b/app/views/mailers/shared/registrar/_registrar.ru.text.erb
index 0a74e8974..bb489b9fb 100644
--- a/app/views/mailers/shared/registrar/_registrar.ru.text.erb
+++ b/app/views/mailers/shared/registrar/_registrar.ru.text.erb
@@ -1,4 +1,4 @@
<%= registrar.name %>
Электронная почта: <%= registrar.email %>
Телефон: <%= registrar.phone %>
-Веб-сайт: <%= registrar.url %>
+Веб-сайт: <%= registrar.website %>
diff --git a/db/migrate/20170221115548_rename_registrar_url_to_website.rb b/db/migrate/20170221115548_rename_registrar_url_to_website.rb
new file mode 100644
index 000000000..6aa672b3f
--- /dev/null
+++ b/db/migrate/20170221115548_rename_registrar_url_to_website.rb
@@ -0,0 +1,5 @@
+class RenameRegistrarUrlToWebsite < ActiveRecord::Migration
+ def change
+ rename_column :registrars, :url, :website
+ end
+end
diff --git a/db/schema-read-only.rb b/db/schema-read-only.rb
index 20659dafb..7bebdbba9 100644
--- a/db/schema-read-only.rb
+++ b/db/schema-read-only.rb
@@ -11,7 +11,7 @@
#
# It's strongly recommended that you check this file into your version control system.
-ActiveRecord::Schema.define(version: 20161227193500) do
+ActiveRecord::Schema.define(version: 20170221115548) do
# These are extensions that must be enabled in order to support this database
enable_extension "plpgsql"
@@ -1046,7 +1046,7 @@ ActiveRecord::Schema.define(version: 20161227193500) do
t.string "street"
t.string "zip"
t.string "code"
- t.string "url"
+ t.string "website"
t.string "directo_handle"
t.boolean "vat"
t.integer "legacy_id"
diff --git a/db/structure.sql b/db/structure.sql
index 48226e245..373d7239e 100644
--- a/db/structure.sql
+++ b/db/structure.sql
@@ -2704,7 +2704,7 @@ CREATE TABLE registrars (
street character varying,
zip character varying,
code character varying,
- url character varying,
+ website character varying,
directo_handle character varying,
vat boolean,
legacy_id integer,
@@ -5278,3 +5278,5 @@ INSERT INTO schema_migrations (version) VALUES ('20161004101419');
INSERT INTO schema_migrations (version) VALUES ('20161227193500');
+INSERT INTO schema_migrations (version) VALUES ('20170221115548');
+
diff --git a/spec/fabricators/registrar_fabricator.rb b/spec/fabricators/registrar_fabricator.rb
index bd801f642..f3a3fdc59 100644
--- a/spec/fabricators/registrar_fabricator.rb
+++ b/spec/fabricators/registrar_fabricator.rb
@@ -49,7 +49,7 @@ Fabricator(:eis, from: :registrar) do
city 'Tallinn'
street 'Paldiski mnt 80'
zip '10617'
- url 'www.internet.ee'
+ website 'www.internet.ee'
code { sequence(:code) { |i| "EIS#{i}" } }
accounts(count: 1) { Fabricate(:account, account_activities: []) }
end
diff --git a/spec/presenters/registrar_presenter_spec.rb b/spec/presenters/registrar_presenter_spec.rb
index 8223341a8..8c0196c51 100644
--- a/spec/presenters/registrar_presenter_spec.rb
+++ b/spec/presenters/registrar_presenter_spec.rb
@@ -25,10 +25,10 @@ RSpec.describe RegistrarPresenter do
end
end
- describe '#url' do
- it 'returns url' do
- expect(registrar).to receive(:url).and_return('test url')
- expect(presenter.url).to eq('test url')
+ describe '#website' do
+ it 'returns website' do
+ expect(registrar).to receive(:website).and_return('test')
+ expect(presenter.website).to eq('test')
end
end
end
diff --git a/spec/views/mailers/shared/registrar/registrar_shared.rb b/spec/views/mailers/shared/registrar/registrar_shared.rb
index f9c98c94a..2f8311545 100644
--- a/spec/views/mailers/shared/registrar/registrar_shared.rb
+++ b/spec/views/mailers/shared/registrar/registrar_shared.rb
@@ -11,7 +11,7 @@ RSpec.shared_examples 'domain mailer registrar info' do
name
email
phone
- url
+ website
)
attributes.each do |attr_name|
From c03716608510eac53f46e067fd85cdea4f03be1c Mon Sep 17 00:00:00 2001
From: Artur Beljajev
Date: Tue, 21 Feb 2017 17:49:34 +0200
Subject: [PATCH 3/8] Add registrar website to UI
#279
---
.../admin/registrars_controller.rb | 2 +-
app/models/registrar.rb | 2 +-
app/views/admin/registrars/_form.haml | 5 ++++
app/views/admin/registrars/show.haml | 3 +++
spec/requests/admin/registrars/create_spec.rb | 24 +++++++++++++++++++
spec/requests/admin/registrars/update_spec.rb | 24 +++++++++++++++++++
.../views/admin/registrars/_form.haml_spec.rb | 15 ++++++++++++
spec/views/admin/registrars/show.haml_spec.rb | 15 ++++++++++++
8 files changed, 88 insertions(+), 2 deletions(-)
create mode 100644 spec/requests/admin/registrars/create_spec.rb
create mode 100644 spec/requests/admin/registrars/update_spec.rb
create mode 100644 spec/views/admin/registrars/_form.haml_spec.rb
create mode 100644 spec/views/admin/registrars/show.haml_spec.rb
diff --git a/app/controllers/admin/registrars_controller.rb b/app/controllers/admin/registrars_controller.rb
index d29ce40d3..cd936a15c 100644
--- a/app/controllers/admin/registrars_controller.rb
+++ b/app/controllers/admin/registrars_controller.rb
@@ -62,7 +62,7 @@ class Admin::RegistrarsController < AdminController
def registrar_params
params.require(:registrar).permit(
:name, :reg_no, :vat_no, :street, :city, :state, :zip, :billing_address,
- :country_code, :email, :phone, :billing_email, :code, :test_registrar
+ :country_code, :email, :phone, :website, :billing_email, :code, :test_registrar
)
end
end
diff --git a/app/models/registrar.rb b/app/models/registrar.rb
index 162aef292..55581e3b8 100644
--- a/app/models/registrar.rb
+++ b/app/models/registrar.rb
@@ -12,7 +12,7 @@ class Registrar < ActiveRecord::Base
has_many :priv_contacts, -> { privs }, class_name: 'Contact'
has_many :white_ips, dependent: :destroy
- delegate :balance, to: :cash_account
+ delegate :balance, to: :cash_account, allow_nil: true
validates :name, :reg_no, :country_code, :email, :code, presence: true
validates :name, :reg_no, :reference_no, :code, uniqueness: true
diff --git a/app/views/admin/registrars/_form.haml b/app/views/admin/registrars/_form.haml
index 6f80abba6..d62a375f8 100644
--- a/app/views/admin/registrars/_form.haml
+++ b/app/views/admin/registrars/_form.haml
@@ -27,6 +27,11 @@
= f.label :phone
.col-md-7
= f.text_field(:phone, class: 'form-control')
+ .form-group
+ .col-md-4.control-label
+ = f.label :website
+ .col-md-7
+ = f.url_field :website, class: 'form-control'
.form-group
.col-md-4.control-label
= f.label :email
diff --git a/app/views/admin/registrars/show.haml b/app/views/admin/registrars/show.haml
index 4ea74029e..1907a63ed 100644
--- a/app/views/admin/registrars/show.haml
+++ b/app/views/admin/registrars/show.haml
@@ -39,6 +39,9 @@
%dt= t(:credit_balance)
%dd= @registrar.balance
+ %dt= Registrar.human_attribute_name :website
+ %dd= @registrar.website
+
.col-md-6
.panel.panel-default
.panel-heading
diff --git a/spec/requests/admin/registrars/create_spec.rb b/spec/requests/admin/registrars/create_spec.rb
new file mode 100644
index 000000000..e144b19f8
--- /dev/null
+++ b/spec/requests/admin/registrars/create_spec.rb
@@ -0,0 +1,24 @@
+require 'rails_helper'
+
+RSpec.describe 'admin registrar create' do
+ subject(:registrar) { Registrar.first }
+
+ before :example do
+ sign_in_to_admin_area
+ end
+
+ it 'creates new registrar' do
+ expect { post admin_registrars_path, registrar: attributes_for(:registrar) }
+ .to change { Registrar.count }.from(0).to(1)
+ end
+
+ it 'saves website' do
+ post admin_registrars_path, { registrar: attributes_for(:registrar, website: 'test') }
+ expect(registrar.website).to eq('test')
+ end
+
+ it 'redirects to :show' do
+ post admin_registrars_path, { registrar: attributes_for(:registrar) }
+ expect(response).to redirect_to admin_registrar_path(registrar)
+ end
+end
diff --git a/spec/requests/admin/registrars/update_spec.rb b/spec/requests/admin/registrars/update_spec.rb
new file mode 100644
index 000000000..fc99bccd0
--- /dev/null
+++ b/spec/requests/admin/registrars/update_spec.rb
@@ -0,0 +1,24 @@
+require 'rails_helper'
+
+RSpec.describe 'admin registrar update' do
+ before :example do
+ sign_in_to_admin_area
+ end
+
+ it 'updates website' do
+ registrar = create(:registrar, website: 'test')
+
+ patch admin_registrar_path(registrar), registrar: attributes_for(:registrar, website: 'new-website')
+ registrar.reload
+
+ expect(registrar.website).to eq('new-website')
+ end
+
+ it 'redirects to :show' do
+ registrar = create(:registrar)
+
+ patch admin_registrar_path(registrar), { registrar: attributes_for(:registrar) }
+
+ expect(response).to redirect_to admin_registrar_path(registrar)
+ end
+end
diff --git a/spec/views/admin/registrars/_form.haml_spec.rb b/spec/views/admin/registrars/_form.haml_spec.rb
new file mode 100644
index 000000000..98021d93a
--- /dev/null
+++ b/spec/views/admin/registrars/_form.haml_spec.rb
@@ -0,0 +1,15 @@
+require 'rails_helper'
+
+RSpec.describe 'admin/registrars/_form' do
+ let(:registrar) { build_stubbed(:registrar) }
+
+ before :example do
+ assign(:registrar, registrar)
+ stub_template 'shared/_full_errors' => ''
+ end
+
+ it 'has website' do
+ render
+ expect(rendered).to have_css('[name="registrar[website]"]')
+ end
+end
diff --git a/spec/views/admin/registrars/show.haml_spec.rb b/spec/views/admin/registrars/show.haml_spec.rb
new file mode 100644
index 000000000..6ec9cab14
--- /dev/null
+++ b/spec/views/admin/registrars/show.haml_spec.rb
@@ -0,0 +1,15 @@
+require 'rails_helper'
+
+RSpec.describe 'admin/registrars/show' do
+ let(:registrar) { build_stubbed(:registrar, website: 'test website') }
+
+ before :example do
+ assign(:registrar, registrar)
+ stub_template 'shared/_title' => ''
+ end
+
+ it 'has website' do
+ render
+ expect(rendered).to have_text('test website')
+ end
+end
From 06aeea81b365540c42ac20822e512ae550312f72 Mon Sep 17 00:00:00 2001
From: Artur Beljajev
Date: Tue, 21 Feb 2017 18:02:15 +0200
Subject: [PATCH 4/8] Fix registrar url
#279
---
app/models/registrar.rb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/models/registrar.rb b/app/models/registrar.rb
index 55581e3b8..734e68898 100644
--- a/app/models/registrar.rb
+++ b/app/models/registrar.rb
@@ -102,7 +102,7 @@ class Registrar < ActiveRecord::Base
buyer_city: city,
buyer_zip: zip,
buyer_phone: phone,
- buyer_url: url,
+ buyer_url: website,
buyer_email: email,
reference_no: reference_no,
invoice_items_attributes: [
From 458bbf7b807fda448ae4d3d855ccf07defa09567 Mon Sep 17 00:00:00 2001
From: Artur Beljajev
Date: Wed, 22 Feb 2017 10:24:56 +0200
Subject: [PATCH 5/8] Fix registrar spec
#279
---
spec/features/admin/registrars/edit_spec.rb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/spec/features/admin/registrars/edit_spec.rb b/spec/features/admin/registrars/edit_spec.rb
index dd619efa6..f02164f91 100644
--- a/spec/features/admin/registrars/edit_spec.rb
+++ b/spec/features/admin/registrars/edit_spec.rb
@@ -1,7 +1,7 @@
require 'rails_helper'
RSpec.feature 'Edit registrar' do
- given!(:registrar) { create(:registrar_with_unlimited_balance) }
+ given!(:registrar) { create(:registrar) }
background do
sign_in_to_admin_area
From 5947d2186891b182627b461c3367dd58ec7e05fa Mon Sep 17 00:00:00 2001
From: Artur Beljajev
Date: Wed, 22 Feb 2017 11:24:09 +0200
Subject: [PATCH 6/8] Add admin#registrars routing spec
#279
---
spec/routing/admin/registrars_routing_spec.rb | 33 +++++++++++++++++++
1 file changed, 33 insertions(+)
create mode 100644 spec/routing/admin/registrars_routing_spec.rb
diff --git a/spec/routing/admin/registrars_routing_spec.rb b/spec/routing/admin/registrars_routing_spec.rb
new file mode 100644
index 000000000..14ec765e9
--- /dev/null
+++ b/spec/routing/admin/registrars_routing_spec.rb
@@ -0,0 +1,33 @@
+require 'rails_helper'
+
+RSpec.describe Admin::RegistrarsController do
+ describe 'routing' do
+ it 'routes to #index' do
+ expect(get: '/admin/registrars').to route_to('admin/registrars#index')
+ end
+
+ it 'routes to #new' do
+ expect(get: '/admin/registrars/new').to route_to('admin/registrars#new')
+ end
+
+ it 'routes to #show' do
+ expect(get: '/admin/registrars/1').to route_to('admin/registrars#show', id: '1')
+ end
+
+ it 'routes to #edit' do
+ expect(get: '/admin/registrars/1/edit').to route_to('admin/registrars#edit', id: '1')
+ end
+
+ it 'routes to #create' do
+ expect(post: '/admin/registrars').to route_to('admin/registrars#create')
+ end
+
+ it 'routes to #update' do
+ expect(patch: '/admin/registrars/1').to route_to('admin/registrars#update', id: '1')
+ end
+
+ it 'routes to #destroy' do
+ expect(delete: '/admin/registrars/1').to route_to('admin/registrars#destroy', id: '1')
+ end
+ end
+end
From bccf6770ddf9cdd8f2e5f96d4fcd498899de940d Mon Sep 17 00:00:00 2001
From: Artur Beljajev
Date: Tue, 28 Feb 2017 10:04:54 +0200
Subject: [PATCH 7/8] Remove "force_delete_time" from domain since it is
already defined in concern
#268
---
spec/models/domain_spec.rb | 1 -
1 file changed, 1 deletion(-)
diff --git a/spec/models/domain_spec.rb b/spec/models/domain_spec.rb
index 7af6cd1d1..65c96dbe8 100644
--- a/spec/models/domain_spec.rb
+++ b/spec/models/domain_spec.rb
@@ -607,7 +607,6 @@ end
RSpec.describe Domain, db: false do
it { is_expected.to alias_attribute(:on_hold_time, :outzone_at) }
- it { is_expected.to alias_attribute(:force_delete_time, :force_delete_at) }
it { is_expected.to alias_attribute(:outzone_time, :outzone_at) }
describe 'nameserver validation', db: true do
From 6fe688a23891d08e05804d309b8d65c02e98e74f Mon Sep 17 00:00:00 2001
From: Artur Beljajev
Date: Tue, 28 Feb 2017 11:51:32 +0200
Subject: [PATCH 8/8] Update changelog
#279
---
CHANGELOG.md | 3 +++
1 file changed, 3 insertions(+)
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 157cc9501..2258def21 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,6 @@
+28.02.2017
+* Add missing registrar's website field in UI
+
24.01.2017
* Disallow EPP domain:update/transfer/delete if a domain has "deleteCandidate" status