zydronium/internetee-registry
1
0
Fork 0
mirror of https://github.com/internetee/registry.git synced 2025-06-12 07:34:45 +02:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #2096 from internetee/2095-undefined-method-settings

Browse source 
Fix for manual invoice binding
This commit is contained in:
Timo Võhmar 2021-08-11 09:56:54 +03:00 • committed by GitHub
commit 8f9b39fce6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
app/models/bank_transaction.rb
View file

@ -92,7 +92,7 @@ class BankTransaction < ApplicationRecord
activity_type: AccountActivity::ADD_CREDIT) activity_type: AccountActivity::ADD_CREDIT)
if activity.save if activity.save
reset_pending_registrar_balance_reload reset_pending_registrar_balance_reload registrar
true true
else else
false false
@ -105,7 +105,7 @@ class BankTransaction < ApplicationRecord
private private
def reset_pending_registrar_balance_reload def reset_pending_registrar_balance_reload(registrar)
return unless registrar.settings['balance_auto_reload'] return unless registrar.settings['balance_auto_reload']
registrar.settings['balance_auto_reload'].delete('pending') registrar.settings['balance_auto_reload'].delete('pending')

13
test/models/bank_transaction_test.rb
View file

@ -180,6 +180,19 @@ class BankTransactionTest < ActiveSupport::TestCase
statement.description = "all invalid 12 123 55 77777 --" statement.description = "all invalid 12 123 55 77777 --"
assert_nil statement.parsed_ref_number assert_nil statement.parsed_ref_number
end end
def test_manual_bind_with_wrong_ref_number
invoice_ref_no = '1111'
bank_transaction_ref_no = '9999'
create_payable_invoice(number: '2222', total: 10, reference_no: invoice_ref_no)
transaction = BankTransaction.new(description: 'invoice #2222',
sum: 10,
reference_no: bank_transaction_ref_no)
assert_difference 'AccountActivity.count' do
transaction.bind_invoice('2222')
end
end
private private
def create_payable_invoice(attributes) def create_payable_invoice(attributes)