Cleanups, design improvements

app/controllers/admin/nameservers_controller.rb

@@ -1,4 +1,8 @@
 class Admin::NameserversController < ApplicationController
+  # TODO: Refactor this to domain_nameservers controller!
+  before_action :set_domain
+  before_action :set_nameserver, only: [:edit, :update, :destroy]
+
   def new
     @domain = Domain.find(params[:domain_id])
     @nameserver = @domain.nameservers.build
@@ -15,6 +19,19 @@ class Admin::NameserversController < ApplicationController
     end
   end
 
+  def edit
+    @domain = Domain.find(params[:domain_id])
+    @nameserver = Nameserver.find(params[:id])
+  end
+
+  def update
+    if @nameserver.update(nameserver_params) && @domain.valid?
+      redirect_to [:admin, @domain]
+    else
+      render 'edit'
+    end
+  end
+
   def destroy
     # TODO: Refactor this
     @nameserver = Nameserver.find(params[:id])
@@ -25,6 +42,14 @@ class Admin::NameserversController < ApplicationController
 
   private
 
+  def set_domain
+    @domain = Domain.find(params[:domain_id])
+  end
+
+  def set_nameserver
+    @nameserver = Nameserver.find(params[:id])
+  end
+
   def nameserver_params
     params.require(:nameserver).permit(:hostname, :ipv4, :ipv6)
   end

app/views/admin/domains/index.haml

@@ -1,4 +1,9 @@
-%h2= t('shared.domains')
+.row
+  .col-sm-6
+    %h2.text-center-xs= t('shared.domains')
+  .col-sm-6
+    %h2.text-right.text-center-xs
+      = link_to(t('shared.add'), new_admin_domain_path, class: 'btn btn-primary')
 %hr
 .row
   .col-md-12

app/views/admin/domains/new.haml

@@ -1,7 +1,6 @@
 %h2= t('shared.new_domain')
 %hr
 = form_for([:admin, @domain]) do |f|
-  = @domain.errors.inspect
   - if @domain.errors.any?
     - @domain.errors.each do |attr, err|
       = err

app/views/admin/domains/partials/_nameservers.haml

@@ -20,8 +20,8 @@
             %td= x.ipv4
             %td= x.ipv6
             %td
-              = link_to(t('shared.edit'), root_path, class: 'btn btn-primary btn-xs')
+              = link_to(t('shared.edit'), edit_admin_domain_nameserver_path(@domain, x), class: 'btn btn-primary btn-xs')
-              = link_to(t('shared.delete'), [:admin, x], method: :delete, data: { confirm: t('shared.are_you_sure') }, class: 'btn btn-danger btn-xs')
+              = link_to(t('shared.delete'), admin_domain_nameserver_path(@domain, x), method: :delete, data: { confirm: t('shared.are_you_sure') }, class: 'btn btn-danger btn-xs')
       - if @domain.errors.messages[:nameservers]
         %tfoot
           - @domain.errors.messages[:nameservers].each do |x|

app/views/admin/nameservers/_form.html.haml

@@ -0,0 +1,28 @@
+= form_for([:admin, @domain, @nameserver]) do |f|
+  = render 'admin/shared/errors', object: @domain
+  = render 'admin/shared/errors', object: f.object
+
+  - if @domain.errors.any?
+    %hr
+
+  .row
+    .col-md-6
+      .form-group
+        = label_tag t('shared.domain')
+        = text_field_tag :domain, @domain.name, disabled: true, class: 'form-control'
+    .col-md-6
+      .form-group
+        = f.label :hostname
+        = f.text_field(:hostname, class: 'form-control', autocomplete: 'off')
+  .row
+    .col-md-6
+      .form-group
+        = f.label :ipv4
+        = f.text_field(:ipv4, class: 'form-control', autocomplete: 'off')
+    .col-md-6
+      .form-group
+        = f.label :ipv6
+        = f.text_field(:ipv6, class: 'form-control', autocomplete: 'off')
+  .row
+    .col-md-12.text-right
+      = button_tag(t('shared.save'), class: 'btn btn-primary')

app/views/admin/nameservers/edit.haml

@@ -0,0 +1,3 @@
+%h2= t('shared.edit_nameserver')
+%hr
+= render 'form'

app/views/admin/nameservers/new.haml

@@ -1,30 +1,3 @@
 %h2= t('shared.new_nameserver')
 %hr
-= form_for([:admin, @domain, @nameserver]) do |f|
+= render 'form'
-  = render 'admin/shared/errors', object: @domain
-  = render 'admin/shared/errors', object: f.object
-
-  - if @domain.errors.any?
-    %hr
-
-  .row
-    .col-md-6
-      .form-group
-        = label_tag t('shared.domain')
-        = text_field_tag :domain, @domain.name, disabled: true, class: 'form-control'
-    .col-md-6
-      .form-group
-        = f.label :hostname
-        = f.text_field(:hostname, class: 'form-control', autocomplete: 'off')
-  .row
-    .col-md-6
-      .form-group
-        = f.label :ipv4
-        = f.text_field(:ipv4, class: 'form-control', autocomplete: 'off')
-    .col-md-6
-      .form-group
-        = f.label :ipv6
-        = f.text_field(:ipv6, class: 'form-control', autocomplete: 'off')
-  .row
-    .col-md-12.text-right
-      = button_tag(t('shared.save'), class: 'btn btn-primary')

config/locales/en.yml

@@ -190,3 +190,5 @@ en:
     contact_code: 'Contact code'
     add: 'Add'
     domain: 'Domain'
+    new_nameserver: 'New nameserver'
+    edit_nameserver: 'Edit nameserver'

config/routes.rb

@@ -7,8 +7,7 @@ Rails.application.routes.draw do
 
   namespace(:admin) do
     resources :domains do
-      resources :nameservers, shallow: true
+      resources :nameservers
-
     end
     resources :setting_groups
     resources :registrars do