Extract company register

Closes #1079, #916, #1077

test/integration/api/registrant/registrant_api_contacts_test.rb

@@ -5,33 +5,15 @@ class RegistrantApiContactsTest < ApplicationIntegrationTest
   def setup
     super
 
-    @original_registry_time = Setting.days_to_keep_business_registry_cache
-    Setting.days_to_keep_business_registry_cache = 1
-    travel_to Time.zone.parse('2010-07-05')
-
+    @contact = contacts(:john)
     @user = users(:registrant)
     @auth_headers = { 'HTTP_AUTHORIZATION' => auth_token }
   end
 
-  def teardown
-    super
-
-    Setting.days_to_keep_business_registry_cache = @original_registry_time
-    travel_back
-  end
-
-  def test_root_returns_contact_list
-    get '/api/v1/registrant/contacts', {}, @auth_headers
-    assert_equal(200, response.status)
-
-    json_body = JSON.parse(response.body, symbolize_names: true)
-    assert_equal(4, json_body.count)
-    array_of_contact_codes = json_body.map { |x| x[:code] }
-    assert(array_of_contact_codes.include?('william-001'))
-    assert(array_of_contact_codes.include?('jane-001'))
-  end
-
   def test_root_accepts_limit_and_offset_parameters
+    contacts(:william).update!(ident: '1234', ident_type: 'priv', ident_country_code: 'US')
+    assert_equal 3, @user.contacts.size
+
     get '/api/v1/registrant/contacts', { 'limit' => 1, 'offset' => 0 }, @auth_headers
     response_json = JSON.parse(response.body, symbolize_names: true)
     assert_equal(200, response.status)
@@ -39,26 +21,15 @@ class RegistrantApiContactsTest < ApplicationIntegrationTest
 
     get '/api/v1/registrant/contacts', {}, @auth_headers
     response_json = JSON.parse(response.body, symbolize_names: true)
-    assert_equal(4, response_json.count)
+    assert_equal(3, response_json.count)
   end
 
   def test_get_contact_details_by_uuid
-    get '/api/v1/registrant/contacts/0aa54704-d6f7-4ca9-b8ca-2827d9a4e4eb', {}, @auth_headers
-    assert_equal(200, response.status)
+    get api_v1_registrant_contact_path(@contact.uuid), nil, @auth_headers
 
-    contact = JSON.parse(response.body, symbolize_names: true)
-    assert_equal('william@inbox.test', contact[:email])
-  end
-
-  def test_root_returns_503_when_business_registry_is_not_available
-    raise_not_available = -> (a, b) { raise Soap::Arireg::NotAvailableError.new({}) }
-    BusinessRegistryCache.stub :fetch_by_ident_and_cc, raise_not_available do
-      get '/api/v1/registrant/contacts', {}, @auth_headers
-
-      assert_equal(503, response.status)
-      response_json = JSON.parse(response.body, symbolize_names: true)
-      assert_equal({ errors: [base: ['Business Registry not available']] }, response_json)
-    end
+    assert_response :ok
+    response_json = JSON.parse(response.body, symbolize_names: true)
+    assert_equal 'john@inbox.test', response_json[:email]
   end
 
   def test_get_contact_details_by_uuid_returns_404_for_non_existent_contact

test/integration/api/registrant/registrant_api_domains_test.rb

@@ -5,23 +5,12 @@ class RegistrantApiDomainsTest < ApplicationIntegrationTest
   def setup
     super
 
-    @original_registry_time = Setting.days_to_keep_business_registry_cache
-    Setting.days_to_keep_business_registry_cache = 1
-    travel_to Time.zone.parse('2010-07-05')
-
     @domain = domains(:hospital)
     @registrant = @domain.registrant
     @user = users(:registrant)
     @auth_headers = { 'HTTP_AUTHORIZATION' => auth_token }
   end
 
-  def teardown
-    super
-
-    Setting.days_to_keep_business_registry_cache = @original_registry_time
-    travel_back
-  end
-
   def test_get_domain_details_by_uuid
     get '/api/v1/registrant/domains/5edda1a5-3548-41ee-8b65-6d60daf85a37', {}, @auth_headers
     assert_equal(200, response.status)

test/integration/api/registrant/registrant_api_registry_locks_test.rb

@@ -5,22 +5,11 @@ class RegistrantApiRegistryLocksTest < ApplicationIntegrationTest
   def setup
     super
 
-    @original_registry_time = Setting.days_to_keep_business_registry_cache
-    Setting.days_to_keep_business_registry_cache = 1
-    travel_to Time.zone.parse('2010-07-05')
-
     @user = users(:registrant)
     @domain = domains(:airport)
     @auth_headers = { 'HTTP_AUTHORIZATION' => auth_token }
   end
 
-  def teardown
-    super
-
-    Setting.days_to_keep_business_registry_cache = @original_registry_time
-    travel_back
-  end
-
   def test_can_lock_a_not_locked_domain
     post '/api/v1/registrant/domains/2df2c1a1-8f6a-490a-81be-8bdf29866880/registry_lock',
          {}, @auth_headers
@@ -101,11 +90,19 @@ class RegistrantApiRegistryLocksTest < ApplicationIntegrationTest
   end
 
   def test_technical_contact_cannot_lock_a_domain
-    post '/api/v1/registrant/domains/647bcc48-8d5e-4a04-8ce5-2a3cd17b6eab/registry_lock',
-         {}, @auth_headers
+    domain = domains(:shop)
+    contact = contacts(:john)
+    domain.update!(registrant: contacts(:william).becomes(Registrant))
+    domain.tech_contacts = [contact]
+    domain.admin_contacts.clear
+    assert_equal 'US-1234', @user.registrant_ident
+    assert_equal '1234', contact.ident
+    assert_equal 'US', contact.ident_country_code
 
+    post api_v1_registrant_domain_registry_lock_path(domain.uuid), nil, @auth_headers
+
+    assert_response :unauthorized
     response_json = JSON.parse(response.body, symbolize_names: true)
-    assert_equal(401, response.status)
     assert_equal({ errors: [{ base: ['Only administrative contacts can manage registry locks'] }] },
                  response_json)
   end
@@ -123,6 +120,7 @@ class RegistrantApiRegistryLocksTest < ApplicationIntegrationTest
   end
 
   def test_locking_domains_returns_serialized_domain_object
+    travel_to Time.zone.parse('2010-07-05')
     assert_equal 'Best Names', @domain.registrar.name
     assert_equal 'https://bestnames.test', @domain.registrar.website