From 7d94273a5ed3518b6b719e783a136b7a0c364d7a Mon Sep 17 00:00:00 2001
From: Artur Beljajev <artur.beljajev@internet.ee>
Date: Tue, 23 May 2017 17:31:32 +0300
Subject: [PATCH] Do not allow to permanently remove a price

#522
---
 .../admin/billing/prices_controller.rb        |  6 -----
 app/views/admin/billing/prices/edit.html.erb  | 13 ++---------
 config/locales/admin/billing/prices.en.yml    |  5 ----
 config/routes.rb                              |  2 +-
 .../admin/billing/prices/delete_spec.rb       | 23 -------------------
 .../admin/billing/prices/destroy_spec.rb      | 18 ---------------
 6 files changed, 3 insertions(+), 64 deletions(-)
 delete mode 100644 spec/features/admin/billing/prices/delete_spec.rb
 delete mode 100644 spec/requests/admin/billing/prices/destroy_spec.rb

diff --git a/app/controllers/admin/billing/prices_controller.rb b/app/controllers/admin/billing/prices_controller.rb
index f66d3351b..009502030 100644
--- a/app/controllers/admin/billing/prices_controller.rb
+++ b/app/controllers/admin/billing/prices_controller.rb
@@ -41,12 +41,6 @@ module Admin
         end
       end
 
-      def destroy
-        @price.destroy!
-        flash[:notice] = t('.destroyed')
-        redirect_to_index
-      end
-
       private
 
       def load_price
diff --git a/app/views/admin/billing/prices/edit.html.erb b/app/views/admin/billing/prices/edit.html.erb
index 75d82814f..fca70f371 100644
--- a/app/views/admin/billing/prices/edit.html.erb
+++ b/app/views/admin/billing/prices/edit.html.erb
@@ -3,17 +3,8 @@
 </ol>
 
 <div class="page-header">
-    <div class="row">
-        <div class="col-sm-10">
-            <h1><%= t '.title' %></h1>
-        </div>
-
-        <div class="col-sm-2 text-right">
-            <%= link_to(t('.delete_btn'), admin_price_path(@price),
-                        method: :delete,
-                        data: { confirm: t('.delete_btn_confirm') },
-                        class: 'btn btn-danger') %>
-        </div>
+    <div class="col-sm-10">
+        <h1><%= t '.title' %></h1>
     </div>
 </div>
 
diff --git a/config/locales/admin/billing/prices.en.yml b/config/locales/admin/billing/prices.en.yml
index 277b708da..d4e4f5174 100644
--- a/config/locales/admin/billing/prices.en.yml
+++ b/config/locales/admin/billing/prices.en.yml
@@ -15,15 +15,10 @@ en:
 
         edit:
           title: Edit price
-          delete_btn: Delete
-          delete_btn_confirm: Are you sure you want to delete price?
 
         update:
           updated: Price has been updated
 
-        destroy:
-          destroyed: Price has been deleted
-
         form:
           create_btn: Create price
           update_btn: Update price
diff --git a/config/routes.rb b/config/routes.rb
index 3cba3234a..9eed77059 100644
--- a/config/routes.rb
+++ b/config/routes.rb
@@ -166,7 +166,7 @@ Rails.application.routes.draw do
     resources :zones, controller: 'dns/zones', except: %i[show destroy]
     resources :legal_documents
     resources :keyrelays
-    resources :prices, controller: 'billing/prices', except: %i[show]
+    resources :prices, controller: 'billing/prices', except: %i[show destroy]
     resources :mail_templates
     resources :account_activities
 
diff --git a/spec/features/admin/billing/prices/delete_spec.rb b/spec/features/admin/billing/prices/delete_spec.rb
deleted file mode 100644
index 37c8f4003..000000000
--- a/spec/features/admin/billing/prices/delete_spec.rb
+++ /dev/null
@@ -1,23 +0,0 @@
-require 'rails_helper'
-
-RSpec.feature 'Deleting price in admin area', settings: false do
-  given!(:price) { create(:price) }
-
-  background do
-    sign_in_to_admin_area
-  end
-
-  scenario 'deletes price' do
-    visit admin_prices_url
-    open_form
-    click_link_or_button t('admin.billing.prices.edit.delete_btn')
-
-    expect(page).to have_text(t('admin.billing.prices.destroy.destroyed'))
-  end
-
-  private
-
-  def open_form
-    click_link_or_button 'admin-edit-price-btn'
-  end
-end
diff --git a/spec/requests/admin/billing/prices/destroy_spec.rb b/spec/requests/admin/billing/prices/destroy_spec.rb
deleted file mode 100644
index 5a34b8dcb..000000000
--- a/spec/requests/admin/billing/prices/destroy_spec.rb
+++ /dev/null
@@ -1,18 +0,0 @@
-require 'rails_helper'
-
-RSpec.describe 'admin price destroy', settings: false do
-  let!(:price) { create(:price) }
-
-  before :example do
-    sign_in_to_admin_area
-  end
-
-  it 'deletes price' do
-    expect { delete admin_price_path(price) }.to change { Billing::Price.count }.from(1).to(0)
-  end
-
-  it 'redirects to :index' do
-    delete admin_price_path(price)
-    expect(response).to redirect_to admin_prices_url
-  end
-end