Story #109367694 - refactor: move UserEvents include up, wrap method in included block, say self

app/models/concerns/user_events.rb

@@ -1,25 +1,28 @@
 module UserEvents
   extend ActiveSupport::Concern
 
-  # EPP requires a server defined creator ID, which should be registrar code if we have one
+  included do
-  def cr_id
+    # EPP requires a server defined creator ID, which should be registrar code if we have one
-    # try this, rebuild user for registrar before searching history? really?
+    def cr_id
-    registrar = self.creator.try(:registrar)
+      # try this, rebuild user for registrar before searching history? really?
-    if registrar.present?            # Did creator return a kind of User that has a registrar?
+      registrar = self.creator.try(:registrar)
-      registrar.code
+      if registrar.present?            # Did creator return a kind of User that has a registrar?
-    else
+        registrar.code
-      if versions.first.object.nil?
-        cr_registrar_id =versions.first.object_changes['registrar_id'].second
       else
-        # untested, expected never to execute
+        if self.versions.first.try(:object).nil?
-        cr_registrar_id = versions.first.object['registrar_id']
+          changes = self.versions.first.try(:object_changes)
-      end
+          cr_registrar_id = changes['registrar_id'].second if changes.present?
+        else
+          # untested, expected never to execute
+          cr_registrar_id = self.versions.first.object['registrar_id']
+        end
 
-      if cr_registrar_id.present?
+        if cr_registrar_id.present?
-        Registrar.find(cr_registrar_id).code
+          Registrar.find(cr_registrar_id).code
-      else
+        else
-        # cr_id optional for domain, but required for contact; but we want something here anyway
+          # cr_id optional for domain, but required for contact; but we want something here anyway
-        self.creator_str # Fallback if we failed, maybe we can find a string here
+          self.creator_str # Fallback if we failed, maybe we can find a string here
+        end
       end
     end
   end

app/models/contact.rb

@@ -1,6 +1,7 @@
 class Contact < ActiveRecord::Base
   include Versions # version/contact_version.rb
   include EppErrors
+  include UserEvents
 
   belongs_to :registrar
   has_many :domain_contacts

app/models/domain.rb

@@ -1,5 +1,6 @@
 # rubocop: disable Metrics/ClassLength
 class Domain < ActiveRecord::Base
+  include UserEvents
   include Versions # version/domain_version.rb
   include Statuses
   has_paper_trail class_name: "DomainVersion", meta: { children: :children_log }

app/models/version/contact_version.rb

@@ -2,8 +2,6 @@ class ContactVersion < PaperTrail::Version
   include VersionSession
   self.table_name    = :log_contacts
   self.sequence_name = :log_contacts_id_seq
-
+  
-  include UserEvents
-
   # scope :deleted, -> { where(event: 'destroy') }
 end

app/models/version/domain_version.rb

@@ -4,7 +4,5 @@ class DomainVersion < PaperTrail::Version
   self.table_name    = :log_domains
   self.sequence_name = :log_domains_id_seq
 
-  include UserEvents
-
   scope :deleted, -> { where(event: 'destroy') }
 end