zydronium/internetee-registry
1
0
Fork 0
mirror of https://github.com/internetee/registry.git synced 2025-07-01 08:43:37 +02:00
Code Issues Projects Releases Packages Wiki Activity

Validate period for invalid values, refactor optional attribute validator, tests #2763

Browse source
This commit is contained in:
Martin Lensment 2015-07-16 17:19:16 +03:00
parent 92e25cb61e
commit 7a8c7dd39e
4 changed files with 83 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

15
app/controllers/epp/domains_controller.rb
View file

@ -91,11 +91,17 @@ class Epp::DomainsController < EppController
render_epp_response '/epp/domains/check'
end
# rubocop: disable Metrics/MethodLength
def renew
authorize! :renew, @domain
period = params[:parsed_frame].css('period').text
period_unit = params[:parsed_frame].css('period').first['unit']
period = params[:parsed_frame].css('period').text.presence || 1
period_unit = 'y'
period_element = params[:parsed_frame].css('period').first
if period_element.present? && period_element['unit'].present?
period_unit = period_element['unit']
end
ActiveRecord::Base.transaction do
success = @domain.renew(
@ -122,6 +128,7 @@ class Epp::DomainsController < EppController
end
end
end
# rubocop: enable Metrics/MethodLength
def transfer
authorize! :transfer, @domain, @password
@ -182,7 +189,9 @@ class Epp::DomainsController < EppController
def validate_renew
@prefix = 'renew > renew >'
requires 'name', 'curExpDate', 'period'
requires 'name', 'curExpDate'
optional_attribute 'period', 'unit', values: %w(d m y)
end
def validate_transfer