From 74efc601392048e4516a8cbdccfd71546229583d Mon Sep 17 00:00:00 2001 From: olegphenomenon Date: Thu, 11 Nov 2021 13:14:09 +0200 Subject: [PATCH] refactored --- .../repp/v1/registrar/accreditation_results_controller.rb | 4 ++-- app/jobs/notify_accreditation_admins_and_registrars_job.rb | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/controllers/repp/v1/registrar/accreditation_results_controller.rb b/app/controllers/repp/v1/registrar/accreditation_results_controller.rb index e860a8679..b58fd3895 100644 --- a/app/controllers/repp/v1/registrar/accreditation_results_controller.rb +++ b/app/controllers/repp/v1/registrar/accreditation_results_controller.rb @@ -45,8 +45,8 @@ module Repp end def notify_admins - admin_users_emails = User.all.reject { |u| u.roles.nil? }. - select { |u| u.roles.include? 'admin' }.pluck(:email) + admin_users_emails = User.all.reject { |u| u.roles.nil? } + .select { |u| u.roles.include? 'admin' }.pluck(:email) return if admin_users_emails.empty? diff --git a/app/jobs/notify_accreditation_admins_and_registrars_job.rb b/app/jobs/notify_accreditation_admins_and_registrars_job.rb index 50252ce9c..72ea5dfe5 100644 --- a/app/jobs/notify_accreditation_admins_and_registrars_job.rb +++ b/app/jobs/notify_accreditation_admins_and_registrars_job.rb @@ -25,12 +25,12 @@ class NotifyAccreditationAdminsAndRegistrarsJob < ApplicationJob private def prepare_data_month_before - ApiUser.where("accreditation_expire_date > ? AND accreditation_expire_date < ?", + ApiUser.where('accreditation_expire_date > ? AND accreditation_expire_date < ?', Time.zone.now.beginning_of_day + MONTH_BEFORE, Time.zone.now.end_of_day + MONTH_BEFORE).includes(:registrar) end def prepare_data_expired_data - ApiUser.where("accreditation_expire_date < ?", Time.zone.now.beginning_of_day).includes(:registrar) + ApiUser.where('accreditation_expire_date < ?', Time.zone.now.beginning_of_day).includes(:registrar) end end