Resolve merge errors

test/models/contact_test.rb

@@ -3,10 +3,15 @@ require 'test_helper'
 class ContactTest < ActiveSupport::TestCase
   setup do
     @contact = contacts(:john)
+    @old_validation_type = Truemail.configure.default_validation_type
   end
 
-  def test_valid_fixture_is_valid
-    assert @contact.valid?, proc { @contact.errors.full_messages }
+  teardown do
+    Truemail.configure.default_validation_type = @old_validation_type
+  end
+
+  def test_valid_contact_fixture_is_valid
+    assert valid_contact.valid?, proc { valid_contact.errors.full_messages }
   end
 
   def test_invalid_fixture_is_invalid
@@ -21,33 +26,134 @@ class ContactTest < ActiveSupport::TestCase
     assert_equal 'org', Contact::ORG
   end
 
-  def test_invalid_without_email
-    @contact.email = ''
-    assert @contact.invalid?
+  def test_invalid_without_name
+    contact = valid_contact
+    contact.name = ''
+    assert contact.invalid?
   end
 
-  def test_email_format_validation
-    @contact.email = 'invalid'
-    assert @contact.invalid?
+  def test_validates_code_format
+    contact = valid_contact.dup
+    max_length = 100
 
-    @contact.email = 'test@bestmail.test'
-    assert @contact.valid?
+    contact.code = '!invalid'
+    assert contact.invalid?
+
+    contact.code = 'a' * max_length.next
+    assert contact.invalid?
+
+    contact.code = 'foo:bar'
+    assert contact.valid?
+
+    contact.code = 'a' * max_length
+    assert contact.valid?
+  end
+
+  def test_invalid_when_code_is_already_taken
+    another_contact = valid_contact
+    contact = another_contact.dup
+
+    contact.code = another_contact.code
+    assert contact.invalid?
+
+    contact.regenerate_code
+    assert contact.valid?
+  end
+
+  def test_invalid_without_email
+    contact = valid_contact
+    contact.email = ''
+    assert contact.invalid?
+  end
+
+  def test_email_verification_valid
+    contact = valid_contact
+    contact.email = 'info@internet.ee'
+    assert contact.valid?
+  end
+
+  def test_email_verification_smtp_error
+    Truemail.configure.default_validation_type = :smtp
+
+    contact = valid_contact
+    contact.email = 'somecrude1337joke@internet.ee'
+    assert contact.invalid?
+    assert_equal I18n.t('activerecord.errors.models.contact.attributes.email.email_smtp_check_error'), contact.errors.messages[:email].first
+ end
+
+  def test_email_verification_mx_error
+    Truemail.configure.default_validation_type = :mx
+
+    contact = valid_contact
+    contact.email = 'somecrude31337joke@somestrange31337domain.ee'
+    assert contact.invalid?
+    assert_equal I18n.t('activerecord.errors.models.contact.attributes.email.email_mx_check_error'), contact.errors.messages[:email].first
+  end
+
+  def test_email_verification_regex_error
+    Truemail.configure.default_validation_type = :regex
+
+    contact = valid_contact
+    contact.email = 'some@strangesentence@internet.ee'
+    assert contact.invalid?
+    assert_equal I18n.t('activerecord.errors.models.contact.attributes.email.email_regex_check_error'), contact.errors.messages[:email].first
   end
 
   def test_invalid_without_phone
-    @contact.email = ''
-    assert @contact.invalid?
+    contact = valid_contact
+    contact.phone = ''
+    assert contact.invalid?
   end
 
-  def test_phone_format_validation
-    @contact.phone = '+123.'
-    assert @contact.invalid?
+  # https://en.wikipedia.org/wiki/E.164
+  def test_validates_phone_format
+    contact = valid_contact
 
-    @contact.phone = '+123.4'
-    assert @contact.valid?
+    contact.phone = '+.1'
+    assert contact.invalid?
+
+    contact.phone = '+123.'
+    assert contact.invalid?
+
+    contact.phone = '+1.123456789123456'
+    assert contact.invalid?
+
+    contact.phone = '+134.1234567891234'
+    assert contact.invalid?
+
+    contact.phone = '+000.1'
+    assert contact.invalid?
+
+    contact.phone = '+123.0'
+    assert contact.invalid?
+
+    contact.phone = '+1.2'
+    assert contact.valid?
+
+    contact.phone = '+123.4'
+    assert contact.valid?
+
+    contact.phone = '+1.12345678912345'
+    assert contact.valid?
+
+    contact.phone = '+134.123456789123'
+    assert contact.valid?
+  end
+
+  def test_valid_without_address_when_address_processing_id_disabled
+    contact = valid_contact
+
+    contact.street = ''
+    contact.city = ''
+    contact.zip = ''
+    contact.country_code = ''
+
+    assert contact.valid?
   end
 
   def test_address
+    Setting.address_processing = true
+
     address = Contact::Address.new('new street', '83746', 'new city', 'new state', 'EE')
     @contact.address = address
     @contact.save!
@@ -74,13 +180,12 @@ class ContactTest < ActiveSupport::TestCase
   end
 
   def test_returns_registrant_user_indirect_contacts
-    @contact.update!(ident_type: Contact::ORG)
-    assert_equal '1234', @contact.ident
+    @contact.update!(ident_type: Contact::ORG, ident: '1234321')
     assert_equal 'US', @contact.ident_country_code
-    registrant_user = RegistrantUser.new(registrant_ident: 'US-1234')
+    registrant_user = RegistrantUser.new(registrant_ident: 'US-1234321')
 
-    registrant_user.stub(:companies, [OpenStruct.new(registration_number: '1234')]) do
-      assert_equal [@contact], Contact.registrant_user_contacts(registrant_user)
+    registrant_user.stub(:companies, [OpenStruct.new(registration_number: '1234321')]) do
+      assert_equal registrant_user.contacts, Contact.registrant_user_contacts(registrant_user)
     end
   end
 
@@ -93,15 +198,15 @@ class ContactTest < ActiveSupport::TestCase
   end
 
   def test_linked_when_in_use_as_registrant
-    Domain.update_all(registrant_id: @contact)
+    Domain.update_all(registrant_id: @contact.id)
     DomainContact.delete_all
 
     assert @contact.linked?
   end
 
   def test_linked_when_in_use_as_domain_contact
-    Domain.update_all(registrant_id: contacts(:william))
-    DomainContact.update_all(contact_id: @contact)
+    Domain.update_all(registrant_id: contacts(:william).id)
+    DomainContact.first.update(contact_id: @contact.id)
 
     assert @contact.linked?
   end
@@ -179,21 +284,83 @@ class ContactTest < ActiveSupport::TestCase
     assert Contact.unlinked.exclude?(contact), 'Contact should be excluded'
   end
 
+  def test_normalizes_country_code
+    Setting.address_processing = true
+    contact = Contact.new(country_code: 'us')
+    contact.validate
+    assert_equal 'US', contact.country_code
+  end
+
+  def test_normalizes_ident_country_code
+    contact = Contact.new(ident_country_code: 'us')
+    contact.validate
+    assert_equal 'US', contact.ident_country_code
+  end
+
+  def test_generates_code
+    contact = Contact.new(registrar: registrars(:bestnames))
+    assert_nil contact.code
+
+    contact.generate_code
+
+    assert_not_empty contact.code
+  end
+
+  def test_prohibits_code_change
+    assert_no_changes -> { @contact.code } do
+      @contact.code = 'new'
+      @contact.save!
+      @contact.reload
+    end
+  end
+
+  def test_removes_duplicate_statuses
+    contact = Contact.new(statuses: %w[ok ok])
+    assert_equal %w[ok], contact.statuses
+  end
+
+  def test_default_status
+    contact = Contact.new
+    assert_equal %w[ok], contact.statuses
+  end
+
+  def test_whois_gets_updated_after_contact_save
+    @contact.name = 'SomeReallyWeirdRandomTestName'
+    domain = @contact.registrant_domains.first
+
+    @contact.save!
+
+    assert_equal domain.whois_record.try(:json).try(:[], 'registrant'), @contact.name
+  end
+
+  def test_creates_email_verification_in_unicode
+    unicode_email = 'suur@äri.ee'
+    punycode_email = Contact.unicode_to_punycode(unicode_email)
+
+    @contact.email = punycode_email
+    @contact.save
+
+    assert_equal @contact.email_verification.email, unicode_email
+  end
+
   private
 
   def make_contact_free_of_domains_where_it_acts_as_a_registrant(contact)
     other_contact = contacts(:william)
     assert_not_equal other_contact, contact
-    Domain.update_all(registrant_id: other_contact)
+    Domain.update_all(registrant_id: other_contact.id)
   end
 
   def unlinked_contact
     other_contact = contacts(:william)
     assert_not_equal @contact, other_contact
-    Domain.update_all(registrant_id: other_contact)
-
+    Domain.update_all(registrant_id: other_contact.id)
     DomainContact.delete_all
 
     @contact
   end
-end
+
+  def valid_contact
+    contacts(:john)
+  end
+end