Fix code climate offences

#569
This commit is contained in:
Artur Beljajev 2017-09-04 10:57:27 +03:00
parent dbf5c8b4aa
commit 7147144894
8 changed files with 38 additions and 18 deletions

View file

@ -219,7 +219,7 @@ RSpec.describe 'EPP contact:create' do
before do
mismatches = [
Contact::Ident::Mismatch.new('priv', Country.new('DE')),
Contact::Ident::Mismatch.new('priv', Country.new('DE'))
]
allow(Contact::Ident).to receive(:mismatches).and_return(mismatches)
end

View file

@ -37,15 +37,24 @@ RSpec.describe 'EPP contact:update' do
let!(:contact) { create(:contact, code: 'TEST', ident: 'test', ident_type: 'priv', ident_country_code: 'US') }
it 'does not update code' do
expect { request; contact.reload }.to_not change { ident.code }
expect do
request
contact.reload
end.to_not change { ident.code }
end
it 'does not update type' do
expect { request; contact.reload }.to_not change { ident.type }
expect do
request
contact.reload
end.to_not change { ident.type }
end
it 'does not update country code' do
expect { request; contact.reload }.to_not change { ident.country_code }
expect do
request
contact.reload
end.to_not change { ident.country_code }
end
specify do
@ -90,7 +99,10 @@ RSpec.describe 'EPP contact:update' do
}
it 'does not update code' do
expect { request; contact.reload }.to_not change { ident.code }
expect do
request
contact.reload
end.to_not change { ident.code }
end
it 'updates type' do
@ -137,15 +149,24 @@ RSpec.describe 'EPP contact:update' do
}
it 'does not update code' do
expect { request; contact.reload }.to_not change { ident.code }
expect do
request
contact.reload
end.to_not change { ident.code }
end
it 'does not update type' do
expect { request; contact.reload }.to_not change { ident.type }
expect do
request
contact.reload
end.to_not change { ident.type }
end
it 'does not update country code' do
expect { request; contact.reload }.to_not change { ident.country_code }
expect do
request
contact.reload
end.to_not change { ident.country_code }
end
specify do