Merge pull request #1450 from internetee/1415-improve-bank-proceeeds-autocheck

Add autocheck by reference number in field or in description
This commit is contained in:
Timo Võhmar 2020-01-23 15:58:23 +02:00 committed by GitHub
commit 704c331f03
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 30 additions and 22 deletions

View file

@ -1,5 +1,5 @@
one:
sum: 1
currency: EUR
description: Order nr. 1
iban: US75512108001245126199
description: Order nr 1 from registrar 1234567 second number 2345678
iban: US75512108001245126199

View file

@ -22,4 +22,5 @@ one:
vat_rate: 0.1
total: 16.50
reference_no: 13
number: 1
number: 1
description: Order nr 1 from registrar 1234567 second number 2345678

View file

@ -28,7 +28,7 @@ class PaymentCallbackTest < ApplicationIntegrationTest
def assert_matching_bank_transaction_exists(invoice)
assert BankTransaction.find_by(
description: invoice.order,
description: invoice.description,
currency: invoice.currency,
iban: invoice.seller_iban
), 'Matching bank transaction should exist'
@ -56,4 +56,4 @@ class PaymentCallbackTest < ApplicationIntegrationTest
payment_method: "every_pay"
}
end
end
end

View file

@ -6,9 +6,20 @@ class BankTransactionTest < ActiveSupport::TestCase
@invoice = invoices(:one)
end
def test_matches_against_invoice_number_and_reference_number
create_payable_invoice(number: '2222', total: 10, reference_no: '1111')
transaction = BankTransaction.new(description: 'invoice #2222', sum: 10, reference_no: '1111')
def test_matches_against_invoice_nubmber_and_reference_number
create_payable_invoice(number: '2222', total: 10, reference_no: '1234567')
transaction = BankTransaction.new(description: 'invoice #2222', sum: 10, reference_no: '1234567')
assert_difference 'AccountActivity.count' do
transaction.autobind_invoice
end
end
def test_matches_against_invoice_nubmber_and_reference_number_in_description
create_payable_invoice(number: '2222', total: 10, reference_no: '1234567')
transaction = BankTransaction.new(description: 'invoice #2222',
sum: 10,
description: 'Order nr 1 from registrar 1234567 second number 2345678')
assert_difference 'AccountActivity.count' do
transaction.autobind_invoice