diff --git a/spec/factories/bank_statement.rb b/spec/factories/bank_statement.rb deleted file mode 100644 index fa4865496..000000000 --- a/spec/factories/bank_statement.rb +++ /dev/null @@ -1,11 +0,0 @@ -FactoryBot.define do - factory :bank_statement do - bank_code { '767' } - iban { 'EE557700771000598731' } - queried_at { Time.zone.now } - - after :build do |bank_statement| - bank_statement.bank_transactions << FactoryBot.create_pair(:bank_transaction) - end - end -end diff --git a/spec/models/bank_statement_spec.rb b/spec/models/bank_statement_spec.rb index d1d54d01f..f31749ba2 100644 --- a/spec/models/bank_statement_spec.rb +++ b/spec/models/bank_statement_spec.rb @@ -6,14 +6,6 @@ describe BankStatement do @bank_statement = BankStatement.new end - it 'should not be valid' do - @bank_statement.valid? - @bank_statement.errors.full_messages.should match_array([ - "Bank code is missing", - "Iban is missing" - ]) - end - it 'should not have any versions' do @bank_statement.versions.should == [] end @@ -24,17 +16,6 @@ describe BankStatement do @bank_statement = create(:bank_statement) end - it 'should be valid' do - @bank_statement.valid? - @bank_statement.errors.full_messages.should match_array([]) - end - - it 'should be valid twice' do - @bank_statement = create(:bank_statement) - @bank_statement.valid? - @bank_statement.errors.full_messages.should match_array([]) - end - it 'should not bind transactions with invalid match data' do r = create(:registrar, reference_no: '1234') diff --git a/test/fixtures/bank_statements.yml b/test/fixtures/bank_statements.yml new file mode 100644 index 000000000..36ed23cf1 --- /dev/null +++ b/test/fixtures/bank_statements.yml @@ -0,0 +1,3 @@ +one: + bank_code: '1234' + iban: GB33BUKB20201555555555 \ No newline at end of file diff --git a/test/models/bank_statement_test.rb b/test/models/bank_statement_test.rb new file mode 100644 index 000000000..ff08a8bf8 --- /dev/null +++ b/test/models/bank_statement_test.rb @@ -0,0 +1,25 @@ +require 'test_helper' + +class BankStatementTest < ActiveSupport::TestCase + def test_valid_bank_statement_fixture_is_valid + assert valid_bank_statement.valid?, proc { valid_bank_statement.errors.full_messages } + end + + def test_invalid_without_bank_code + bank_statement = valid_bank_statement + bank_statement.bank_code = '' + assert bank_statement.invalid? + end + + def test_invalid_without_iban + bank_statement = valid_bank_statement + bank_statement.iban = '' + assert bank_statement.invalid? + end + + private + + def valid_bank_statement + bank_statements(:one) + end +end \ No newline at end of file