zydronium/internetee-registry
1
0
Fork 0
mirror of https://github.com/internetee/registry.git synced 2025-08-04 00:42:04 +02:00
Code Issues Projects Releases Packages Wiki Activity

Removed ridiculous has/get_relation from contact

Browse source
This commit is contained in:
Andres Keskküla 2014-08-22 13:17:58 +03:00
parent 3c79ca33b8
commit 6d15739f8a
2 changed files with 19 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

17
app/models/contact.rb
View file

@ -70,25 +70,16 @@ class Contact < ActiveRecord::Base
Domain.find_by(owner_contact_id: id)
end
#TODO Refactor the relation methods to something more sensible
def get_relation( model = :domain_contacts )
send(model)
rescue NoMethodError => e
nil
end
def has_relation( model = :domain_contacts )
relation = get_relation(model)
return true unless relation.nil? || relation.blank?
false
def relations_with_domain?
return true if domain_contacts.present? || domains_owned.present?
return false
end
#should use only in transaction
def destroy_and_clean
clean_up_address
if has_relation(:domain_contacts) || domains_owned.present?
#errors.add(:contact, msg: I18n.t('errors.messages.epp_obj_association_error'), value: { obj: 'contact', val: code })
if relations_with_domain?
errors.add(:domains, :exist)
return false
end