From 6c655e11790f2089504ece347e00096e3fea1bc8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Karl=20Erik=20=C3=95unapuu?= <karlerik@kreative.ee>
Date: Wed, 14 Oct 2020 10:58:51 +0300
Subject: [PATCH] REPP: Move Domains#Contacts to rails API format

---
 app/api/repp/domain_contacts_v1.rb            | 47 -------------------
 .../repp/v1/domains/contacts_controller.rb    | 39 +++++++++++++++
 config/routes.rb                              |  7 +++
 3 files changed, 46 insertions(+), 47 deletions(-)
 delete mode 100644 app/api/repp/domain_contacts_v1.rb
 create mode 100644 app/controllers/repp/v1/domains/contacts_controller.rb

diff --git a/app/api/repp/domain_contacts_v1.rb b/app/api/repp/domain_contacts_v1.rb
deleted file mode 100644
index 7f3e323ac..000000000
--- a/app/api/repp/domain_contacts_v1.rb
+++ /dev/null
@@ -1,47 +0,0 @@
-module Repp
-  class DomainContactsV1 < Grape::API
-    version 'v1', using: :path
-
-    resource :domains do
-      resource :contacts do
-        patch '/' do
-          current_contact = current_user.registrar.contacts
-                                .find_by(code: params[:current_contact_id])
-          new_contact = current_user.registrar.contacts.find_by(code: params[:new_contact_id])
-
-          unless current_contact
-            error!({ error: { type: 'invalid_request_error',
-                              param: 'current_contact_id',
-                              message: "No such contact: #{params[:current_contact_id]}"} },
-                   :bad_request)
-          end
-
-          unless new_contact
-            error!({ error: { type: 'invalid_request_error',
-                              param: 'new_contact_id',
-                              message: "No such contact: #{params[:new_contact_id]}" } },
-                   :bad_request)
-          end
-
-          if new_contact.invalid?
-            error!({ error: { type: 'invalid_request_error',
-                              param: 'new_contact_id',
-                              message: 'New contact must be valid' } },
-                   :bad_request)
-          end
-
-          if current_contact == new_contact
-            error!({ error: { type: 'invalid_request_error',
-                              message: 'New contact ID must be different from current' \
-                                ' contact ID' } },
-                   :bad_request)
-          end
-
-          affected_domains, skipped_domains = TechDomainContact
-                                                  .replace(current_contact, new_contact)
-          @response = { affected_domains: affected_domains, skipped_domains: skipped_domains }
-        end
-      end
-    end
-  end
-end
diff --git a/app/controllers/repp/v1/domains/contacts_controller.rb b/app/controllers/repp/v1/domains/contacts_controller.rb
new file mode 100644
index 000000000..226981b60
--- /dev/null
+++ b/app/controllers/repp/v1/domains/contacts_controller.rb
@@ -0,0 +1,39 @@
+module Repp
+  module V1
+    module Domains
+      class ContactsController < BaseController
+        before_action :set_current_contact, only: [:update]
+        before_action :set_new_contact, only: [:update]
+
+        def set_current_contact
+          @current_contact = current_user.registrar.contacts.find_by!(
+            code: params[:current_contact_id]
+          )
+        end
+
+        def set_new_contact
+          @new_contact = current_user.registrar.contacts.find_by!(code: params[:new_contact_id])
+        end
+
+        def update
+          @epp_errors << { code: '2304', msg: 'New contact must be valid' } if @new_contact.invalid?
+
+          if @new_contact == @current_contact
+            @epp_errors << { code: '2304', msg: 'New contact must be different from current' }
+          end
+
+          affected, skipped = TechDomainContact.replace(@current_contact, @new_contact)
+          data = { affected_domains: affected, skipped_domains: skipped }
+          render_success(data: data)
+        end
+
+        private
+
+        def contact_params
+          params.require(%i[current_contact_id new_contact_id])
+          params.permit(:current_contact_id, :new_contact_id)
+        end
+      end
+    end
+  end
+end
diff --git a/config/routes.rb b/config/routes.rb
index 1003a75ce..f1557a659 100644
--- a/config/routes.rb
+++ b/config/routes.rb
@@ -59,6 +59,13 @@ Rails.application.routes.draw do
           end
         end
       end
+      namespace :domains do
+        resources :contacts do
+          collection do
+            patch '/', to: 'contacts#update'
+          end
+        end
+      end
     end
   end