From 6c1342c9577e337c379073311d6bef14dfb4ca4f Mon Sep 17 00:00:00 2001
From: Artur Beljajev <artur.beljajev@internet.ee>
Date: Thu, 15 Feb 2018 17:46:09 +0200
Subject: [PATCH] Bypass validation on EPP domain:delete

#707
---
 app/models/epp/domain.rb                      |  2 --
 test/fixtures/contacts.yml                    |  1 +
 test/fixtures/domain_contacts.yml             | 10 +++++++
 test/fixtures/domains.yml                     |  6 +++++
 .../epp/domain/domain_delete_test.rb          | 27 +++++++++++++++++++
 test/models/domain/domain_test.rb             |  4 +++
 6 files changed, 48 insertions(+), 2 deletions(-)
 create mode 100644 test/integration/epp/domain/domain_delete_test.rb

diff --git a/app/models/epp/domain.rb b/app/models/epp/domain.rb
index 969d9a9bc..a59094d1e 100644
--- a/app/models/epp/domain.rb
+++ b/app/models/epp/domain.rb
@@ -556,8 +556,6 @@ class Epp::Domain < Domain
   end
 
   def epp_destroy(frame, user_id)
-    return false unless valid?
-
     check_discarded
 
     if doc = attach_legal_document(Epp::Domain.parse_legal_document_from_frame(frame))
diff --git a/test/fixtures/contacts.yml b/test/fixtures/contacts.yml
index 2a9898543..8c0fb4e10 100644
--- a/test/fixtures/contacts.yml
+++ b/test/fixtures/contacts.yml
@@ -34,5 +34,6 @@ acme_ltd:
 invalid:
   name: any
   code: any
+  email: invalid@invalid.test
   auth_info: any
   registrar: bestnames
diff --git a/test/fixtures/domain_contacts.yml b/test/fixtures/domain_contacts.yml
index 8a429f628..fd60e8c99 100644
--- a/test/fixtures/domain_contacts.yml
+++ b/test/fixtures/domain_contacts.yml
@@ -12,3 +12,13 @@ library_john:
   domain: library
   contact: john
   type: AdminDomainContact
+
+invalid_invalid_admin:
+  domain: invalid
+  contact: invalid
+  type: AdminDomainContact
+
+invalid_invalid_tech:
+  domain: invalid
+  contact: invalid
+  type: TechDomainContact
diff --git a/test/fixtures/domains.yml b/test/fixtures/domains.yml
index 7c7b429cf..a7ed8e337 100644
--- a/test/fixtures/domains.yml
+++ b/test/fixtures/domains.yml
@@ -27,3 +27,9 @@ library:
   valid_to: 2010-07-05
   period: 1
   period_unit: m
+
+invalid:
+  name: invalid.test
+  transfer_code: any
+  registrar: bestnames
+  registrant: invalid
diff --git a/test/integration/epp/domain/domain_delete_test.rb b/test/integration/epp/domain/domain_delete_test.rb
new file mode 100644
index 000000000..212ec589a
--- /dev/null
+++ b/test/integration/epp/domain/domain_delete_test.rb
@@ -0,0 +1,27 @@
+require 'test_helper'
+
+class EppDomainDeleteTest < ActionDispatch::IntegrationTest
+  def test_bypasses_domain_and_registrant_and_contacts_validation
+    request_xml = <<-XML
+      <?xml version="1.0" encoding="UTF-8" standalone="no"?>
+      <epp xmlns="https://epp.tld.ee/schema/epp-ee-1.0.xsd">
+        <command>
+          <delete>
+            <domain:delete xmlns:domain="https://epp.tld.ee/schema/domain-eis-1.0.xsd">
+              <domain:name>invalid.test</domain:name>
+            </domain:delete>
+          </delete>
+          <extension>
+            <eis:extdata xmlns:eis="https://epp.tld.ee/schema/eis-1.0.xsd">
+              <eis:legalDocument type="pdf">dGVzdCBmYWlsCg==</eis:legalDocument>
+            </eis:extdata>
+          </extension>
+        </command>
+      </epp>
+    XML
+
+    post '/epp/command/delete', { frame: request_xml }, { 'HTTP_COOKIE' => 'session=api_bestnames' }
+    assert_equal '1001', Nokogiri::XML(response.body).at_css('result')[:code]
+    assert_equal 1, Nokogiri::XML(response.body).css('result').size
+  end
+end
diff --git a/test/models/domain/domain_test.rb b/test/models/domain/domain_test.rb
index 562e8e3e9..b022fd35b 100644
--- a/test/models/domain/domain_test.rb
+++ b/test/models/domain/domain_test.rb
@@ -8,4 +8,8 @@ class DomainTest < ActiveSupport::TestCase
   def test_valid_fixture
     assert @domain.valid?
   end
+
+  def test_invalid_fixture
+    assert domains(:invalid).invalid?
+  end
 end