From 6b6a41ae203f65501f02a9f95458e6abaff913fc Mon Sep 17 00:00:00 2001 From: Oleg Hasjanov Date: Mon, 5 Jul 2021 16:31:44 +0300 Subject: [PATCH] move constants to methods --- .../collect_invalid_validation_business_contacts.rake | 11 ++++++++--- lib/tasks/scan_csv_registry_business_contacts.rake | 10 +++++++--- 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/lib/tasks/collect_invalid_validation_business_contacts.rake b/lib/tasks/collect_invalid_validation_business_contacts.rake index db3c6f428..139f6bc24 100644 --- a/lib/tasks/collect_invalid_validation_business_contacts.rake +++ b/lib/tasks/collect_invalid_validation_business_contacts.rake @@ -1,10 +1,8 @@ -HEADERS = %w[domain id name code registrar].freeze - namespace :contacts do desc 'Starts collect invalid validation contacts' task scan_org: :environment do csv = CSV.open('invalid_business_contacts.csv', 'w') - csv << HEADERS + csv << set_headers Contact.where(ident_type: 'org').find_in_batches do |contact_group| contact_group.each do |contact| @@ -17,9 +15,16 @@ namespace :contacts do end end end + csv.close end end +private + +def set_headers + %w[domain id name code registrar] +end + def checking_contacts(contact) return true unless contact.ident_country_code == 'EE' diff --git a/lib/tasks/scan_csv_registry_business_contacts.rake b/lib/tasks/scan_csv_registry_business_contacts.rake index c95eb446f..cf6364e1c 100644 --- a/lib/tasks/scan_csv_registry_business_contacts.rake +++ b/lib/tasks/scan_csv_registry_business_contacts.rake @@ -1,9 +1,13 @@ -FILE_NAME = './ettevotja_rekvisiidid_init.csv'.freeze - namespace :collect_csv_data do desc 'Import from csv registry business contact into BusinessRegistryContact model' task business_contacts: :environment do - ScanCsvRegistryBusinnesContactsJob.perform_later(FILE_NAME) + ScanCsvRegistryBusinnesContactsJob.perform_later(filename) + end + + private + + def filename + './ettevotja_rekvisiidid_init.csv' end end