zydronium/internetee-registry
1
0
Fork 0
mirror of https://github.com/internetee/registry.git synced 2025-08-12 12:39:34 +02:00
Code Issues Projects Releases Packages Wiki Activity

Compare domains instead of strings

Browse source 
Fixes #1291
This commit is contained in:
Artur Beljajev 2019-09-09 14:32:43 +03:00
parent a0212490d4
commit 6aa25456f5
2 changed files with 9 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/models/nameserver.rb
View file

@ -81,7 +81,7 @@ class Nameserver < ActiveRecord::Base
def glue_record_required? def glue_record_required?
return unless hostname? && domain return unless hostname? && domain
hostname.end_with?(domain.name) DomainName(hostname).domain == domain.name
end end
def normalize_attributes def normalize_attributes

8
test/models/nameserver/glue_record_test.rb
View file

@ -24,4 +24,12 @@ class NameserverGlueRecordTest < ActiveSupport::TestCase
@nameserver.ipv4 = @nameserver.ipv6 = '' @nameserver.ipv4 = @nameserver.ipv6 = ''
assert @nameserver.valid? assert @nameserver.valid?
end end
def test_valid_without_ip_when_glue_record_is_not_required
domain = Domain.new(name: 'le.test')
nameserver = Nameserver.new(domain: domain, hostname: 'ns1.example.test')
nameserver.ipv4 = nameserver.ipv6 = nil
assert nameserver.valid?
end
end end