Merge branch 'master' of github.com:internetee/registry

spec/epp/contact_spec.rb

@@ -6,8 +6,8 @@ describe 'EPP Contact', epp: true do
   context 'with valid user' do
     before(:each) { Fabricate(:epp_user) }
 
-    #Tests for the new error system
+    context 'create command' do
-    it "doesn't create contact if request is invalid" do
+      it "fails if request is invalid" do
         response = epp_request(contact_create_xml( { authInfo: [false], addr: { cc: false, city: false } }  ), :xml)
 
         expect(response[:results][0][:result_code]).to eq('2003')
@@ -20,41 +20,7 @@ describe 'EPP Contact', epp: true do
         expect(response[:results].count).to eq 3
       end
 
-    it "doesn't update contact if request is invalid" do
+      it 'successfully creates a contact' do
-      response = epp_request('contacts/update_missing_attr.xml')
-
-      expect(response[:results][0][:result_code]).to eq('2003')
-      expect(response[:results][0][:msg]).to eq('Required parameter missing: id')
-      expect(response[:results].count).to eq 1
-    end
-
-    it "doesn't delete contact if request is invalid" do
-      response = epp_request('contacts/delete_missing_attr.xml')
-
-      expect(response[:results][0][:result_code]).to eq('2003')
-      expect(response[:results][0][:msg]).to eq('Required parameter missing: id')
-      expect(response[:results].count).to eq 1
-    end
-
-    it "doesn't check contact if request is invalid" do
-      response = epp_request(contact_check_xml( ids: [ false ] ), :xml)
-
-      expect(response[:results][0][:result_code]).to eq('2003')
-      expect(response[:results][0][:msg]).to eq('Required parameter missing: id')
-      expect(response[:results].count).to eq 1
-    end
-
-    it "doesn't display info if request invalid" do
-      response = epp_request('contacts/delete_missing_attr.xml')
-
-      expect(response[:results][0][:result_code]).to eq('2003')
-      expect(response[:results][0][:msg]).to eq('Required parameter missing: id')
-      expect(response[:results].count).to eq 1
-    end
-
-
-    # incomplete
-    it 'creates a contact' do
         response = epp_request(contact_create_xml, :xml)
 
         expect(response[:result_code]).to eq('1000')
@@ -72,7 +38,7 @@ describe 'EPP Contact', epp: true do
 
       end
 
-    it 'returns result data upon succesful contact creation' do
+      it 'returns result data upon success' do
         response = epp_request(contact_create_xml, :xml)
 
         expect(response[:result_code]).to eq('1000')
@@ -97,6 +63,17 @@ describe 'EPP Contact', epp: true do
         
         expect(Contact.count).to eq(1)
       end
+    end
+
+
+    context 'update command' do
+      it "fails if request is invalid" do
+        response = epp_request('contacts/update_missing_attr.xml')
+  
+        expect(response[:results][0][:result_code]).to eq('2003')
+        expect(response[:results][0][:msg]).to eq('Required parameter missing: id')
+        expect(response[:results].count).to eq 1
+      end
   
       it 'stamps updated_by succesfully' do
         Fabricate(:contact, code: 'sh8013')
@@ -108,7 +85,34 @@ describe 'EPP Contact', epp: true do
         expect(Contact.first.updated_by_id).to eq 1
       end
   
-   #TODO tests for missing/invalid/etc ident
+      it 'is succesful' do
+        Fabricate(:contact, created_by_id: 1, email: 'not_updated@test.test', code: 'sh8013')
+        response = epp_request('contacts/update.xml')
+        expect(response[:msg]).to eq('Command completed successfully')
+        expect(Contact.first.name).to eq('John Doe')
+        expect(Contact.first.email).to eq('jdoe@example.com')
+      end
+  
+      it 'returns phone and email error' do 
+        Fabricate(:contact, created_by_id: 1, email: 'not_updated@test.test', code: 'sh8013')
+        response = epp_request('contacts/update_with_errors.xml')
+  
+        expect(response[:results][0][:result_code]).to eq('2005')
+        expect(response[:results][0][:msg]).to eq('Phone nr is invalid')
+  
+        expect(response[:results][1][:result_code]).to eq('2005')
+        expect(response[:results][1][:msg]).to eq('Email is invalid')
+      end
+    end 
+
+    context 'delete command' do
+      it "fails if request is invalid" do
+        response = epp_request('contacts/delete_missing_attr.xml')
+
+        expect(response[:results][0][:result_code]).to eq('2003')
+        expect(response[:results][0][:msg]).to eq('Required parameter missing: id')
+        expect(response[:results].count).to eq 1
+      end
 
       it 'deletes contact' do
         Fabricate(:contact, code: "dwa1234")
@@ -120,13 +124,24 @@ describe 'EPP Contact', epp: true do
         expect(Contact.count).to eq(0)
       end
 
-    it 'deletes an nil object' do
+      it 'returns error if obj doesnt exist' do
         response = epp_request('contacts/delete.xml')
         expect(response[:result_code]).to eq('2303')
         expect(response[:msg]).to eq('Object does not exist')
       end
+    end
 
-    it 'checks contacts' do
+
+    context 'check command' do
+      it "fails if request is invalid" do
+        response = epp_request(contact_check_xml( ids: [ false ] ), :xml)
+
+        expect(response[:results][0][:result_code]).to eq('2003')
+        expect(response[:results][0][:msg]).to eq('Required parameter missing: id')
+        expect(response[:results].count).to eq 1
+      end
+
+      it 'returns info about contact' do
         Fabricate(:contact, code: 'check-1234')
         
         response = epp_request(contact_check_xml( ids: [{ id: 'check-1234'}, { id: 'check-4321' }]  ), :xml)
@@ -140,7 +155,16 @@ describe 'EPP Contact', epp: true do
 
         expect(ids[0].text).to eq('check-1234')
         expect(ids[1].text).to eq('check-4321')
+      end
+    end
  
+    context 'info command' do
+      it "fails if request invalid" do
+        response = epp_request('contacts/delete_missing_attr.xml')
+
+        expect(response[:results][0][:result_code]).to eq('2003')
+        expect(response[:results][0][:msg]).to eq('Required parameter missing: id')
+        expect(response[:results].count).to eq 1
       end
 
       it 'returns error when object does not exist' do
@@ -163,7 +187,7 @@ describe 'EPP Contact', epp: true do
 
       end
 
-    it 'it doesn\'t display unassociated object' do
+      it 'doesn\'t display unassociated object' do
         Fabricate(:contact, name:"Johnny Awesome", created_by_id: '240', code: 'info-4444')
         Fabricate(:epp_user, id: 240)
 
@@ -171,24 +195,6 @@ describe 'EPP Contact', epp: true do
         expect(response[:result_code]).to eq('2201')
         expect(response[:msg]).to eq('Authorization error')
       end
-
-    it 'updates contact succesfully' do
-      Fabricate(:contact, created_by_id: 1, email: 'not_updated@test.test', code: 'sh8013')
-      response = epp_request('contacts/update.xml')
-      expect(response[:msg]).to eq('Command completed successfully')
-      expect(Contact.first.name).to eq('John Doe')
-      expect(Contact.first.email).to eq('jdoe@example.com')
-    end
-
-    it 'returns phone and email error' do 
-      Fabricate(:contact, created_by_id: 1, email: 'not_updated@test.test', code: 'sh8013')
-      response = epp_request('contacts/update_with_errors.xml')
-
-      expect(response[:results][0][:result_code]).to eq('2005')
-      expect(response[:results][0][:msg]).to eq('Phone nr is invalid')
-
-      expect(response[:results][1][:result_code]).to eq('2005')
-      expect(response[:results][1][:msg]).to eq('Email is invalid')
     end
   end
 end