zydronium/internetee-registry
1
0
Fork 0
mirror of https://github.com/internetee/registry.git synced 2025-06-07 05:05:45 +02:00
Code Issues Projects Releases Packages Wiki Activity

Fix epp auth if registrant changed on disputed domain

Browse source
This commit is contained in:
Alex Sherman 2021-04-16 17:47:06 +05:00
parent 661ab8e0ac
commit 647413b9be
2 changed files with 46 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
app/interactions/actions/domain_update.rb
View file

@ -209,9 +209,9 @@ module Actions
end end
def verify_registrant_change? def verify_registrant_change?
return if !@changes_registrant || params[:registrant][:verified] == true
return true unless domain.disputed?
return validate_dispute_case if params[:reserved_pw] return validate_dispute_case if params[:reserved_pw]
return false if !@changes_registrant || params[:registrant][:verified] == true
return true unless domain.disputed?
domain.add_epp_error('2304', nil, nil, 'Required parameter missing; reservedpw element ' \ domain.add_epp_error('2304', nil, nil, 'Required parameter missing; reservedpw element ' \
'required for dispute domains') 'required for dispute domains')

46
test/integration/epp/domain/update/base_test.rb
View file

@ -301,7 +301,7 @@ class EppDomainUpdateBaseTest < EppTestCase
current = @domain.registrant current = @domain.registrant
new_registrant = contacts(:william) new_registrant = contacts(:william)
new_registrant.update( new_registrant.update(
ident: current.ident, ident: current.ident,
ident_type: current.ident_type, ident_type: current.ident_type,
ident_country_code: current.ident_country_code ident_country_code: current.ident_country_code
) )
@ -331,7 +331,7 @@ class EppDomainUpdateBaseTest < EppTestCase
headers: { 'HTTP_COOKIE' => 'session=api_bestnames' } headers: { 'HTTP_COOKIE' => 'session=api_bestnames' }
@domain.reload @domain.reload
# NOTE: completed_successfully_action_pending # NOTE: completed_successfully_action_pending
assert_epp_response :completed_successfully assert_epp_response :completed_successfully
refute_includes @domain.statuses, DomainStatus::PENDING_UPDATE refute_includes @domain.statuses, DomainStatus::PENDING_UPDATE
@ -414,6 +414,48 @@ class EppDomainUpdateBaseTest < EppTestCase
assert_no_emails assert_no_emails
end end
def test_dispute_password_mandatory_when_registrant_changed
Setting.request_confirmation_on_registrant_change_enabled = true
dispute = disputes(:expired)
dispute.update!(starts_at: Time.zone.now, expires_at: Time.zone.now + 5.days, closed: nil)
new_registrant = contacts(:william)
assert @domain.disputed?
request_xml = <<-XML
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<epp xmlns="https://epp.tld.ee/schema/epp-ee-1.0.xsd">
<command>
<update>
<domain:update xmlns:domain="https://epp.tld.ee/schema/domain-eis-1.0.xsd">
<domain:name>#{@domain.name}</domain:name>
<domain:chg>
<domain:registrant verified="yes">#{new_registrant.code}</domain:registrant>
</domain:chg>
</domain:update>
</update>
<extension>
<eis:extdata xmlns:eis="https://epp.tld.ee/schema/eis-1.0.xsd">
<eis:legalDocument type="pdf">#{'test' * 2000}</eis:legalDocument>
<eis:reserved>
<eis:pw>'123456'</eis:pw>
</eis:reserved>
</eis:extdata>
</extension>
</command>
</epp>
XML
post epp_update_path, params: { frame: request_xml },
headers: { 'HTTP_COOKIE' => 'session=api_bestnames' }
@domain.reload
assert_epp_response :invalid_authorization_information
assert_not_equal new_registrant, @domain.registrant
assert @domain.disputed?
assert_no_emails
end
def test_skips_verification_when_disabled def test_skips_verification_when_disabled
Setting.request_confirmation_on_registrant_change_enabled = false Setting.request_confirmation_on_registrant_change_enabled = false
new_registrant = contacts(:william).becomes(Registrant) new_registrant = contacts(:william).becomes(Registrant)