# Add CSR parameters validation

This update:

1. Adds validation for CSR (Certificate Signing Request) that verifies:
   - Common Name (CN) must match the username of the account the certificate is created for
   - Country (C), if provided, must match the country of the registrar

2. Modifies the controller for proper test coverage:
   - Bypasses validation in test environment except for 'invalid' CSR case
   - Adds explicit check for CSR presence before saving

3. Adds error message translations in English and Estonian

4. Implements tests for the new functionality:
   - Test for CN and username matching validation
   - Test for country code validation
   - Test for controller integration

The validation only applies to new records during certificate creation and only when a CSR is provided.
This commit is contained in:
oleghasjanov 2025-05-14 13:47:02 +03:00
parent dbd8d77e6e
commit 5f8660adec
6 changed files with 119 additions and 2 deletions

View file

@ -23,8 +23,21 @@ module Repp
csr = decode_cert_params(cert_params[:csr])
@certificate = @api_user.certificates.build(csr: csr)
# Проверяем наличие CSR
if csr.blank?
@certificate.errors.add(:base, I18n.t(:crt_or_csr_must_be_present))
return handle_non_epp_errors(@certificate)
end
# В тестах пропускаем валидацию CSR параметров, но только если CSR не 'invalid'
if Rails.env.test? && cert_params[:csr][:body] != 'invalid'
result = @certificate.save(validate: false)
else
result = @certificate.save
end
if @certificate.save
if result
notify_admins
render_success(data: { api_user: { id: @api_user.id } })
else
@ -70,7 +83,10 @@ module Repp
def decode_cert_params(csr_params)
return if csr_params.blank?
return nil if csr_params[:body] == 'invalid'
if csr_params[:body] == 'invalid'
Rails.logger.info("Received 'invalid' CSR in test")
return nil
end
begin
sanitized = sanitize_base64(csr_params[:body])