zydronium/internetee-registry
1
0
Fork 0
mirror of https://github.com/internetee/registry.git synced 2025-06-12 23:54:44 +02:00
Code Issues Projects Releases Packages Wiki Activity

REPP: Simplify Contacts#index method

Browse source
This commit is contained in:
Karl Erik Õunapuu 2020-10-12 14:07:41 +03:00
parent eb19412643
commit 5cd495b85c
No known key found for this signature in database
GPG key ID: C9DD647298A34764
1 changed files with 13 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

19
app/controllers/repp/v1/contacts_controller.rb
View file

@ -9,13 +9,9 @@ module Repp
offset = params[:offset] || 0 offset = params[:offset] || 0
record_count = current_user.registrar.contacts.count record_count = current_user.registrar.contacts.count
contacts = current_user.registrar.contacts.limit(limit).offset(offset) show_addresses = Contact.address_processing? && params[:details] == 'true'
contacts = showable_contacts(params[:details], limit, offset, show_addresses)
unless Contact.address_processing? && params[:details] == 'true'
contacts = contacts.select(Contact.attribute_names - Contact.address_attribute_names)
end
contacts = contacts.pluck(:code) unless params[:details]
resp = { contacts: contacts, total_number_of_records: record_count } resp = { contacts: contacts, total_number_of_records: record_count }
render(json: resp, status: :ok) render(json: resp, status: :ok)
end end
@ -63,6 +59,17 @@ module Repp
contact_addr_params[:addr].keys.any? contact_addr_params[:addr].keys.any?
end end
def showable_contacts(details, limit, offset, addresses)
contacts = current_user.registrar.contacts.limit(limit).offset(offset)
unless addresses
contacts = contacts.select(Contact.attribute_names - Contact.address_attribute_names)
end
contacts = contacts.pluck(:code) unless details
contacts
end
def opt_addr? def opt_addr?
!Contact.address_processing? && contact_addr_present? !Contact.address_processing? && contact_addr_present?
end end