From 5841883a15d325a5d8a0c02e362c1ada3f344ba8 Mon Sep 17 00:00:00 2001
From: Oleg Hasjanov <oleg.hasjanov@eestiinternet.ee>
Date: Thu, 4 Mar 2021 18:32:09 +0200
Subject: [PATCH] test: wrote tests for zone_test and domain_version, also
 remove useless test for job

---
 ...egistrant_change_expired_email_job_test.rb | 16 ----------
 test/models/dns/zone_test.rb                  |  4 ---
 .../system/admin_area/domain_versions_test.rb | 32 +++++++++++++++++++
 3 files changed, 32 insertions(+), 20 deletions(-)
 delete mode 100644 test/jobs/registrant_change_expired_email_job_test.rb

diff --git a/test/jobs/registrant_change_expired_email_job_test.rb b/test/jobs/registrant_change_expired_email_job_test.rb
deleted file mode 100644
index bd96bd034..000000000
--- a/test/jobs/registrant_change_expired_email_job_test.rb
+++ /dev/null
@@ -1,16 +0,0 @@
-require "test_helper"
-
-class RegistrantChangeExpiredEmailJobTest < ActiveSupport::TestCase
-  include ActionMailer::TestHelper
-
-  setup do
-    ActionMailer::Base.deliveries.clear
-    @domain = domains(:shop)
-  end
-
-  def test_delivers_email
-    # This job doesn't use anymore, but I'll leave it here for statistics
-    assert RegistrantChangeExpiredEmailJob.enqueue(@domain.id)
-    assert_emails 0
-  end
-end
\ No newline at end of file
diff --git a/test/models/dns/zone_test.rb b/test/models/dns/zone_test.rb
index b77669a25..fab4c6355 100644
--- a/test/models/dns/zone_test.rb
+++ b/test/models/dns/zone_test.rb
@@ -178,10 +178,6 @@ class DNS::ZoneTest < ActiveSupport::TestCase
     assert_nil Whois::Record.find_by(name: subzone.origin)
   end
 
-  def test_generate_zonefile
-    
-  end
-
   private
 
   def valid_zone
diff --git a/test/system/admin_area/domain_versions_test.rb b/test/system/admin_area/domain_versions_test.rb
index 8ff90a562..833398c61 100644
--- a/test/system/admin_area/domain_versions_test.rb
+++ b/test/system/admin_area/domain_versions_test.rb
@@ -5,6 +5,7 @@ class DomainVersionsTest < ApplicationSystemTestCase
     super
 
     @registrar = registrars(:bestnames)
+    @domain = domains(:shop)
 
     create_domain_with_history
     sign_in users(:admin)
@@ -59,4 +60,35 @@ class DomainVersionsTest < ApplicationSystemTestCase
     assert_text 'Best Names'
     assert_text '23.04.18, 18:50 update 1-AdminUser'
   end
+
+  def test_search_registrant_param
+    visit admin_domain_versions_path
+    fill_in 'Registrant', with: @domain.registrant, match: :first
+    find('.btn.btn-primary').click
+
+    assert_equal current_url,
+      'http://www.example.com/admin/domain_versions?q[name]=&q[registrant]=John&q[registrar]=&q[event]=&results_per_page='
+  end
+
+  def test_search_registrar_param
+    visit admin_domain_versions_path
+    find('#q_registrar').set(@domain.registrar)
+    find('.btn.btn-primary').click
+
+    assert_equal current_url,
+      'http://www.example.com/admin/domain_versions?q[name]=&q[registrant]=&q[registrar]=Best+Names&q[event]=&results_per_page='
+  end
+
+  def test_search_name_param
+    visit admin_domain_versions_path
+    fill_in 'Name', with: @domain.name, match: :first
+    find('.btn.btn-primary').click
+
+    assert_equal current_url,
+      'http://www.example.com/admin/domain_versions?q[name]=shop.test&q[registrant]=&q[registrar]=&q[event]=&results_per_page='
+  end
+
+  def test_search_event_param
+    # TODO
+  end
 end