Update tests

#660

test/integration/epp/domain/create/transfer_code_test.rb

@@ -0,0 +1,63 @@
+require 'test_helper'
+
+class EppDomainCreateTransferCodeTest < ActionDispatch::IntegrationTest
+  def setup
+    travel_to Time.zone.parse('2010-07-05')
+    login_as users(:api_bestnames)
+  end
+
+  def test_generates_default
+    request_xml = <<-XML
+      <?xml version="1.0" encoding="UTF-8" standalone="no"?>
+      <epp xmlns="https://epp.tld.ee/schema/epp-ee-1.0.xsd">
+        <command>
+          <create>
+            <domain:create xmlns:domain="https://epp.tld.ee/schema/domain-eis-1.0.xsd">
+              <domain:name>brandnew.test</domain:name>
+              <domain:period unit="y">1</domain:period>
+              <domain:registrant>john-001</domain:registrant>
+            </domain:create>
+          </create>
+          <extension>
+            <eis:extdata xmlns:eis="https://epp.tld.ee/schema/eis-1.0.xsd">
+              <eis:legalDocument type="pdf">#{'test' * 2000}</eis:legalDocument>
+            </eis:extdata>
+          </extension>
+        </command>
+      </epp>
+    XML
+
+    session_id = epp_sessions(:api_bestnames).session_id
+    post '/epp/command/create', { frame: request_xml }, { 'HTTP_COOKIE' => "session=#{session_id}" }
+    refute_empty Domain.find_by(name: 'brandnew.test').transfer_code
+  end
+
+  def test_honors_custom
+    request_xml = <<-XML
+      <?xml version="1.0" encoding="UTF-8" standalone="no"?>
+      <epp xmlns="https://epp.tld.ee/schema/epp-ee-1.0.xsd">
+        <command>
+          <create>
+            <domain:create xmlns:domain="https://epp.tld.ee/schema/domain-eis-1.0.xsd">
+              <domain:name>brandnew.test</domain:name>
+              <domain:period unit="y">1</domain:period>
+              <domain:registrant>john-001</domain:registrant>
+              <domain:authInfo>
+                <domain:pw>1058ad73</domain:pw>
+              </domain:authInfo>
+            </domain:create>
+          </create>
+          <extension>
+            <eis:extdata xmlns:eis="https://epp.tld.ee/schema/eis-1.0.xsd">
+              <eis:legalDocument type="pdf">#{'test' * 2000}</eis:legalDocument>
+            </eis:extdata>
+          </extension>
+        </command>
+      </epp>
+    XML
+
+    session_id = epp_sessions(:api_bestnames).session_id
+    post '/epp/command/create', { frame: request_xml }, { 'HTTP_COOKIE' => "session=#{session_id}" }
+    assert_equal '1058ad73', Domain.find_by(name: 'brandnew.test').transfer_code
+  end
+end

test/integration/epp/domain/transfer/domain_transfer_test.rb

@@ -5,7 +5,7 @@ class EppDomainTransferTest < ActionDispatch::IntegrationTest
     login_as users(:api_goodnames)
   end
 
-  def test_transfers_domain
+  def test_successfully_transfers_domain
     request_xml = <<-XML
       <?xml version="1.0" encoding="UTF-8" standalone="no"?>
       <epp xmlns="https://epp.tld.ee/schema/epp-ee-1.0.xsd">
@@ -24,7 +24,30 @@ class EppDomainTransferTest < ActionDispatch::IntegrationTest
 
     session_id = epp_sessions(:api_goodnames).session_id
     post '/epp/command/transfer', { frame: request_xml }, { 'HTTP_COOKIE' => "session=#{session_id}" }
-    assert_response 200
     assert_equal registrars(:goodnames), domains(:shop).registrar
+    assert Nokogiri::XML(response.body).at_css('result[code="1000"]')
+    assert_equal 1, Nokogiri::XML(response.body).css('result').size
+  end
+
+  def test_non_existent_domain
+    request_xml = <<-XML
+      <?xml version="1.0" encoding="UTF-8" standalone="no"?>
+      <epp xmlns="https://epp.tld.ee/schema/epp-ee-1.0.xsd">
+        <command>
+          <transfer op="request">
+            <domain:transfer xmlns:domain="https://epp.tld.ee/schema/domain-eis-1.0.xsd">
+              <domain:name>non-existent.test</domain:name>
+              <domain:authInfo>
+                <domain:pw>any</domain:pw>
+              </domain:authInfo>
+            </domain:transfer>
+          </transfer>
+        </command>
+      </epp>
+    XML
+
+    session_id = epp_sessions(:api_goodnames).session_id
+    post '/epp/command/transfer', { frame: request_xml }, { 'HTTP_COOKIE' => "session=#{session_id}" }
+    assert Nokogiri::XML(response.body).at_css('result[code="2303"]')
   end
 end

test/integration/epp/domain/transfer/transfer_code_test.rb

@@ -0,0 +1,30 @@
+require 'test_helper'
+
+class EppDomainTransferTransferCodeTest < ActionDispatch::IntegrationTest
+  def setup
+    login_as users(:api_goodnames)
+  end
+
+  def test_wrong
+    request_xml = <<-XML
+      <?xml version="1.0" encoding="UTF-8" standalone="no"?>
+      <epp xmlns="https://epp.tld.ee/schema/epp-ee-1.0.xsd">
+        <command>
+          <transfer op="request">
+            <domain:transfer xmlns:domain="https://epp.tld.ee/schema/domain-eis-1.0.xsd">
+              <domain:name>shop.test</domain:name>
+              <domain:authInfo>
+                <domain:pw>wrong</domain:pw>
+              </domain:authInfo>
+            </domain:transfer>
+          </transfer>
+        </command>
+      </epp>
+    XML
+
+    session_id = epp_sessions(:api_goodnames).session_id
+    post '/epp/command/transfer', { frame: request_xml }, { 'HTTP_COOKIE' => "session=#{session_id}" }
+    refute_equal registrars(:goodnames), domains(:shop).registrar
+    assert Nokogiri::XML(response.body).at_css('result[code="2201"]')
+  end
+end

test/integration/epp/domain/update/transfer_code_test.rb

@@ -5,7 +5,7 @@ class EppDomainUpdateTest < ActionDispatch::IntegrationTest
     login_as users(:api_bestnames)
   end
 
-  def test_updates_transfer_code
+  def test_overwrites_existing
     request_xml = <<-XML
       <?xml version="1.0" encoding="UTF-8" standalone="no"?>
       <epp xmlns="https://epp.tld.ee/schema/epp-ee-1.0.xsd">
@@ -26,7 +26,6 @@ class EppDomainUpdateTest < ActionDispatch::IntegrationTest
 
     session_id = epp_sessions(:api_bestnames).session_id
     post '/epp/command/update', { frame: request_xml }, { 'HTTP_COOKIE' => "session=#{session_id}" }
-    assert_response 200
     assert_equal 'f0ff7d17b0', domains(:shop).transfer_code
   end
 end