zydronium/internetee-registry
1
0
Fork 0
mirror of https://github.com/internetee/registry.git synced 2025-08-04 17:01:44 +02:00
Code Issues Projects Releases Packages Wiki Activity

Improve ident-related error messages on EPP contact:update

Browse source 
#569
This commit is contained in:
Artur Beljajev 2017-09-12 19:00:01 +03:00
parent d5197962ee
commit 4e6d576b67
4 changed files with 21 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

14
app/models/epp/contact.rb
View file

@ -158,10 +158,10 @@ class Epp::Contact < Contact
# https://github.com/internetee/registry/issues/576
if ident_frame
if identifier.valid?
deny_ident_update
report_update_disallowed_error
else
ident_change_disallowed = ident_frame.text.present? && (ident_frame.text != ident)
deny_ident_update if ident_change_disallowed
wrong_ident = ident_frame.text.present? && (ident_frame.text != ident)
report_wrong_ident_error if wrong_ident
identifier = Ident.new(code: ident,
type: ident_frame.attr('type'),
@ -240,7 +240,11 @@ class Epp::Contact < Contact
private
def deny_ident_update
throw :epp_error, { code: '2308', msg: I18n.t(:ident_update_error) }
def report_update_disallowed_error
throw :epp_error, { code: '2308', msg: I18n.t('epp.contacts.errors.update_disallowed') }
end
def report_wrong_ident_error
throw :epp_error, { code: '2308', msg: I18n.t('epp.contacts.errors.wrong_ident') }
end
end