Improve readability

This commit is contained in:
Artur Beljajev 2018-06-11 08:10:32 +03:00
parent 304b04bd61
commit 4e2bd9f2da

View file

@ -21,7 +21,7 @@ class DomainForceDeleteTest < ActiveSupport::TestCase
end end
def test_scheduling_force_delete_adds_corresponding_statuses def test_scheduling_force_delete_adds_corresponding_statuses
statuses = [ statuses_to_be_added = [
DomainStatus::FORCE_DELETE, DomainStatus::FORCE_DELETE,
DomainStatus::SERVER_RENEW_PROHIBITED, DomainStatus::SERVER_RENEW_PROHIBITED,
DomainStatus::SERVER_TRANSFER_PROHIBITED, DomainStatus::SERVER_TRANSFER_PROHIBITED,
@ -31,11 +31,11 @@ class DomainForceDeleteTest < ActiveSupport::TestCase
@domain.schedule_force_delete @domain.schedule_force_delete
@domain.reload @domain.reload
assert (@domain.statuses & statuses) == statuses assert (@domain.statuses & statuses_to_be_added) == statuses_to_be_added
end end
def test_scheduling_force_delete_stops_pending_actions def test_scheduling_force_delete_stops_pending_actions
statuses = [ statuses_to_be_removed = [
DomainStatus::CLIENT_DELETE_PROHIBITED, DomainStatus::CLIENT_DELETE_PROHIBITED,
DomainStatus::SERVER_DELETE_PROHIBITED, DomainStatus::SERVER_DELETE_PROHIBITED,
DomainStatus::PENDING_UPDATE, DomainStatus::PENDING_UPDATE,
@ -44,10 +44,10 @@ class DomainForceDeleteTest < ActiveSupport::TestCase
DomainStatus::PENDING_CREATE, DomainStatus::PENDING_CREATE,
] ]
@domain.statuses = statuses + %w[other-status] @domain.statuses = statuses_to_be_removed + %w[other-status]
@domain.schedule_force_delete @domain.schedule_force_delete
@domain.reload @domain.reload
assert_not (@domain.statuses & statuses).any?, 'Pending actions should be stopped' assert_empty @domain.statuses & statuses_to_be_removed, 'Pending actions should be stopped'
end end
def test_scheduling_force_delete_preserves_current_statuses def test_scheduling_force_delete_preserves_current_statuses
@ -103,7 +103,7 @@ class DomainForceDeleteTest < ActiveSupport::TestCase
@domain.cancel_force_delete @domain.cancel_force_delete
@domain.reload @domain.reload
assert (@domain.statuses & statuses).empty? assert_empty @domain.statuses & statuses
end end
def test_cancelling_force_delete_restores_statuses_that_a_domain_had_before_force_delete def test_cancelling_force_delete_restores_statuses_that_a_domain_had_before_force_delete