Modified lhv connect controller

app/controllers/eis_billing/lhv_connect_transactions_controller.rb

@@ -34,7 +34,11 @@ module EisBilling
 
     def create_invoice_if_missing(transaction)
       Invoice.create_from_transaction!(transaction) unless transaction.autobindable?
-      transaction.autobind_invoice
+      invoice = transaction.autobind_invoice
+      return unless invoice.paid?
+
+      EisBilling::SendInvoiceStatus.send_info(invoice_number: invoice.number,
+                                              status: 'paid')
     end
 
     def transaction_attributes(incoming_transaction)

app/models/bank_transaction.rb

@@ -46,17 +46,11 @@ class BankTransaction < ApplicationRecord
     payment_order.save!
 
     if create_activity(registrar, invoice)
-      status = 'paid'
       payment_order.paid!
     else
-      status = 'failed'
+      payment_order.update(notes: 'Failed to create activity', status: 'failed')
-      payment_order.update(notes: 'Failed to create activity', status: status)
     end
-
+    invoice
-    return unless Feature.billing_system_integrated?
-
-    EisBilling::SendInvoiceStatus.send_info(invoice_number: invoice.number,
-                                            status: status)
   end
 
   def bind_invoice(invoice_no, manual: false)

test/models/bank_transaction_test.rb

@@ -4,10 +4,6 @@ class BankTransactionTest < ActiveSupport::TestCase
   setup do
     @registrar = registrars(:bestnames)
     @invoice = invoices(:one)
-    if Feature.billing_system_integrated?
-      stub_request(:post, 'https://eis_billing_system:3000/api/v1/invoice_generator/invoice_status')
-        .to_return(status: 200, body: '', headers: {})
-    end
   end
 
   def test_matches_against_invoice_nubmber_and_reference_number

test/tasks/invoices/process_payments_test.rb

@@ -30,11 +30,6 @@ class ProcessPaymentsTaskTest < ActiveJob::TestCase
         [message]
       end
     end
-
-    if Feature.billing_system_integrated?
-      stub_request(:post, 'https://eis_billing_system:3000/api/v1/invoice_generator/invoice_status')
-        .to_return(status: 200, body: '', headers: {})
-    end
   end
 
   def test_not_raises_error_if_bad_reference