Cleaned up rspec create settings and refactored whois_record

spec/features/admin/admin_user_spec.rb

@@ -1,8 +1,6 @@
 require 'rails_helper'
 
 feature 'Admin users', type: :feature do
-  background { create_settings }
-
   before :all do
     @admin_user = Fabricate(:admin_user, username: 'user1', identity_code: '37810013087')
   end

spec/features/admin/api_user_spec.rb

@@ -1,8 +1,6 @@
 require 'rails_helper'
 
 feature 'Api users', type: :feature do
-  background { create_settings }
-
   before :all do
     @user = Fabricate(:admin_user, username: 'user1', identity_code: '37810013087')
     @api_user = Fabricate(:api_user)

spec/features/admin/contact_spec.rb

@@ -1,8 +1,6 @@
 require 'rails_helper'
 
 feature 'Admin contact', type: :feature do
-  background { create_settings }
-
   before :all do
     @user = Fabricate(:admin_user, username: 'user1', identity_code: '37810013087')
     @contact = Fabricate(:contact, name: 'Mr John')

spec/features/admin/epp_log_spec.rb

@@ -1,8 +1,6 @@
 require 'rails_helper'
 
 feature 'EPP log', type: :feature do
-  background { create_settings }
-
   before :all do
     @user = Fabricate(:admin_user, username: 'user1', identity_code: '37810013087')
     @contact = Fabricate(:contact, name: 'Mr John')

spec/features/admin/invoice_spec.rb

@@ -1,8 +1,6 @@
 require 'rails_helper'
 
 feature 'Invoice', type: :feature do
-  background { create_settings }
-
   before :all do
     @user = Fabricate(:admin_user, username: 'user1', identity_code: '37810013087')
     Fabricate(:invoice)

spec/features/admin/repp_log_spec.rb

@@ -1,8 +1,6 @@
 require 'rails_helper'
 
 feature 'Repp log', type: :feature do
-  background { create_settings }
-
   before :all do
     @user = Fabricate(:admin_user, username: 'user1', identity_code: '37810013087')
   end

spec/features/admin/zonefile_setting_spec.rb

@@ -1,8 +1,6 @@
 require 'rails_helper'
 
 feature 'Zonefile settings', type: :feature do
-  background { create_settings }
-
   before :all do
     @user = Fabricate(:admin_user, username: 'user1', identity_code: '37810013087')
   end

spec/features/registrar/contact_spec.rb

@@ -2,7 +2,6 @@ require 'rails_helper'
 
 feature 'Contact', type: :feature do
   before :all do
-    create_settings
     @user = Fabricate(:api_user)
   end
 

spec/features/registrar/domain_spec.rb

@@ -2,7 +2,6 @@ require 'rails_helper'
 
 feature 'Domains', type: :feature do
   before :all do
-    create_settings
     @user = Fabricate(:api_user)
   end
 

spec/features/registrar/invoices_spec.rb

@@ -2,7 +2,6 @@ require 'rails_helper'
 
 feature 'Invoices', type: :feature do
   before :all do
-    create_settings
     @user = Fabricate(:api_user)
     @invoice = Fabricate(:invoice, buyer: @user.registrar)
   end

spec/features/registrar/root_spec.rb

@@ -2,7 +2,6 @@ require 'rails_helper'
 
 feature 'Root', type: :feature do
   before :all do
-    create_settings
     Fabricate(:api_user)
   end
 

spec/features/registrar/sessions_spec.rb

@@ -2,7 +2,6 @@ require 'rails_helper'
 
 feature 'Sessions', type: :feature do
   before :all do
-    create_settings
     Fabricate(:api_user)
   end
 

spec/features/sessions_spec.rb

@@ -2,7 +2,6 @@ require 'rails_helper'
 
 feature 'Sessions', type: :feature do
   before :all do
-    create_settings
     Fabricate(:ee_user)
     @registrar1 = Fabricate(:registrar1)
     @registrar2 = Fabricate(:registrar2)

spec/features/setting_management_spec.rb

@@ -3,8 +3,6 @@ require 'rails_helper'
 feature 'Setting management', type: :feature do
   let(:user) { Fabricate(:admin_user, username: 'user1', identity_code: '37810013087') }
 
-  background { create_settings }
-
   scenario 'User changes a setting' do
     sign_in user
     visit admin_settings_path